Improve Docker image and clean TODOs

This commit is contained in:
ngosang
2021-10-18 00:23:28 +02:00
parent cfd158462f
commit 77a87c79fd
5 changed files with 13 additions and 13 deletions

View File

@@ -24,7 +24,7 @@ export interface SessionCreateOptions {
oneTimeSession: boolean
cookies?: SetCookie[],
maxTimeout?: number
proxy?: any// TODO: use interface not any
proxy?: Proxy
}
const sessionCache: SessionsCache = {}
@@ -120,12 +120,9 @@ export async function create(session: string, options: SessionCreateOptions): Pr
log.debug('Launching web browser...')
// TODO: maybe access env variable?
// TODO: sometimes browser instances are created and not connected to correctly.
// how do we handle/quit those instances inside Docker?
// todo: the retries are required?
let launchTries = 3
let browser: Browser;
while (0 <= launchTries--) {
try {
browser = await puppeteer.launch(puppeteerOptions)
@@ -154,8 +151,6 @@ export function list(): string[] {
return Object.keys(sessionCache)
}
// todo: create a sessions.close that doesn't rm the userDataDir
export async function destroy(id: string): Promise<boolean>{
if (id && sessionCache.hasOwnProperty(id)) {
const { browser, userDataDir } = sessionCache[id]