2
0
forked from Wavyzz/dolibarr

fix some warnings phpstan

This commit is contained in:
Hystepik
2023-12-22 16:10:14 +01:00
parent 9746cc18e0
commit 0453b3efe2
4 changed files with 14 additions and 14 deletions

View File

@@ -185,7 +185,7 @@ class ExtraFields
* This is a private method. For public method, use addExtraField. * This is a private method. For public method, use addExtraField.
* *
* @param string $attrname code of attribute * @param string $attrname code of attribute
* @param int $type Type of attribute ('boolean', 'int', 'varchar', 'text', 'html', 'date', 'datehour','price','pricecy','phone','mail','password','url','select','checkbox', ...) * @param string $type Type of attribute ('boolean', 'int', 'varchar', 'text', 'html', 'date', 'datehour','price','pricecy','phone','mail','password','url','select','checkbox', ...)
* @param string $length Size/length of attribute ('5', '24,8', ...) * @param string $length Size/length of attribute ('5', '24,8', ...)
* @param string $elementtype Element type ('member', 'product', 'thirdparty', 'contact', ...) * @param string $elementtype Element type ('member', 'product', 'thirdparty', 'contact', ...)
* @param int $unique Is field unique or not * @param int $unique Is field unique or not
@@ -199,7 +199,7 @@ class ExtraFields
* @param array $moreparams More parameters. Example: array('css'=>, 'csslist'=>, 'cssview'=>...) * @param array $moreparams More parameters. Example: array('css'=>, 'csslist'=>, 'cssview'=>...)
* @return int Return integer <=0 if KO, >0 if OK * @return int Return integer <=0 if KO, >0 if OK
*/ */
private function create($attrname, $type = 'varchar', $length = 255, $elementtype = 'member', $unique = 0, $required = 0, $default_value = '', $param = '', $perms = '', $list = '0', $computed = '', $help = '', $moreparams = array()) private function create($attrname, $type = 'varchar', $length = '255', $elementtype = 'member', $unique = 0, $required = 0, $default_value = '', $param = array(), $perms = '', $list = '0', $computed = '', $help = '', $moreparams = array())
{ {
if ($elementtype == 'thirdparty') { if ($elementtype == 'thirdparty') {
$elementtype = 'societe'; $elementtype = 'societe';
@@ -281,7 +281,7 @@ class ExtraFields
* *
* @param string $attrname code of attribute * @param string $attrname code of attribute
* @param string $label label of attribute * @param string $label label of attribute
* @param int $type Type of attribute ('int', 'varchar', 'text', 'html', 'date', 'datehour', 'float') * @param string $type Type of attribute ('int', 'varchar', 'text', 'html', 'date', 'datehour', 'float')
* @param int $pos Position of attribute * @param int $pos Position of attribute
* @param string $size Size/length of attribute ('5', '24,8', ...) * @param string $size Size/length of attribute ('5', '24,8', ...)
* @param string $elementtype Element type ('member', 'product', 'thirdparty', ...) * @param string $elementtype Element type ('member', 'product', 'thirdparty', ...)
@@ -303,7 +303,7 @@ class ExtraFields
* @return int Return integer <=0 if KO, >0 if OK * @return int Return integer <=0 if KO, >0 if OK
* @throws Exception * @throws Exception
*/ */
private function create_label($attrname, $label = '', $type = '', $pos = 0, $size = 0, $elementtype = 'member', $unique = 0, $required = 0, $param = '', $alwayseditable = 0, $perms = '', $list = '-1', $help = '', $default = '', $computed = '', $entity = '', $langfile = '', $enabled = '1', $totalizable = 0, $printable = 0, $moreparams = array()) private function create_label($attrname, $label = '', $type = '', $pos = 0, $size = '', $elementtype = 'member', $unique = 0, $required = 0, $param = '', $alwayseditable = 0, $perms = '', $list = '-1', $help = '', $default = '', $computed = '', $entity = '', $langfile = '', $enabled = '1', $totalizable = 0, $printable = 0, $moreparams = array())
{ {
// phpcs:enable // phpcs:enable
global $conf, $user; global $conf, $user;
@@ -551,7 +551,7 @@ class ExtraFields
* @return int >0 if OK, <=0 if KO * @return int >0 if OK, <=0 if KO
* @throws Exception * @throws Exception
*/ */
public function update($attrname, $label, $type, $length, $elementtype, $unique = 0, $required = 0, $pos = 0, $param = '', $alwayseditable = 0, $perms = '', $list = '', $help = '', $default = '', $computed = '', $entity = '', $langfile = '', $enabled = '1', $totalizable = 0, $printable = 0, $moreparams = array()) public function update($attrname, $label, $type, $length, $elementtype, $unique = 0, $required = 0, $pos = 0, $param = array(), $alwayseditable = 0, $perms = '', $list = '', $help = '', $default = '', $computed = '', $entity = '', $langfile = '', $enabled = '1', $totalizable = 0, $printable = 0, $moreparams = array())
{ {
global $action, $hookmanager; global $action, $hookmanager;
@@ -676,7 +676,7 @@ class ExtraFields
* @return int Return integer <=0 if KO, >0 if OK * @return int Return integer <=0 if KO, >0 if OK
* @throws Exception * @throws Exception
*/ */
private function update_label($attrname, $label, $type, $size, $elementtype, $unique = 0, $required = 0, $pos = 0, $param = '', $alwayseditable = 0, $perms = '', $list = '0', $help = '', $default = '', $computed = '', $entity = '', $langfile = '', $enabled = '1', $totalizable = 0, $printable = 0, $moreparams = array()) private function update_label($attrname, $label, $type, $size, $elementtype, $unique = 0, $required = 0, $pos = 0, $param = array(), $alwayseditable = 0, $perms = '', $list = '0', $help = '', $default = '', $computed = '', $entity = '', $langfile = '', $enabled = '1', $totalizable = 0, $printable = 0, $moreparams = array())
{ {
// phpcs:enable // phpcs:enable
global $conf, $user; global $conf, $user;
@@ -934,7 +934,7 @@ class ExtraFields
* @param string $morecss More css (to defined size of field. Old behaviour: may also be a numeric) * @param string $morecss More css (to defined size of field. Old behaviour: may also be a numeric)
* @param int $objectid Current object id * @param int $objectid Current object id
* @param string $extrafieldsobjectkey The key to use to store retreived data (commonly $object->table_element) * @param string $extrafieldsobjectkey The key to use to store retreived data (commonly $object->table_element)
* @param string $mode 1=Used for search filters * @param int $mode 1=Used for search filters
* @return string * @return string
*/ */
public function showInputField($key, $value, $moreparam = '', $keysuffix = '', $keyprefix = '', $morecss = '', $objectid = 0, $extrafieldsobjectkey = '', $mode = 0) public function showInputField($key, $value, $moreparam = '', $keysuffix = '', $keyprefix = '', $morecss = '', $objectid = 0, $extrafieldsobjectkey = '', $mode = 0)

View File

@@ -134,7 +134,7 @@ class ExtraLanguages
* @param string $keyprefix Suffix string to add before name and id of field (can be used to avoid duplicate names) * @param string $keyprefix Suffix string to add before name and id of field (can be used to avoid duplicate names)
* @param string $morecss More css (to defined size of field. Old behaviour: may also be a numeric) * @param string $morecss More css (to defined size of field. Old behaviour: may also be a numeric)
* @param int $objectid Current object id * @param int $objectid Current object id
* @param string $mode 1=Used for search filters * @param int $mode 1=Used for search filters
* @return string * @return string
*/ */
public function showInputField($key, $value, $extrafieldsobjectkey, $moreparam = '', $keysuffix = '', $keyprefix = '', $morecss = '', $objectid = 0, $mode = 0) public function showInputField($key, $value, $extrafieldsobjectkey, $moreparam = '', $keysuffix = '', $keyprefix = '', $morecss = '', $objectid = 0, $mode = 0)

View File

@@ -463,9 +463,9 @@ class Fiscalyear extends CommonObject
/** /**
* Return the number of entries by fiscal year * Return the number of entries by fiscal year
* *
* @param int $datestart Date start to scan * @param int|string $datestart Date start to scan
* @param int $dateend Date end to scan * @param int|string $dateend Date end to scan
* @return string Number of entries * @return string Number of entries
*/ */
public function getAccountancyEntriesByFiscalYear($datestart = '', $dateend = '') public function getAccountancyEntriesByFiscalYear($datestart = '', $dateend = '')
{ {
@@ -497,8 +497,8 @@ class Fiscalyear extends CommonObject
/** /**
* Return the number of movements by fiscal year * Return the number of movements by fiscal year
* *
* @param int $datestart Date start to scan * @param int|string $datestart Date start to scan
* @param int $dateend Date end to scan * @param int|string $dateend Date end to scan
* @return string Number of movements * @return string Number of movements
*/ */
public function getAccountancyMovementsByFiscalYear($datestart = '', $dateend = '') public function getAccountancyMovementsByFiscalYear($datestart = '', $dateend = '')

View File

@@ -153,7 +153,7 @@ class HookManager
* All types can also return some values into an array ->results that will be finaly merged into this->resArray for caller. * All types can also return some values into an array ->results that will be finaly merged into this->resArray for caller.
* $this->error or this->errors are also defined by class called by this function if error. * $this->error or this->errors are also defined by class called by this function if error.
*/ */
public function executeHooks($method, $parameters = array(), &$object = '', &$action = '') public function executeHooks($method, $parameters = array(), &$object = null, &$action = '')
{ {
if (!is_array($this->hooks) || empty($this->hooks)) { if (!is_array($this->hooks) || empty($this->hooks)) {
return 0; // No hook available, do nothing. return 0; // No hook available, do nothing.