Wavyzz/dolibarr-fork
2
0
Fork 0
forked from Wavyzz/dolibarr
Code Pull Requests Activity

Qual: Fix Plugin ParamMatchRegexPlugin when classname is variable (#30970)

Browse Source 
# Qual: Fix Plugin ParamMatchRegexPlugin when classname is variable

Fix a case where the plugin throws an undefined variable because the
classname in the php source is variable
This commit is contained in:
MDW
2024-09-23 03:36:17 +02:00
committed by GitHub
parent 706f80ce84
commit 158de3d54a
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
dev/tools/phan/plugins/ParamMatchRegexPlugin.php
View File

@@ -135,8 +135,16 @@ class ParamMatchVisitor extends PluginAwarePostAnalysisVisitor
{ {
$class_name = $node->children['class']->children['name'] ?? null; $class_name = $node->children['class']->children['name'] ?? null;
if (!\is_string($class_name)) { if (!\is_string($class_name)) {
throw new NodeException($expr, 'does not have class'); // May happen for $this->className::$name(...$arguments); (variable class name)
$location = $this->context->getFile().":".$node->lineno;
print "$location: Node does not have fixed string class_name - node type ".(is_object($class_name) ? get_class_name($class_name) : gettype($class_name)).PHP_EOL;
return;
// throw new NodeException($node, 'does not have class');
} }
// } else {
// $location = $this->context->getFile().":".$node->lineno;
// print "$location: Static call - node type ".get_class($node).PHP_EOL;
//}
try { try {
$class_name = (string) FullyQualifiedClassName::fromFullyQualifiedString($class_name); $class_name = (string) FullyQualifiedClassName::fromFullyQualifiedString($class_name);
} catch (FQSENException $_) { } catch (FQSENException $_) {