Wavyzz/dolibarr-fork
2
0
Fork 0
forked from Wavyzz/dolibarr
Code Pull Requests Activity

qual : phpstan for htdocs/core/class/dolgraph.class.php (#28284)

Browse Source 
* qual : phpstan for htdocs/core/class/dolgraph.class.php

htdocs/core/class/dolgraph.class.php	703	Method DolGraph::GetCeilMaxValue() should return int but returns float.

htdocs/core/class/dolgraph.class.php	1551	Method DolGraph::total() should return string but returns (float|int).

htdocs/core/class/dolgraph.class.php	1593	Method DolGraph::getDefaultGraphSizeForStats() should return int but returns string.

htdocs/core/class/dolgraph.class.php	1599	Method DolGraph::getDefaultGraphSizeForStats() should return int but returns string.

* phpcs
This commit is contained in:
thibdrev
2024-02-20 02:04:41 +01:00
committed by GitHub
parent aadea9db4f
commit 7b1c8c43f6
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
htdocs/core/class/dolgraph.class.php
View File

@@ -700,7 +700,7 @@ class DolGraph
}
//print "max=".$max." res=".$res;
return $res;
return (int) $res;
}
// phpcs:disable PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
@@ -1540,7 +1540,7 @@ class DolGraph
/**
* Output HTML string to total value
*
* @return string HTML string to total value
* @return float|int HTML string to total value
*/
public function total()
{
@@ -1587,16 +1587,16 @@ class DolGraph
public static function getDefaultGraphSizeForStats($direction, $defaultsize = '')
{
global $conf;
$defaultsize = (int) $defaultsize;
if ($direction == 'width') {
if (empty($conf->dol_optimize_smallscreen)) {
return ($defaultsize ? $defaultsize : '500');
return ($defaultsize ? $defaultsize : 500);
} else {
return (empty($_SESSION['dol_screenwidth']) ? '280' : ($_SESSION['dol_screenwidth'] - 40));
return (empty($_SESSION['dol_screenwidth']) ? 280 : ($_SESSION['dol_screenwidth'] - 40));
}
}
if ($direction == 'height') {
return (empty($conf->dol_optimize_smallscreen) ? ($defaultsize ? $defaultsize : '220') : '200');
} elseif ($direction == 'height') {
return (empty($conf->dol_optimize_smallscreen) ? ($defaultsize ? $defaultsize : 220) : 200);
}
return 0;
}