Wavyzz/dolibarr-fork
2
0
Fork 0
forked from Wavyzz/dolibarr
Code Pull Requests Activity

Qual: 4 functions with hardcoded elementtype = 'member' replaced with elementtype = '' (#29256)

Browse Source 
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
This commit is contained in:
Jon Bendtsen
2024-04-07 12:35:40 +02:00
committed by GitHub
parent 3fad52815a
commit b586f90f59
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
htdocs/core/class/extrafields.class.php
View File

@@ -201,7 +201,7 @@ class ExtraFields
* @param array $moreparams More parameters. Example: array('css'=>, 'csslist'=>, 'cssview'=>...) * @param array $moreparams More parameters. Example: array('css'=>, 'csslist'=>, 'cssview'=>...)
* @return int Return integer <=0 if KO, >0 if OK * @return int Return integer <=0 if KO, >0 if OK
*/ */
private function create($attrname, $type = 'varchar', $length = '255', $elementtype = 'member', $unique = 0, $required = 0, $default_value = '', $param = array(), $perms = '', $list = '0', $computed = '', $help = '', $moreparams = array()) private function create($attrname, $type = 'varchar', $length = '255', $elementtype = '', $unique = 0, $required = 0, $default_value = '', $param = array(), $perms = '', $list = '0', $computed = '', $help = '', $moreparams = array())
{ {
if ($elementtype == 'thirdparty') { if ($elementtype == 'thirdparty') {
$elementtype = 'societe'; $elementtype = 'societe';
@@ -305,7 +305,7 @@ class ExtraFields
* @return int Return integer <=0 if KO, >0 if OK * @return int Return integer <=0 if KO, >0 if OK
* @throws Exception * @throws Exception
*/ */
private function create_label($attrname, $label = '', $type = '', $pos = 0, $size = '', $elementtype = 'member', $unique = 0, $required = 0, $param = '', $alwayseditable = 0, $perms = '', $list = '-1', $help = '', $default = '', $computed = '', $entity = '', $langfile = '', $enabled = '1', $totalizable = 0, $printable = 0, $moreparams = array()) private function create_label($attrname, $label = '', $type = '', $pos = 0, $size = '', $elementtype = '', $unique = 0, $required = 0, $param = '', $alwayseditable = 0, $perms = '', $list = '-1', $help = '', $default = '', $computed = '', $entity = '', $langfile = '', $enabled = '1', $totalizable = 0, $printable = 0, $moreparams = array())
{ {
// phpcs:enable // phpcs:enable
global $conf, $user; global $conf, $user;
@@ -437,7 +437,7 @@ class ExtraFields
* @param string $elementtype Element type ('member', 'product', 'thirdparty', 'contact', ...) * @param string $elementtype Element type ('member', 'product', 'thirdparty', 'contact', ...)
* @return int Return integer < 0 if KO, 0 if nothing is done, 1 if OK * @return int Return integer < 0 if KO, 0 if nothing is done, 1 if OK
*/ */
public function delete($attrname, $elementtype = 'member') public function delete($attrname, $elementtype = '')
{ {
if ($elementtype == 'thirdparty') { if ($elementtype == 'thirdparty') {
$elementtype = 'societe'; $elementtype = 'societe';
@@ -495,7 +495,7 @@ class ExtraFields
* @param string $elementtype Element type ('member', 'product', 'thirdparty', ...) * @param string $elementtype Element type ('member', 'product', 'thirdparty', ...)
* @return int Return integer < 0 if KO, 0 if nothing is done, 1 if OK * @return int Return integer < 0 if KO, 0 if nothing is done, 1 if OK
*/ */
private function delete_label($attrname, $elementtype = 'member') private function delete_label($attrname, $elementtype = '')
{ {
// phpcs:enable // phpcs:enable
global $conf; global $conf;