Wavyzz/dolibarr-fork
2
0
Fork 0
forked from Wavyzz/dolibarr
Code Pull Requests Activity

phpunit: use $db instead of $this->savdb

Browse Source 
The global variables are stored in $this, and in particular $db is used
through this mean. But $this->savdb is supposed to be the immutable
global state that is stored at the test class instantiation and restored
at the beginning of each test.

For $this->savdb, I don't think any consequences are created by this,
since the object is saved by each test anyway and the $db object is
mostly a query object within a transaction, but future change could use
this to inject a different stateful $db object to trace some behaviour
in the test for instance, so make sure the correct one is used.
This commit is contained in:
Alexandre Janniaux
2023-04-13 20:25:07 +02:00
parent 2635ec9c19
commit b6235c29d0
46 changed files with 198 additions and 194 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/phpunit/ExpenseReportTest.php
View File

@@ -184,7 +184,7 @@ class ExpenseReportTest extends PHPUnit\Framework\TestCase
$langs=$this->savlangs;
$db=$this->savdb;
$localobject=new ExpenseReport($this->savdb);
$localobject=new ExpenseReport($db);
$result=$localobject->fetch($id);
print __METHOD__." id=".$id." result=".$result."\n";
@@ -305,7 +305,7 @@ class ExpenseReportTest extends PHPUnit\Framework\TestCase
$langs=$this->savlangs;
$db=$this->savdb;
$localobject=new ExpenseReport($this->savdb);
$localobject=new ExpenseReport($db);
$result=$localobject->fetch($id);
$result=$localobject->delete($user);