Wavyzz/dolibarr-fork
2
0
Fork 0
forked from Wavyzz/dolibarr
Code Pull Requests Activity

phpunit: use $db instead of $this->savdb

Browse Source 
The global variables are stored in $this, and in particular $db is used
through this mean. But $this->savdb is supposed to be the immutable
global state that is stored at the test class instantiation and restored
at the beginning of each test.

For $this->savdb, I don't think any consequences are created by this,
since the object is saved by each test anyway and the $db object is
mostly a query object within a transaction, but future change could use
this to inject a different stateful $db object to trace some behaviour
in the test for instance, so make sure the correct one is used.
This commit is contained in:
Alexandre Janniaux
2023-04-13 20:25:07 +02:00
parent 2635ec9c19
commit b6235c29d0
46 changed files with 198 additions and 194 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/phpunit/PricesTest.php
View File

@@ -324,14 +324,14 @@ class PricesTest extends PHPUnit\Framework\TestCase
$conf->global->MAIN_ROUNDOFTOTAL_NOT_TOTALOFROUND=0;
// Two lines of 1.24 give 2.48 HT and 2.72 TTC with standard vat rounding mode
$localobject=new Facture($this->savdb);
$localobject=new Facture($db);
$localobject->initAsSpecimen('nolines');
$invoiceid=$localobject->create($user);
$localobject->addline('Desc', 1.24, 1, 10, 0, 0, 0, 0, '', '', 0, 0, 0, 'HT');
$localobject->addline('Desc', 1.24, 1, 10, 0, 0, 0, 0, '', '', 0, 0, 0, 'HT');
$newlocalobject=new Facture($this->savdb);
$newlocalobject=new Facture($db);
$newlocalobject->fetch($invoiceid);
$this->assertEquals(2.48, $newlocalobject->total_ht, "testUpdatePrice test1");
@@ -340,14 +340,14 @@ class PricesTest extends PHPUnit\Framework\TestCase
// Two lines of 1.24 give 2.48 HT and 2.73 TTC with global vat rounding mode
$localobject=new Facture($this->savdb);
$localobject=new Facture($db);
$localobject->initAsSpecimen('nolines');
$invoiceid=$localobject->create($user);
$localobject->addline('Desc', 1.24, 1, 10, 0, 0, 0, 0, '', '', 0, 0, 0, 'HT');
$localobject->addline('Desc', 1.24, 1, 10, 0, 0, 0, 0, '', '', 0, 0, 0, 'HT');
$newlocalobject=new Facture($this->savdb);
$newlocalobject=new Facture($db);
$newlocalobject->fetch($invoiceid);
$this->assertEquals(2.48, $newlocalobject->total_ht, "testUpdatePrice test4");