Wavyzz/dolibarr-fork
2
0
Fork 0
forked from Wavyzz/dolibarr
Code Pull Requests Activity

Qual: Fix phan notices in admin.lib and tax.lib + related (#31414)

Browse Source 
* Qual: Fix admin.lib phpstan/phan notices

* Qual: Fix some argument types in Societe methods

* Fixup phpdoc

* Qual: Improve typing for static analysis

* Qual: Improve typing for static analysis

* Fix tax typing

* Qual: further phan/phpstan notice fixes in dol_generic_project_odt

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
This commit is contained in:
MDW
2024-10-17 03:08:38 +02:00
committed by GitHub
parent c789c4fc42
commit cee4535975
17 changed files with 329 additions and 280 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
htdocs/core/lib/admin.lib.php
View File

@@ -32,7 +32,7 @@ require_once DOL_DOCUMENT_ROOT.'/core/lib/functions2.lib.php';
/**
* Renvoi une version en chaine depuis une version en tableau
*
* @param array $versionarray Tableau de version (vermajeur,vermineur,autre)
* @param array<int<0,2>,int|string> $versionarray Tableau de version (vermajeur,vermineur,autre)
* @return string Chaine version
* @see versioncompare()
*/
@@ -59,9 +59,9 @@ function versiontostring($versionarray)
* For example: if (versioncompare(versiondolibarrarray(),array(4,0,1)) >= 0) is true if version is 4.0.1 or higher.
* Alternative way to compare: if ((float) DOL_VERSION >= 4.0) is true if version is 4.0 alpha or higher (works only to compare first and second level)
*
* @param array $versionarray1 Array of version (vermajor,verminor,patch)
* @param array $versionarray2 Array of version (vermajor,verminor,patch)
* @return int -4,-3,-2,-1 if versionarray1<versionarray2 (value depends on level of difference)
* @param array<int|string> $versionarray1 Array of version (vermajor,verminor,patch)
* @param array<int|string> $versionarray2 Array of version (vermajor,verminor,patch)
* @return int<-4,4> -4,-3,-2,-1 if versionarray1<versionarray2 (value depends on level of difference)
* 0 if same
* 1,2,3,4 if versionarray1>versionarray2 (value depends on level of difference)
* @see versiontostring()
@@ -125,7 +125,7 @@ function versioncompare($versionarray1, $versionarray2)
/**
* Return version PHP
*
* @return array Tableau de version (vermajeur,vermineur,autre)
* @return array<int<0,2>,string> Tableau de version (vermajeur,vermineur,autre)
* @see versioncompare()
*/
function versionphparray()
@@ -136,7 +136,7 @@ function versionphparray()
/**
* Return version Dolibarr
*
* @return array Tableau de version (vermajeur,vermineur,autre)
* @return array<int<0,2>,string> Tableau de version (vermajeur,vermineur,autre)
* @see versioncompare()
*/
function versiondolibarrarray()
@@ -1369,18 +1369,18 @@ function unActivateModule($value, $requiredby = 1)
* Add external modules to list of dictionaries.
* Addition is done into var $taborder, $tabname, etc... that are passed with pointers.
*
* @param array $taborder Taborder
* @param array $tabname Tabname
* @param array $tablib Tablib
* @param array $tabsql Tabsql
* @param array $tabsqlsort Tabsqlsort
* @param array $tabfield Tabfield
* @param array $tabfieldvalue Tabfieldvalue
* @param array $tabfieldinsert Tabfieldinsert
* @param array $tabrowid Tabrowid
* @param array $tabcond Tabcond
* @param array $tabhelp Tabhelp
* @param array $tabcomplete Tab complete (will replace all other in future). Key is table name.
* @param int[] $taborder Taborder
* @param string[] $tabname Tabname
* @param string[] $tablib Tablib
* @param string[] $tabsql Tabsql
* @param string[] $tabsqlsort Tabsqlsort
* @param string[] $tabfield Tabfield
* @param string[] $tabfieldvalue Tabfieldvalue
* @param string[] $tabfieldinsert Tabfieldinsert
* @param string[] $tabrowid Tabrowid
* @param bool[] $tabcond Tabcond
* @param array<array<string,string>> $tabhelp Tabhelp
* @param array<string,array<string,array<string,string>>> $tabcomplete Tab complete (will replace all other in future). Key is table name.
* @return int 1
*/
function complete_dictionary_with_modules(&$taborder, &$tabname, &$tablib, &$tabsql, &$tabsqlsort, &$tabfield, &$tabfieldvalue, &$tabfieldinsert, &$tabrowid, &$tabcond, &$tabhelp, &$tabcomplete)
@@ -2047,7 +2047,7 @@ function delDocumentModel($name, $type)
/**
* Return the php_info into an array
*
* @return array Array with PHP infos
* @return array<string,array<string,string|array{local:string,master:string}>> Array with PHP info
*/
function phpinfo_array()
{