From d2ff7481ddfa2e19ad746176d6f48fb0b4e3dd57 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20France?= <frederic.france@free.fr>
Date: Tue, 17 Dec 2024 21:42:26 +0100
Subject: [PATCH] fix phan and phpstan

---
 htdocs/salaries/class/salary.class.php | 3 ++-
 htdocs/salaries/list.php               | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/htdocs/salaries/class/salary.class.php b/htdocs/salaries/class/salary.class.php
index a70fce80e07..e0d3abf655c 100644
--- a/htdocs/salaries/class/salary.class.php
+++ b/htdocs/salaries/class/salary.class.php
@@ -120,6 +120,7 @@ class Salary extends CommonObject
 
 	/**
 	 * @var int
+	 * @deprecated see $accountid
 	 * @see $accountid
 	 */
 	public $fk_account;
@@ -154,7 +155,7 @@ class Salary extends CommonObject
 	const STATUS_PAID = 1;
 
 	/**
-	 * @var string
+	 * @var float amount remain to pay
 	 */
 	public $resteapayer;
 
diff --git a/htdocs/salaries/list.php b/htdocs/salaries/list.php
index 698fdf9ab4f..f72c3a4512f 100644
--- a/htdocs/salaries/list.php
+++ b/htdocs/salaries/list.php
@@ -193,8 +193,8 @@ if ($massaction == 'withdrawrequest') {
 			$objecttmp = new Salary($db);
 			$result = $objecttmp->fetch($toselectid);
 			if ($result > 0) {
-				$totalpaid = $objecttmp->getSommePaiement();
-				$objecttmp->resteapayer = price2num((float) $objecttmp->amount - $totalpaid, 'MT');
+				$totalpaid = (float) $objecttmp->getSommePaiement();
+				$objecttmp->resteapayer = (float) price2num((float) $objecttmp->amount - $totalpaid, 'MT');
 
 				// hook to finalize the remaining amount, considering e.g. cash discount agreements
 				$parameters = array('remaintopay' => $objecttmp->resteapayer);