Wavyzz/dolibarr-fork
2
0
Fork 0
forked from Wavyzz/dolibarr
Code Pull Requests Activity

Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions (#28749)

Browse Source 
# Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions

Fix occurences of PhanPluginDuplicateIfStatements which are if statements where the
consecutive branches execute the same code, making it useles to test the condition
This commit is contained in:
MDW
2024-03-11 12:58:51 +01:00
committed by GitHub
parent aee0509473
commit dbfb1180ee
23 changed files with 1535 additions and 1683 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
htdocs/core/class/commonobject.class.php
View File

@@ -1667,11 +1667,7 @@ abstract class CommonObject
$tmpelement = $obj->element;
$transkey = "TypeContact_".$tmpelement."_".$source."_".$obj->code;
$libelle_type = ($langs->trans($transkey) != $transkey ? $langs->trans($transkey) : $obj->type_label);
if (empty($option)) {
$tab[$obj->rowid] = $libelle_element.' - '.$libelle_type;
} else {
$tab[$obj->rowid] = $libelle_element.' - '.$libelle_type;
}
$tab[$obj->rowid] = $libelle_element.' - '.$libelle_type;
}
}
}
@@ -8846,13 +8842,7 @@ abstract class CommonObject
}
$out .= ($display_type == 'card' ? '</td>' : '</div>');
if (getDolGlobalString('MAIN_EXTRAFIELDS_USE_TWO_COLUMS') && (($e % 2) == 1)) {
$out .= ($display_type == 'card' ? '</tr>' : '</div>');
} else {
$out .= ($display_type == 'card' ? '</tr>' : '</div>');
}
$out .= ($display_type == 'card' ? '</tr>' : '</div>');
$e++;
}
}