Wavyzz/dolibarr-fork
2
0
Fork 0
forked from Wavyzz/dolibarr
Code Pull Requests Activity
148,250 Commits 36 Branches 189 Tags
develop
Commit Graph

114 Commits

Author SHA1 Message Date
Laurent Destailleur
0af854e355 Log 2025-08-26 05:46:26 +02:00
MDW
e7539f2e19 Qual: Fix notices in .lib.php files (#31672) 
* Qual: Fix notices in .lib.php files

* Update wrapper.php

* Update availabilities_card.php

* Update index.php

* Update document.controller.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-11-04 12:32:13 +01:00
Laurent Destailleur
6065984cce NEW Can force log file name using a define('SYSLOG_FILE_ADDSUFFIX') 
NEW Can force ip into log file name using a define('SYSLOG_FILE_ADDIP')
 2024-09-18 13:27:30 +02:00
MDW
32732d37d2 Qual: Improve typing in Export class (#30859) 
* Update baseline

* Qual: Improve typing in Export class

* Add 'abstract' methods to help with typing

* Add some typing

* Improve typing in export modules

* Improve typing for AccountancyExport

* Qual: PHPDoc executeCLI (nullable arguments, range)

* PHPDoc for export function

* Fix $permissiontoClose -> $permissiontoclose

* PHPDoc - Improve AccountingJournal typing

* Improve export_journal tpl typing

* Improve html.formsetup typing

* Impove commonfieldsexport typing

* Improve extrafieldsinexport typing

* Fix typing, initialisation

* Fix typing intracommreport

* Ensure string in $error for CronJob
 2024-09-09 03:15:26 +02:00
MDW
e6630cd7d1 Qual: Improve dol_syslog (#30782) 
* Qual: 🛟 Fix reference to $db with $this->db

# Qual: reference to $db with $this->db

$db was undeclared, use $this->db.

* Fix suspected issue with environment max size and md5sum working on limited files

* Qual: Fix LDAP typing

* Qual: Improve dol_syslog

# Qual: Improve dol_syslog

The changes:
- Keep the log file open for less time (better for concurrency);
- Open the log file only to append data (no internal preparation for writing);
- Avoids re-assigning a constant array;
- Add PHPDoc information about the array parameters and return values;
- May reduce the computation of global settings;
- Result in a slight performance improvement.
 2024-08-29 08:49:27 +02:00
MDW
54880f92cd Qual: Fix PhanTypeMismatchProperty and some other phan notices (#30542) 
* Qual: Fix PhanTypeMismatchProperty and some other phan notices

* Qual: Phan fixes for BOM

* Phan - fix fields

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Fix $fields phpdoc

* Fix phan typing issues with intermediate var and ??

* Fix phan typing issue with ?? operator

* Ignore htdocs/install/install.forced.php for git

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Update baseline

* Qual: Phan fixes for BOM

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration

* Fix typing hints (phpstan)

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-15 17:05:00 +02:00
Laurent Destailleur
0ceacfdc6a Clean code 2024-04-25 11:13:34 +02:00
MDW
da9fd874bc Qual: Fix or ignore functions.lib.php phan notices (#29344) 
* Fix: LogHandler parent class, implements interface & provides $code

* Fix: functions.lib phan notices

* Fix phan notifications

* Match expected DebugBar signature - rename getRenderer

* Call the correct renderer method for the DebugBar

* Use correct key type to access array

* Ignore notices

* Update functions.lib.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-04-14 04:46:33 +02:00
Regis Houssin
0da7288546 FIX try to fix phan error 2024-03-26 22:47:57 +01:00
Laurent Destailleur
caf6367a4e NEW Add the process and user ID into log 2024-03-26 14:14:11 +01:00
Frédéric France
c76ab41c91 fix warnings with syslog checkconfiguration 2024-03-21 22:01:11 +01:00
Frédéric France
ce38158c35 fix warnings with syslog checkconfiguration 2024-03-21 21:50:42 +01:00
MDW
012f284b3d Fix PhanParamSuspiciousOrder by suppressing notification 2024-03-17 20:12:53 +01:00
MDW
abbec034c6 Qual: Several typing hints/some fixes. (#28483) 
* Update documentation to improve static tool messages

* Suppress PhanPluginSuspiciousParamOrder

* Fix typing hint

* Fix typing hint (number->int)

* Fix typing hint (PDF->TCPDF)

* Fix typing hint (PDF->TCPDF)

* Modify code to hint typing check

* Correct Noop statement (createfromclone)

* Remove useless if/else with same result

* Suppress PhanRedefineFunctionInternal

* Suppress PhanParamSuspiciousOrder

* Suppress PhanPluginDuplicateArrayKey

* Suppress multiple phan messages

* Ignore PhanPluginSuspiciousParamOrder

* Add phan typing

* Remove useless if statement

* Remove useless if/else condition

* Remove useless if

* Remove useless if

* Join duplicate if/else statements

* Fix useless if

* Fix useless if

* Fix phan notice by optimizing 2**$i to 1<<$i
 2024-02-28 15:36:29 +01:00
MDW
8655d5a86b QUAL Use phan to help detect new issues (#27706) 
* Qual: Add phan flow

- Add phan configuration (config, baseline, stubs);
- Add github action;
- Update apstats.php.

* Add directives to ignore false phan notices

* Qual: Add typing hints for extrafields TPL files

# Qual: Add typing hints for extrafields TPL files

Add typing hints for phan on view files

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-02-21 18:14:29 +01:00
Laurent Destailleur
fb61fa4c4d Close #28245 2024-02-18 15:01:19 +01:00
Laurent Destailleur
4501872f17 Clean code with rector 2 2024-01-05 04:33:58 +01:00
Laurent Destailleur
2e445b2a6d Debug v19 2023-12-11 09:13:10 +01:00
Laurent Destailleur
9e1b90e4a1 Fix with php-cs-fixer 2023-12-04 12:07:31 +01:00
Laurent Destailleur
53dab922fd Fix php8.2 warnings 2023-11-27 11:39:32 +01:00
Laurent Destailleur
1f38e54e78 Clean code 2023-10-15 15:32:35 +02:00
Dev2a
fcd4c4e429 Fix: Change access to $conf->global to function getDolGlobal (automatique) 2023-10-08 23:19:49 +02:00
Laurent Destailleur
3e599b1c63 Fix dump of mail log file 2023-03-30 22:25:29 +02:00
Laurent Destailleur
0b4cacd291 Use dolChmod 2023-02-17 20:01:53 +01:00
Laurent Destailleur
b268f630a1 NEW conf->global->SYSLOG_FILE_ONEPERSESSION accept a string 2022-10-28 02:53:41 +02:00
Laurent Destailleur
a0203af926 Code comment 2022-10-28 02:49:57 +02:00
Laurent Destailleur
41ce28996c PHP 8.1 #21121 2022-06-03 11:10:08 +02:00
Laurent Destailleur
8a62d97b89 Remove one thousand of useless files 2021-04-12 15:57:16 +02:00
Frédéric FRANCE
554e449e40 code syntax core directory 2021-02-23 22:03:23 +01:00
Scrutinizer Auto-Fixer
7f52920716 Scrutinizer Auto-Fixes 
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
 2020-10-31 13:32:18 +00:00
Laurent Destailleur
e4bd75dbdc Enhancement for #14589 2020-09-22 16:26:53 +02:00
Frédéric FRANCE
b41ac00b98 add new rule 2020-05-21 15:05:19 +02:00
Frédéric FRANCE
ee6fadd0d5 add new rule 2020-05-21 01:41:27 +02:00
Scrutinizer Auto-Fixer
444c293c01 Scrutinizer Auto-Fixes 
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
 2020-04-10 08:59:32 +00:00
Scrutinizer Auto-Fixer
e8083e2a65 Scrutinizer Auto-Fixes 
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
 2020-03-23 14:54:02 +00:00
Alexandre SPANGARO
02dbc11f98 Move Gnu.org to https 2019-09-23 21:55:30 +02:00
Laurent Destailleur
f2e03b3909 Removed useless files (replaced with DebugBar) 2019-05-26 11:24:57 +02:00
Frédéric FRANCE
2745f98644 PSR2.Classes.PropertyDeclaration.VarUsed 2019-03-05 22:10:46 +01:00
Laurent Destailleur
a6dde3d6bd Merge branch 'develop' into nospaceaftercomma 2019-02-03 19:27:16 +01:00
Frédéric FRANCE
273d68381c psr2 end file new line none found 2019-02-03 15:21:21 +01:00
Frédéric FRANCE
b10558bacd Merge remote-tracking branch 'upstream/develop' into nospaceaftercomma 2019-01-27 23:23:38 +01:00
Frédéric FRANCE
f0cdf300d1 Squiz.Functions.FunctionDeclarationArgumentSpacing 2019-01-27 15:20:16 +01:00
Frédéric FRANCE
7ee086b402 PSR2 space after comma in function call 2019-01-27 11:55:16 +01:00
Frédéric FRANCE
6cb0fb10d6 trim trailing 2018-07-26 19:05:34 +02:00
Frédéric FRANCE
a0a5d33641 test include 2018-07-26 17:30:53 +02:00
Laurent Destailleur
3e54ee5df7 Merge pull request #9131 from fappels/7.0_Fix_syslog_infinite_loop 
Fix chromephp firephp Syslog infinite loop
 2018-07-24 16:53:32 +02:00
fappels
b697307bac Fix chromephp firephp Syslog infinite loop. 
When chromephp/firephp not found ->trans causes infinite loop. Can
happen when files moved to other server or location.
 2018-07-22 10:41:39 +02:00
Laurent Destailleur
2649c136cf Fix SYSLOG_FILE_ONEPERSESSION 2018-06-24 14:31:03 +02:00
Laurent Destailleur
848c8cdc4b Fix mode SYSLOG_FILE_ONEPERSESSION to work as expected 2018-06-24 13:59:37 +02:00
Laurent Destailleur
9eeaf5c3eb dol_syslog now strftime instead of dol_print_date 2018-04-21 12:22:21 +02:00