Laurent Destailleur
bc8e4c19cc
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2024-04-07 15:06:46 +02:00
Frédéric FRANCE
95eb1abf2e
clean code ( #29268 )
2024-04-07 15:01:29 +02:00
Laurent Destailleur
b5de782c6b
Fix use the good HTTP code
2024-04-07 14:59:25 +02:00
Frédéric FRANCE
97240a05b0
fix phpdoc ( #29266 )
2024-04-07 14:17:50 +02:00
Laurent Destailleur
fd9475be03
Use same doc comment eveywhere.
2024-04-07 12:26:27 +02:00
Laurent Destailleur
38fb00489d
PHPDoc
2024-04-05 13:44:59 +02:00
Laurent Destailleur
cca200d581
Debug v20
2024-04-02 17:02:14 +02:00
Laurent Destailleur
990216b13f
NEW Api parameters are sanitized by the WAF, same code than GET/POST
2024-04-02 13:07:13 +02:00
Laurent Destailleur
b58e439a17
Clean use of $_POST
2024-03-28 21:29:02 +01:00
Laurent Destailleur
3e8c3edd6d
Clean code from _GET
2024-03-28 17:10:22 +01:00
MDW
c6bc7eac88
Fix PhanTypeInvalid{Left,Right}OperandOfNumericOp mostly by typing, casting, idate
2024-03-23 02:06:27 +01:00
MDW
94808e7cdd
Fix PhanTypeInvalid{Left,Right}OperandOfNumericOp mostly by typing, casting, idate
2024-03-23 02:06:26 +01:00
MDW
b2a3985fb3
Fix typing with casts, idate and fix month/year formatting
2024-03-22 09:51:45 +01:00
Laurent Destailleur
51a3641105
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
...
Conflicts:
htdocs/bom/tpl/objectline_create.tpl.php
htdocs/compta/bank/releve.php
htdocs/core/class/html.formsetup.class.php
htdocs/takepos/freezone.php
2024-03-22 02:35:37 +01:00
Laurent Destailleur
7b0177a84d
Move to getDolGlobalString
2024-03-22 00:37:56 +01:00
Laurent Destailleur
ea1762f0fd
Update releve.php
2024-03-21 14:36:31 +01:00
PsyCrow
5f1c05308a
PHP Warning: Undefined array key 1 on line 533
...
PHP Warning: Undefined array key 1 on line 533
2024-03-21 00:54:54 -06:00
MDW
aeefca7e7e
Fix $arrayfields typing lost by dol_sort_array() by forcing the type
2024-03-20 23:29:48 +01:00
MDW
e515cc864d
Fix arg type to preg_replace() with cast
2024-03-20 04:08:31 +01:00
MDW
f11191a9d9
Fix arg type to abs by exchanging func. calls
2024-03-20 04:08:28 +01:00
MDW
fd9d48faac
Fix phpstan CommonObject->fields - notnull is optional field
2024-03-19 00:32:00 +01:00
Laurent Destailleur
e994d6650f
Fix regression in GETPOST limit
2024-03-16 11:41:00 +01:00
Laurent Destailleur
79aa9fb1f1
Code simpler
2024-03-15 20:29:21 +01:00
Laurent Destailleur
372c8445fd
Merge pull request #28809 from mdeweerd/PhanPluginPrintfIncompatibleArgumentTypeWeak
...
Fix & enable PhanPluginPrintfIncompatibleArgumentTypeWeak occurrences
2024-03-15 16:32:40 +01:00
Laurent Destailleur
29d6c2b76e
Fix for #28821 ->status is int ->labelStatus is array of label.
2024-03-15 15:07:05 +01:00
Laurent Destailleur
80e2e59373
Merge pull request #28862 from mdeweerd/fix/PhanTypeMismatchPropertyDefault
...
Fix & enable PhanTypeMismatchPropertyDefault
2024-03-15 09:33:40 +01:00
MDW
23785393a3
Add csslist to json keys
2024-03-15 03:55:52 +01:00
MDW
c27a93401c
Fix PhanTypeMismatchPropertyDefault
2024-03-15 03:44:45 +01:00
MDW
0f8b9e73f0
Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences
...
# Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences
Fix the PhanPluginPrintfIncompatibleArgumentTypeWeak occurences and fix the rule
2024-03-14 23:00:47 +01:00
MDW
929da49242
Fix PhanPluginSuspiciousParamPosition by renaming arg (from ext.var)
2024-03-14 19:39:52 +01:00
MDW
5b88c4e466
Fix PhanPluginSuspiciousParamPosition by renaming arg (from ext.var)
2024-03-14 19:39:51 +01:00
MDW
01e4397f3a
Fix PhanPluginSuspiciousParamPosition by renaming arg (local assign)
2024-03-14 19:39:50 +01:00
MDW
0f76544e0f
Fix PhanPluginDuplicateExpressionAssignment (NOOP assignment)
2024-03-12 22:25:32 +01:00
Laurent Destailleur
74b8162d22
Merge pull request #28700 from mdeweerd/urlencode/fixuptype
...
Fix: Ensure the argument type for urlencode is string
2024-03-12 14:43:41 +01:00
MDW
88d59896ec
Qual: 'enabled' in fields can be string ('isModEnabled(...)')
...
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')
Update PHPdoc to allow that enabled is a string
2024-03-12 13:38:08 +01:00
MDW
a8a7d71426
Fix: Repeat fields typing in CommonClass children
...
# Fix: Repeat fields typing in CommonClass children
phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:01 +01:00
MDW
ec18ec0605
Fix: Repeat fields typing in CommonClass children
...
# Fix: Repeat fields typing in CommonClass children
phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:59 +01:00
Laurent Destailleur
f7024b61ee
Update api_bankaccounts.class.php
2024-03-11 15:37:16 +01:00
Jon Bendtsen
668d2fa6e8
making param string cheque_number line up and conform better with previous code
2024-03-09 22:43:53 +01:00
Jon Bendtsen
95d644615c
remove trailing whitespace
2024-03-09 22:14:02 +01:00
Jon Bendtsen
0c91e3fe06
attempt at fixing #28645
2024-03-09 22:01:30 +01:00
MDW
bb144ed278
Fix: Ensure string type for urlencode()
2024-03-09 16:53:30 +01:00
MDW
a7895ec1a6
Fix: Ensure string type for urlencode()
2024-03-09 16:53:28 +01:00
MDW
6ebe9fed3c
Fix: Ensure string type for urlencode()
2024-03-09 16:53:27 +01:00
MDW
80c239b010
Fix: Ensure string type for urlencode()
2024-03-09 16:53:25 +01:00
MDW
263f6a1d15
Fix: Ensure string type for urlencode()
2024-03-09 16:53:24 +01:00
MDW
08eb3a8e1f
Fix: Ensure string type for urlencode()
2024-03-09 16:53:23 +01:00
MDW
0b19aa415c
Fix: Initialise array before assigning values ( #28728 )
...
* Qual: Enable PhanUndeclaredVariableDim
# Qual: Enable PhanUndeclaredVariableDim
The notifications are fixed in the code so the detection no longer
needs to be suppressed in the default flow
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Qual: Add type hint to array to avoid phan notification
* Qual: Add type hint to array to avoid phan notification
* Qual: Enable PhanParamSpecial1 (all resolved)
* Qual: Ignore false PhanTypeArraySuspiciousNullable
* Qual: Improve typing to fix PhanTypeArraySuspicious
* Qual: Fix PhanTypeArraySuspicious by replacing null assignment with empty array
* Qual: Fix PhanTypeArraySuspicious by testing as instancof DebugBar
* Qual: Fix PhanTypeComparisonToArray with enhanced typing
* Qual: Fix PhanTypeComparisonToArray with enhanced typing
* Qual: Enable phan messages that no longer appear
* Qual: Exclude phan stubs from codesniffer ruleset
2024-03-09 16:32:02 +01:00
MDW
d116934301
Fix: Initialise array variables before assigning fields ( #28725 )
...
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
2024-03-09 02:43:57 +01:00
MDW
6d857757e9
Qual: Improve typing hint for (ext)Object, and allow null ( #28719 )
...
* Qual: Improve typing hint for (ext)Object, and allow null
# Qual: Improve typing hint for object, and allow null
As the key "->element" is expected, the object type should be derived from CommonObject.
Also extObject can be nullable
* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()
* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()
* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()
* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()
* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()
* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()
* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()
2024-03-09 01:12:03 +01:00