2
0
forked from Wavyzz/dolibarr
Commit Graph

799 Commits

Author SHA1 Message Date
Laurent Destailleur
fd9475be03 Use same doc comment eveywhere. 2024-04-07 12:26:27 +02:00
Frédéric FRANCE
7cf6a0821f fix phpdoc for ismultientitymanaged (#29245)
* fix phpdoc

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-06 17:38:39 +02:00
Laurent Destailleur
38fb00489d PHPDoc 2024-04-05 13:44:59 +02:00
Laurent Destailleur
d4268de403 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-04-04 16:52:38 +02:00
Laurent Destailleur
60bc60db48 FIX #29225 2024-04-04 16:48:27 +02:00
Laurent Destailleur
fffe74246c Fix all short tables must use the setup for the number of rows 2024-04-03 15:30:10 +02:00
Laurent Destailleur
e3037794aa Look and feel v20 2024-04-01 15:04:20 +02:00
MDW
5ca5d67939 Improve phpdoc typing 2024-03-31 01:03:33 +01:00
Frédéric France
7a7b1953ed fix phpstan 2024-03-28 20:34:33 +01:00
Hystepik
48a8ce6612 Fix fatal error on skill_card 2024-03-27 12:55:06 +01:00
Laurent Destailleur
7a1e0fb808 Merge pull request #29058 from mc2rcanarslan/patch-18
FIX: use hasRight function
2024-03-25 21:38:00 +01:00
Can Arslan
e1787360d5 FIX: hasRight function
Also fixes;

PHP Warning:  Undefined property: stdClass::$write in /htdocs/hrm/job_list.php on line 137

PHP Warning:  Undefined property: stdClass::$delete in /htdocs/hrm/job_list.php on line 138
2024-03-25 13:06:18 -06:00
Can Arslan
0ed297d8ca FIX: used hasRight function
Also fixes;
PHP Warning:  Undefined property: stdClass::$write in /htdocs/hrm/position_list.php on line 138
PHP Warning:  Undefined property: stdClass::$delete in /htdocs/hrm/position_list.php on line 139
2024-03-25 13:03:28 -06:00
Laurent Destailleur
7b0177a84d Move to getDolGlobalString 2024-03-22 00:37:56 +01:00
MDW
519da00897 Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:35 +01:00
MDW
ee5d837fcc Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:33 +01:00
MDW
b3cda67e36 Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:32 +01:00
MDW
579f2dee4c Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:30 +01:00
MDW
f28af956f9 Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:29 +01:00
MDW
169d1a2ff8 Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:28 +01:00
MDW
0df51158dd Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:26 +01:00
Laurent Destailleur
6b1f490ee1 Merge branch 'develop' into phpstanphpstan 2024-03-19 02:05:42 +01:00
MDW
fd9d48faac Fix phpstan CommonObject->fields - notnull is optional field 2024-03-19 00:32:00 +01:00
Frédéric France
a8627c9315 fix phpstan 2024-03-17 22:06:53 +01:00
Frédéric France
09a953d18f fix phpstan 2024-03-17 22:04:10 +01:00
Laurent Destailleur
de58435ef1 FIX: if we stop for security purpose, we must exit a non zero value. 2024-03-16 23:08:15 +01:00
MDW
8c29ca9033 Fix PhanNoopVariable for $i by changing loop to while
# Fix PhanNoopVariable for $i by changing loop to while

`$i` looked like a NOOP on $i which is provided as an argument to
the function.  Changed to while to improve readability and avoid thinking
that `$i` needs initialisation and fix the notification
2024-03-16 00:00:26 +01:00
MDW
23785393a3 Add csslist to json keys 2024-03-15 03:55:52 +01:00
MDW
43f5e96235 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:50:37 +01:00
MDW
050c7fecd0 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:50:36 +01:00
MDW
2bab0f44a9 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:50:35 +01:00
MDW
3200b68ed9 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:48:21 +01:00
MDW
67fc86b051 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:48:20 +01:00
MDW
c3d36b8a24 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:48:19 +01:00
MDW
10f94b59e3 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:48:18 +01:00
Laurent Destailleur
1639bc83ca Merge pull request #28817 from frederic34/skiljob
fix warnings
2024-03-15 00:18:44 +01:00
Lamrani Abdel
560d5618d2 FIX type in doc for variable childtables 2024-03-14 15:31:11 +01:00
Frédéric France
345edd56fb clean code 2024-03-13 21:07:56 +01:00
Frédéric France
7b4c0536c7 fix warnings 2024-03-13 18:11:40 +01:00
MDW
b02014bf47 Fix PhanPluginUnknownFunctionParamType
# Fix PhanPluginUnknownFunctionParamType

PHPdoc for $object was incorrect.
Reviewed some of the other typings as well
2024-03-13 10:51:45 +01:00
Laurent Destailleur
74b8162d22 Merge pull request #28700 from mdeweerd/urlencode/fixuptype
Fix: Ensure the argument type for urlencode is string
2024-03-12 14:43:41 +01:00
Laurent Destailleur
9e16016125 Merge pull request #28770 from mdeweerd/typing/fields
Fix: Repeat fields typing in CommonClass children
2024-03-12 14:30:36 +01:00
MDW
88d59896ec Qual: 'enabled' in fields can be string ('isModEnabled(...)')
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')

Update PHPdoc to allow that enabled is a string
2024-03-12 13:38:08 +01:00
MDW
6d92b164f0 Qual: set default value to match PHPdoc type 2024-03-11 23:46:49 +01:00
MDW
54b2305e74 Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:48 +01:00
MDW
3865c09954 Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:46 +01:00
MDW
4c56911ee8 Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:44 +01:00
MDW
7fb5c23758 Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:42 +01:00
MDW
71fa5af141 Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:40 +01:00
MDW
a2a2b3fa0e Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:38 +01:00