2
0
forked from Wavyzz/dolibarr
Commit Graph

3710 Commits

Author SHA1 Message Date
Laurent Destailleur
7f780fcb57 It seems constant are for storing data only and used for
DolibarrModules.class.php file only (main code shoud only use
->hasRight), so i try to move them.
2024-04-08 11:53:49 +02:00
Regis Houssin
68eb5e409a NEW module user rights enhancement (#29150)
* NEW module user rights enhancement

* FIX syntax error

* FIX fuck

* FIX syntax error

* FIX Add label with the current language (key or with PermissionXXX)

* FIX wrong test

* FIX optimize

* FIX doc

* FIX add class "Rights" for constant

* FIX replace with constants

* FIX missing constant

* FIX wrong check

* TODO sql error : data too long for column 'libelle'

* FIX syntax error

* FIX synax error "the return"... i'll be back

* FIX use operator with double question mark

* FIX add comment

* FIX just remplace integer with constant

* FIX remove unused code

* FIX add an example

* FIX remove the possibility to have entity = 0 (too complicated)

* FIX perms must not be empty

* FIX sql syntax error

* FIX phpstan undefined property DolibarrModules::$modules

* FIX same fix of frederic34

* Update llx_rights_def.sql

* Update DolibarrModules.class.php

* Update DolibarrModules.class.php

* Update DolibarrModules.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-08 11:40:02 +02:00
Laurent Destailleur
b5de782c6b Fix use the good HTTP code 2024-04-07 14:59:25 +02:00
Laurent Destailleur
fd9475be03 Use same doc comment eveywhere. 2024-04-07 12:26:27 +02:00
Laurent Destailleur
38fb00489d PHPDoc 2024-04-05 13:44:59 +02:00
Laurent Destailleur
3ee5b8133d css 2024-04-05 13:28:32 +02:00
Laurent Destailleur
af41ec8e41 Clean code - Remove not used method fetchAll and CSS 2024-04-02 16:42:21 +02:00
Laurent Destailleur
7715513ac9 Some API HTTP return code were moved from 401 to 403 to better follow
REST specification.
2024-04-02 14:47:49 +02:00
Laurent Destailleur
990216b13f NEW Api parameters are sanitized by the WAF, same code than GET/POST 2024-04-02 13:07:13 +02:00
Laurent Destailleur
8ed9866433 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-31 19:26:54 +02:00
Laurent Destailleur
6b49f3302b Merge pull request #29154 from hregis/fix_19_array_error_php8.2
FIX empty array with php8.2
2024-03-31 19:11:50 +02:00
Regis Houssin
e00e35a2df FIX empty array with php8.2 2024-03-31 18:28:57 +02:00
MDW
04c3e80fc5 Fix typing 2024-03-29 18:26:48 +01:00
Lenin Rivas
fa65546800 Enable user establishment 2024-03-29 08:04:02 -05:00
Frédéric France
7a7b1953ed fix phpstan 2024-03-28 20:34:33 +01:00
Frédéric France
b8d75178b1 fix phpstan 2024-03-28 18:45:28 +01:00
Laurent Destailleur
787b1a1c83 Merge branch 'develop' into fix/filebyfile 2024-03-28 14:23:54 +01:00
Laurent Destailleur
54501bccc3 Merge pull request #29066 from mdeweerd/fix/dol_get_fiche_head
Fix arguments to dol_get_fiche_head and dol_get_fiche_end
2024-03-28 14:16:45 +01:00
MDW
ebefa90b25 Fix arguments to dol_get_fiche_head 2024-03-27 10:23:09 +01:00
MDW
66ce94bafb Fix arguments to dol_get_fiche_head 2024-03-27 10:23:08 +01:00
MDW
ebb4c2111a Improve gender, admin, entity typing 2024-03-27 10:18:47 +01:00
MDW
d60a630d35 Fix: note<->note_private aliasing is handled by DeprecationHandler
# Fix: note<->note_private aliasing is handled by DeprecationHandler

The extra copy is useless, the aliasing for the deprecated property is already handled
2024-03-24 17:39:06 +01:00
MDW
bbc086ce26 Force type to fix PhanNonClassMethodCall 2024-03-24 15:40:29 +01:00
MDW
1986888333 Update PHPdoc for User::$users 2024-03-24 15:40:26 +01:00
Laurent Destailleur
73fea610d1 Fix regression 2024-03-23 17:27:40 +01:00
Laurent Destailleur
0ce6e016b4 Update bank.php 2024-03-23 16:29:23 +01:00
Jon Bendtsen
dc3a46c88d bug fix that allowed to view /user/bank.php?id= for any other user id (salaries read -> readall. + allowing user to edit their own bank account as well as personal email and phone. + allowing user to change their own bank account and allow useradmin to add a bank account for a user 2024-03-23 11:18:04 +01:00
Jon Bendtsen
e739c0d092 too many ) 2024-03-22 23:18:19 +01:00
Jon Bendtsen
8f4d7d6336 updating to new user->hasRight method 2024-03-22 23:16:11 +01:00
Jon Bendtsen
4489187edd create and edit actions uses permissiontoaddbankaccount variable 2024-03-22 23:13:12 +01:00
Jon Bendtsen
c22dce308b allow user to self edit their bank account details + allowing a user administrator edit bank account details 2024-03-22 22:41:00 +01:00
Laurent Destailleur
7b0177a84d Move to getDolGlobalString 2024-03-22 00:37:56 +01:00
MDW
aeefca7e7e Fix $arrayfields typing lost by dol_sort_array() by forcing the type 2024-03-20 23:29:48 +01:00
Laurent Destailleur
440c7b4493 FIX #28978 FIX #28976 2024-03-20 21:28:35 +01:00
Laurent Destailleur
e16d1d5de9 FIX #28978 FIX #28976 2024-03-20 21:27:28 +01:00
MDW
1824950c40 Force value to string because Phan can't determine the proper type 2024-03-20 04:10:03 +01:00
MDW
a094ad38fc Fix spelling (using beta codespell)
# Fix spelling (using beta codespell

New spelling fixes - ignoring thirdparty which should be either third-party
or third party.
2024-03-20 00:35:01 +01:00
Laurent Destailleur
5d073ac208 Fix hasRights into hasRight 2024-03-19 22:02:42 +01:00
Laurent Destailleur
363a083c54 Look and feel v20 2024-03-19 15:34:47 +01:00
MDW
f892b3a27c Fix configuration 2024-03-19 00:32:09 +01:00
Laurent Destailleur
e994d6650f Fix regression in GETPOST limit 2024-03-16 11:41:00 +01:00
Laurent Destailleur
57d826e261 Merge pull request #28889 from mdeweerd/fix/PhanTypeMismatchArgumentInternalReal
Fix & enable PhanTypeMismatchArgumentInternalReal
2024-03-16 11:05:20 +01:00
MDW
b494c1a57c Qual add typing for $users property 2024-03-15 23:41:28 +01:00
Laurent Destailleur
79aa9fb1f1 Code simpler 2024-03-15 20:29:21 +01:00
Laurent Destailleur
f1a8d712fb Merge branch 'develop' into fix-warnings-and-trad-not-showing 2024-03-15 00:23:54 +01:00
Frédéric France
93d2cad7fe fix warnings 2024-03-13 21:33:51 +01:00
Laurent Destailleur
b8fd539a89 Merge pull request #28811 from W1W1-M/qual-ldap
Qual ldap.php
2024-03-13 18:25:31 +01:00
Laurent Destailleur
439654a634 Fix ternary of ternary too difficult to read 2024-03-13 18:24:35 +01:00
Laurent Destailleur
9918f99c6d Merge pull request #28815 from W1W1-M/qual-user-agenda
FIX user agenda
2024-03-13 18:12:33 +01:00
Laurent Destailleur
e01d9452d5 Update agenda.php 2024-03-13 18:12:00 +01:00