2
0
forked from Wavyzz/dolibarr
Commit Graph

112 Commits

Author SHA1 Message Date
Eric - CAP-REL
be1948e1eb better fields definition with full objects reference (#33798) 2025-04-09 16:36:42 +02:00
Laurent Destailleur (aka Eldy)
9cafa5f1a9 Fix phan 2025-02-05 00:32:27 +01:00
Laurent Destailleur (aka Eldy)
72ea4fadb3 Debug v21 2025-02-04 13:22:04 +01:00
Frédéric FRANCE
4e9faa16be Update societeaccount.class.php 2025-01-24 14:14:10 +01:00
Laurent Destailleur (aka Eldy)
48190b39de Debug v21 2025-01-23 23:26:59 +01:00
MDW
89f040c69e Qual: Fix ci, PHPdoc fk_website needs to match default value
# Qual: Fix ci, PHPdoc fk_website needs to match default value

Correct doctype for new $fk_website in getCustomerAccount.
Also made definition of type for $status more strict.
2025-01-18 14:28:35 +01:00
Laurent Destailleur (aka Eldy)
4bf6511811 Debug v21 - getCustomerAccount return duplicates. Misssing a key. 2025-01-16 22:03:51 +01:00
Laurent Destailleur (aka Eldy)
b024b95948 Fix typo 2025-01-09 19:35:01 +01:00
Laurent Destailleur (aka Eldy)
56710ce9b7 FIX CVE-2024-55227 and CVE-2024-55228 CSRF when
MAIN_RESTRICTHTML_ONLY_VALID_HTML_TIDY is
on (hidden option not on by default)
2025-01-09 19:35:01 +01:00
Laurent Destailleur
3b605c2184 Debug v21 2025-01-07 10:43:45 +01:00
MDW
ec2a1928ba Qual: Update fields phpdoc to include fields that are defined/used in some cases
# Qual: Update fields phpdoc to include fields that are defined/used in some cases

comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
2024-12-05 02:36:50 +01:00
Laurent Destailleur
63ac936652 Fix add an order to have same behavior in using stripe customer account
event if data are corrupted with duplicate record.
2024-11-25 14:46:22 +01:00
MDW
278d301f32 Qual: Fix phan/phpstan notices in class files (part 6) (#31634)
* Qual: Fix notices for paymentdonation...workstationusergroup.class

* Qual: Fix PhanPluginRedundantReturnComment, update baseline

* Qual: Complete array phpdoc for properties
2024-11-06 23:57:45 +01:00
MDW
5e02bec9df Qual: Fix getTooltipContentArray typing hints (#31081)
* Qual: Fix getTooltipContentArray typing hints

# Qual: Fix getTooltipContentArray typing hints

This defines the aray type for all getTooltipContentArray occurences

* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
MDW
ca414de526 Qual: Fix $fields related notices with Phan (#30704)
* Qual: Typing hints/ignore directives for phan notices

* Update field typing
2024-08-21 13:23:35 +02:00
MDW
54880f92cd Qual: Fix PhanTypeMismatchProperty and some other phan notices (#30542)
* Qual: Fix PhanTypeMismatchProperty and some other phan notices

* Qual: Phan fixes for BOM

* Phan - fix fields

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Fix $fields phpdoc

* Fix phan typing issues with intermediate var and ??

* Fix phan typing issue with ?? operator

* Ignore htdocs/install/install.forced.php for git

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Update baseline

* Qual: Phan fixes for BOM

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration

* Fix typing hints (phpstan)

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-15 17:05:00 +02:00
Laurent Destailleur
b3b21d56b6 Fix doxygen 2024-08-07 02:49:38 +02:00
Mohamed DAOUD
4dca8eb7bf add column to societe account table (#30442)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-07-25 18:23:31 +02:00
Frédéric FRANCE
4b275dc148 add phpdoc (#30208)
* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* clean phpdoc
2024-06-30 19:39:01 +02:00
Laurent Destailleur
dc024a1f18 Debug v20 2024-05-30 14:43:16 +02:00
Laurent Destailleur
74c2d34e5d Debug v20 2024-05-30 13:59:16 +02:00
Frédéric FRANCE
d0830b3159 fix phpstan (#29602)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

fix phpstan

fix phpstan

fix phpstan

fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-05 00:34:19 +02:00
Laurent Destailleur
642a3d5984 Fix regression 2024-05-03 01:28:19 +02:00
Laurent Destailleur
dc28879ffb Fix warning 2024-05-01 18:34:38 +02:00
Laurent Destailleur
fd9475be03 Use same doc comment eveywhere. 2024-04-07 12:26:27 +02:00
Frédéric FRANCE
7cf6a0821f fix phpdoc for ismultientitymanaged (#29245)
* fix phpdoc

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-06 17:38:39 +02:00
MDW
79a0b7d234 Fix array_key_exists in websiteaccount_card by adding key to initializer 2024-03-19 02:58:56 +01:00
MDW
fd9d48faac Fix phpstan CommonObject->fields - notnull is optional field 2024-03-19 00:32:00 +01:00
MDW
23785393a3 Add csslist to json keys 2024-03-15 03:55:52 +01:00
MDW
88d59896ec Qual: 'enabled' in fields can be string ('isModEnabled(...)')
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')

Update PHPdoc to allow that enabled is a string
2024-03-12 13:38:08 +01:00
MDW
bb64871b35 Qual: Precise typing for Societeaccount's fields property (#28758)
# Qual: Precise typing for Societeaccount's fields property

Better typing helps static analysis and fixes the message:
PhanTypeMismatchArgumentInternal Argument 2 ($array) is $object->fields['site']['arrayofkeyval'] of type null but \array_key_exists() takes array
2024-03-11 15:23:43 +01:00
Frédéric FRANCE
fba15178eb all initAsSpecimen return int (#28577)
* all initAsSpecimen return int

* all initAsSpecimen return int

* all initAsSpecimen return int
2024-03-02 16:38:35 +01:00
Frédéric FRANCE
5f1c679142 fix warning (#28177)
* fix warning

* clean properties

* clean properties
2024-02-15 13:59:19 +01:00
Laurent Destailleur
079b2aa3a0 Debug webportal 2024-01-27 17:58:19 +01:00
Laurent Destailleur
25a91c63cf Debug webportal module 2024-01-27 17:23:03 +01:00
William Mead
46fc369f38 Fixed PHPDoc 2024-01-24 16:35:56 +01:00
MDW
39769482b1 Qual: Fix typing hints for DoliDB (#27484)
# Qual: Fix typing hints for DoliDB

This should help the static tools for type and method checking.
2024-01-13 15:50:02 +01:00
Laurent Destailleur
f201692001 Fix phpstan 2024-01-12 19:50:22 +01:00
Laurent Destailleur
c406d9a002 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-12 17:49:00 +01:00
Laurent Destailleur
618a364064 FIX #27439 but using the opposite direction. int is bette as we can evolve to add a third value in a future. 2024-01-12 17:47:54 +01:00
MDW
342ab85195 Qual: Spelling htdocs/[q-z]* (#27447)
# Qual: Fix spelling htdocs/[q-z]*

Probably fixes a bug:

- htdocs/webservices/server_thirdparty.php
  No other occurence of adress found.
  -'adress'=>->adress,- +'address'=>->address,+
2024-01-12 17:18:52 +01:00
Laurent Destailleur
e040219fdc Fix phpcs 2023-12-13 12:45:07 +01:00
Frédéric FRANCE
53c8a3acf8 clean phpdoc for phpstan (#26905) 2023-12-01 19:51:32 +01:00
Laurent Destailleur
075ee02901 Fix php8.2 warnings 2023-11-27 12:08:48 +01:00
Laurent Destailleur
07a3774749 Debug v19 2023-11-17 23:44:02 +01:00
Laurent Destailleur
6ca0154784 Fix management of password type with pass_crypted 2023-11-17 22:09:35 +01:00
Laurent Destailleur
a318031034 QUAL Standardize code. Renamed ID of user properties into ->user_xxx_id 2023-10-24 11:37:29 +02:00
Laurent Destailleur
3ce02f1181 Debug v19 2023-10-18 18:37:00 +02:00
VESSILLER
30f907cf17 Update from develop 2023-09-12 14:25:04 +02:00
Laurent Destailleur
91fa48199a Fix warnings 2023-09-10 17:41:22 +02:00