2
0
forked from Wavyzz/dolibarr
Commit Graph

13327 Commits

Author SHA1 Message Date
MDW
a1f332586c Fix PhanPluginRedundantAssignment 2024-03-13 00:40:50 +01:00
MDW
60359aa418 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:49 +01:00
MDW
c3647c3af6 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:48 +01:00
MDW
6d6cbff08e Fix PhanPluginRedundantAssignment 2024-03-13 00:40:47 +01:00
MDW
271525deaa Fix PhanPluginRedundantAssignment 2024-03-13 00:40:46 +01:00
MDW
0302e4f2b5 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:45 +01:00
MDW
81fde8ffc3 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:44 +01:00
MDW
5668974d46 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:44 +01:00
MDW
c76c08e9f0 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:43 +01:00
MDW
509357d632 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:42 +01:00
MDW
d33e0a69ca Fix PhanPluginRedundantAssignment 2024-03-13 00:40:41 +01:00
Laurent Destailleur
d51b0f9ae4 Merge pull request #28792 from mdeweerd/fix/PhanTypeExpectedObjectOrClassName_part1
Fix/phan type expected object or class name part1
2024-03-12 22:14:14 +01:00
MDW
4bc9f52957 Fix PhanPluginMixedKeyNoKey - real missing key/value mapping 2024-03-12 21:35:42 +01:00
Laurent Destailleur
0968183f6a Merge pull request #28794 from mdeweerd/fix/PhanPluginDuplicateIfCondition
Fix: fix/PhanPluginDuplicateIfCondition
2024-03-12 21:24:06 +01:00
Laurent Destailleur
03798025b9 FIX #28787 2024-03-12 20:44:02 +01:00
MDW
7e52b2f632 Fix duplicate if condition with same effect 2024-03-12 19:13:40 +01:00
MDW
bba0d4661e Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
# Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname

PhanTypeExpectedObjectOrClassName should be fixed by testing that the classname is not
empty.
2024-03-12 18:40:03 +01:00
Laurent Destailleur
16edaf9208 Merge pull request #28783 from lamrani002/cMailFileSendmail
fix method sendfile return type
2024-03-12 16:19:36 +01:00
Laurent Destailleur
cf28211a78 Update CMailFile.class.php 2024-03-12 16:18:44 +01:00
Lamrani Abdel
8bf54dee9e fix method sendfile return type 2024-03-12 15:13:54 +01:00
Laurent Destailleur
a6926c29c0 Merge pull request #28778 from fappels/develop_fix_delivery_note
Fix shipping is not a delivery_note (is sub module of shipping)
2024-03-12 14:53:51 +01:00
Laurent Destailleur
74b8162d22 Merge pull request #28700 from mdeweerd/urlencode/fixuptype
Fix: Ensure the argument type for urlencode is string
2024-03-12 14:43:41 +01:00
Laurent Destailleur
9e16016125 Merge pull request #28770 from mdeweerd/typing/fields
Fix: Repeat fields typing in CommonClass children
2024-03-12 14:30:36 +01:00
Francis Appels
6f1b184f17 Merge remote-tracking branch 'Dolibarr/develop' into develop_fix_delivery_note 2024-03-12 14:13:41 +01:00
Laurent Destailleur
949c885477 Merge branch 'develop' into fix/phpdoc1 2024-03-12 14:11:30 +01:00
Laurent Destailleur
0b936bebe7 Merge pull request #28773 from frederic34/clean_mod_code
clean code and phpdoc
2024-03-12 14:09:23 +01:00
MDW
88d59896ec Qual: 'enabled' in fields can be string ('isModEnabled(...)')
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')

Update PHPdoc to allow that enabled is a string
2024-03-12 13:38:08 +01:00
Francis Appels
ba1ca6dc7d module delivery_note not exist (no own module descriptor) is global MAIN_SUBMODULE_DELIVERY 2024-03-12 11:46:12 +01:00
Francis Appels
7ff68a5819 Fix shipping is not a delivery_note (sub module of shipping) 2024-03-12 11:07:18 +01:00
Laurent Destailleur
7869c1a309 AI support both plain text and HTML generation 2024-03-12 10:01:39 +01:00
Frédéric FRANCE
de4c564c7e clean 2024-03-12 09:56:36 +01:00
Frédéric FRANCE
d7517b5f20 Merge remote-tracking branch 'upstream/develop' into clean_mod_code 2024-03-12 09:25:53 +01:00
Laurent Destailleur
56950673b8 Better support for MAIN_OPTIMIZEFORTEXTBROWSER 2024-03-12 02:41:47 +01:00
Laurent Destailleur
4f64c683ee Better support for MAIN_OPTIMIZEFORTEXTBROWSER 2024-03-12 01:55:26 +01:00
MDW
b79328f4e6 Qual: Fix PHPdoc to match parent 2024-03-11 23:46:46 +01:00
MDW
44376cd066 More specific type for childtablesoncascade 2024-03-11 22:16:27 +01:00
MDW
cb35dabd8f Qual: Document sendMail according to code 2024-03-11 21:39:04 +01:00
Frédéric France
aaf173a0d2 clean code and phpdoc 2024-03-11 21:01:20 +01:00
MDW
dcf25336ba Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:17 +01:00
MDW
1035e92861 Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:15 +01:00
MDW
3730dbc31b Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:13 +01:00
Laurent Destailleur
769b682fd3 Update commonobject.class.php 2024-03-11 16:13:11 +01:00
Laurent Destailleur
1178b858d8 Merge branch 'develop' into fix/getChildrenOfLine/array_merge 2024-03-11 15:22:44 +01:00
Laurent Destailleur
be403024ed Try a fix for #28734 2024-03-11 14:40:36 +01:00
MDW
b72cf193c4 Fix some cases of PhanTypeSuspiciousStringExpression (#28751)
* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-11 14:01:28 +01:00
Laurent Destailleur
0f2121e3ba Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-11 13:46:08 +01:00
MDW
c333075776 Fix: getChildrenOfLine's use of includealltree as array
# Fix: getChildrenOfLine's use of includealltree as array

includealltree of getChildrenOfLine was used as an array, fixed
2024-03-11 13:41:02 +01:00
MDW
dbfb1180ee Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions (#28749)
# Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions

Fix occurences of PhanPluginDuplicateIfStatements which are if statements where the
consecutive branches execute the same code, making it useles to test the condition
2024-03-11 12:58:51 +01:00
MDW
8602ca9885 Fix: implode->join and duplicated if condition (#28761)
* Fix: join->implode

# Fix: join->implode

Update new cases of join

* Fix: Duplicate if condition in if/else sequence

# Fix: Duplicate if condition in if/else sequence

Fixed repeated if condition and action
2024-03-11 12:55:55 +01:00
Laurent Destailleur
f32bf4b3a7 Fix join -> implode 2024-03-11 12:38:21 +01:00