* Qual: Refactor for distinction between encodings
# Qual: Refactor for distinction between encodings
Renamed path/file variable to equivalents with prefix os_ and utf8.
Also added $utf8_fullpath to optimize.
* Fix: Fix mixed os_path/utf8_path
# Fix: Fix mixed os_path/utf8_path
This fixes the mixing of a os_path encoding en utf8_path encoding
by reorganising the statement order.
Also avoid a os_encode call by reusing data already available.
* qual : phpstan for htdocs/core/class/dolgraph.class.php
htdocs/core/class/dolgraph.class.php 703 Method DolGraph::GetCeilMaxValue() should return int but returns float.
htdocs/core/class/dolgraph.class.php 1551 Method DolGraph::total() should return string but returns (float|int).
htdocs/core/class/dolgraph.class.php 1593 Method DolGraph::getDefaultGraphSizeForStats() should return int but returns string.
htdocs/core/class/dolgraph.class.php 1599 Method DolGraph::getDefaultGraphSizeForStats() should return int but returns string.
* phpcs
* Qual: Apply php-cs-fixer to make only manual changes stand-out
# Qual: Apply php-cs-fixer to make only manual changes stand-out
A few changes will be proposed in the future to these files. This already commits
the esthetic changes using php-cs-fixes.
* Qual: Apply php-cs-fixer to make only manual changes stand-out
# Qual: Apply php-cs-fixer to make only manual changes stand-out
A few changes will be proposed in the future to these files. This already commits
the esthetic changes using php-cs-fixes.
* Qual: Apply php-cs-fixer to make only manual changes stand-out
# Qual: Apply php-cs-fixer to make only manual changes stand-out
A few changes will be proposed in the future to these files. This already commits
the esthetic changes using php-cs-fixes.
* feat(api): Add updateLine to Bank api + add salaries api
* feat(api): Add "deleteLine" to bank api
* fix(api): Remove unneeded mandatory field "salary"
* feat(api): Add PaymentSalaries and PaymentExpenseReports API
* fix(bankaccount): Fix bad phpdoc return type
* fix(bankaccount): Fix bad phpdoc return type and comments
* add updateLabel function to AccountLine
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Qual: Remove useless ignore case on regex
# Qual: Remove useless ignore case on regex
The ignore case on this regex is useless and may have a performance impact.
* Qual: Fastest test first, and test object type
# Qual: Fastest test first, and test object type
The test on nohook should be fastest, and the instanceof test helps
static tool checkers and supposedly also helps performance
* add new hook context for mo production card
* remove consumed and produced line when we clone mo
* Fix multiplication error in actions_addupdatedelete.inc.php
* Fix: PhanParamSignatureMismatch
# Fix: PhanParamSignatureMismatch
PhanDoc was updated to require specific types which changes the method signature
versus the parent.
This results in a signature mismatch.
Updated to maintain the method signature but dynamically check that
the object type is correct.
* Update pre-commit for php-cs
# Qual: Add verification on filters (dol_dir_list)
As-is, '/' must be escaped in the regexes, this adds code to enforce
that requirement and avoid mistakes.
Even if the mathod using '{}' as delimiters is applied this check
could remain in place.
Also, returning empty array immediately - when the directory could
not be opened, closedir() can not be applied.
