Frédéric FRANCE
797bfb27e0
fix phpstan ( #30881 )
...
* fix phpstan
* fix phpstan
2024-09-09 02:28:35 +02:00
Frédéric FRANCE
eb04c5c427
fix phpstan ( #30860 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-06 13:44:29 +02:00
Laurent Destailleur
001dc9378f
Fix phan
2024-09-04 22:10:33 +02:00
MDW
d71cd352d5
Qual: Fix PhanUndeclaredMethod ( #30661 )
...
* Qual: Fix PhanUndeclaredMethod cases
* Fix PhanUndeclaredMethod cases
* Qual: Remove PhanUndeclaredMethod exceptions
* Fix spelling "disacard"
* Improve phpdoc, add abstract method to trait for typing
* Improve phpdoc typing for PHanUndeclaredMethod
* Suppress phan notices for guarded AliasNbPages calls
* Fix return value for printFile stub
* Fix getting message from Exception
* Define dummy getAllByProducts(), typing for it.
* Fix typo in comment
* Qual: Better typing for apiService (phan)
* Test that the Generic OAuth Service is provided
* Qual: Fix getSqlArrayForStats typing
* Force modTcpdfbarcode
* Correct typing hint
* Set ModelePDFAsset typehint
* Fix ModelePDFUserGroup typing hint
* Fix phan typing hints htdocs/core/modules/printing/printgcp.modules.php
* Fix write_file in ModelePDFStock*
* Update printsheet.php
* Adjust typing hint for barcode generator
* Update printsheet.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-19 02:05:27 +02:00
MDW
75ed925f06
Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") ( #30563 )
...
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint in phan config to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjects
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Fix: MemberNumRefNumbers getExample does not take any arguments
Found thanks to adding the typing for phan!
* Qual: Correct forced type for $module
* Qual: Ignore phan false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Ignore false positive
* Qual: phan/Ignore false positive, replace depr.prop with method
* Qual: Fix typing for count by adding is_array check
* Qual: replace depr.prop `nom` with method
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Fix depr.prop with getter and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: Improve typing for mymodule template
* Make info method arguments match calls
* Make PrintingDriver abstract class because we added abstract methods
* Add phpdoc typing for phan
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update header wit correct information
* Update getExample method signature
* Update getExample method signature
* Correct reference to class in comment
* Force php phan typing for numbering modules
* Correct $_GLOBALS to $GLOBALS
* Add phpdoc to indicat type of properties
* Correct default to null
* Improve getNextValue typehint
* Improve getNextValue typehint
* Qual: Improve ModeleNumRefTakepos typing
* Qual: Improve ModeleNumRefRecruitmentJobPosition typing
* Fix default for $langs
* Do not use non-existing ModeleNumRefTakepos::nom
* Allow getNextValue argument to be null
* Correct $_GLOBAL into $GLOBALS
* Improve typing for ldap functions
* Allow null for outputlangs argument
* Improve typing for printOriginLine
* Improve typing for linkedObject access
* Fix PhanTypeMismatchArgumentNullableInternal and optimize
* Fix PhanPossiblyUndeclaredVariable by setting default value
* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4
* getToolTip does not accept null, changed to ''
* Improve getNextValue typing
* Change PrintingDriver back to normal class (instantiated)
And add errors for functions that should be overloaded
* Adjust pringOriginLine typing to match parent
* Fix phpdoc for getNextValue
* Fix phan typing
* Add/Improve phpdoc typing hints
* Qual: Adjustments to match typing
* Update typing for unit, use GETPOSTINT
* ModeleNumRefTask needs Project
* Fix several notices appearing after update from develop
* Index for choices is int, use GETPOSTINT
* Qual: Ignore empty foreach
* Force BOMLine on object line
* phan typing to indicate that linked objects are BOM
* Type the correct variable name (phan)
* Add typing for $langs
* Type to CommonNumRefGenerator (no class for availabilities)
* Resolve several phan notices after update from dev branch
* Extra typing fixes
* Move common attributes to parent class (phan)
* Add typing to Calendar class
* Improve typing hints
* Add typing to pdf_eagle_proforma
* Qual: Add typing for token in generic_oauthcallback.php
* Add typing for objMod
* Correct getNextValue function signature (phpstan)
* Fix typing (phpstan)
* Update version declarations (fix phpstan)
* Fix phpstan typing issues
* Adjust typing (phpstan)
* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
Laurent Destailleur
3b147a2776
Fix typo
2024-08-17 17:00:36 +02:00
MDW
3d04a7195c
Qual: Updates regarding write_file(s) methods for Phan ( #30511 )
...
* Fix phpdoc for phpstan
* Add abstract write_file to ModelePDFContract
And update phpdoc for derived classes
* Fix typing for php_standard_actions writefile
* Improve phpdoc for write_files (& related)
* Add abstract write_file to ModelePDFBom
* Add abstract write_file to ModelePDFDeliveryOrder
* Add abstract write_file to ModeleExpenseReport
* Add abstract write_file to ModelePDFFicheinter
* Add abstract write_file to ModelePDFEvaluation
* Add abstract write_file to ModelePDFFactures
* Add abstract write_file to ModelePDFSuppliersInvoices
* Update ModelePDFProjects and ModelePDFTask related classes
* Qual: Add abstract write_file to ModelePdfExpedition
And update phpdoc for derived classes
* Qual: Correct reference (doc) to ModelePDFEvaluation
* Qual: Add abstract write_file to ModelePDFKnowledgeRecord
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFMo & ModelePDFMouvement
And update phpdoc for derived classes
* Qual: Set typehint to ModelePDFFicheinter
* Qual: Add abstract write_file to ModelePDFCommandes
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFPropales
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePdfReception
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFSuppliersOrders
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFSuppliersOrders
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFSuppliersPayments
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFSupplierProposal
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFWorkstation
And update phpdoc for derived classes
* Set typing for doc generator (commonobject)
* Improve typing for write_file
* Set typing for doc generator
* Qual: Add abstract write_file to ModelePDFMember
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFProduct
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFProductBatch
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFRecruitmentJobPosition
And update phpdoc for derived classes
* Add abstract write_file to ModelePDFTicket
* Add abstract write_file to ModelePDFUser
* Add abstract write_file to ModelePDFUserGroup
* Add abstract write_file to ModeleThirdPartyDoc
* Add abstract write_file to ModelePDFAsset
* Find all incompatible classes
* Qual: update phan baseline
* Set typing for doc generator (commonobject)
* Qual: update phan baseline
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-14 19:21:10 +02:00
MDW
e570f59e2d
Qual: Phan fixes (mainly Initial type cannot be inferred) in popular changed classes ( #30604 )
...
* Update setValueFrom $id type to include null
* Only 2 arguments for ModeleNumRefMembers::getToolTip
* Fix PhanTypeConversionFromArray
* Only 6 args for PaymentSalary::addPaymentToBank
* Fix typing hints (array -> string)
* Fix uninitialized variables
* Add cssview to attributes phpdoc
* Avoid double typing specification (Phan notice)
* Qual: Ensure variable is defined (phan)
* Ensure phpdoc typing for verif method
* Ensure phpdoc typing for getNextValue method
* Add status as data key in cols array
* Ensure preg_replace operates on string (phan)
* Correct type for desiredstock
* Fix typing with casts (phan)
* Fix check that notification already exists
* Initialise fk_parent_id to fix typing issue
* Qual: Fix phan notices for Societe & related
* Qual: Fix typing for Facture and related
* Qual: Fix typing for Product & related
* Update baseline
* Fix new phpstan notices
2024-08-14 01:24:55 +02:00
MDW
8b71242997
Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests ( #30544 )
...
* Remove PhanPluginDuplicateExpressionAssignmentOperation from baseline
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* fixup! Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-07 02:53:45 +02:00
Laurent Destailleur
871e01d955
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-31 14:32:55 +02:00
Laurent Destailleur
09eaf38bd1
Fix phpstan
2024-07-31 14:31:29 +02:00
Laurent Destailleur
d2bd6a03ec
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-31 13:21:02 +02:00
Laurent Destailleur
2f7a252244
Fix warnings
2024-07-31 13:09:10 +02:00
Laurent Destailleur
038ce032e0
Fix tooltip on numbering modules
2024-07-31 12:40:24 +02:00
Laurent Destailleur
a701f84543
Fix tooltip on numbering modules
2024-07-31 12:14:39 +02:00
Laurent Destailleur
c9b92bb32d
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-25 18:21:47 +02:00
Laurent Destailleur
6b076821e3
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2024-07-25 18:20:01 +02:00
Laurent Destailleur
f4611fcec9
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-07-25 18:06:37 +02:00
Thibault Fiacre
7c9e6b1fb9
FIX lang output for sales representative on PDF ( #30469 )
2024-07-25 17:56:13 +02:00
Frédéric FRANCE
2707475a12
fix phpstan ( #30319 )
...
* fix phpstan
* fix phpstan expects int, false given ...
* fix phpstan expects int, true given ...
2024-07-08 21:45:35 +02:00
Frédéric FRANCE
ea416aac93
replace old syntax, rename pdf models with same class name ( #30271 )
...
* replace old syntax
* replace old syntax
* replace old syntax
* replace old syntax
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* fix class with same name
* fix class with same name
* clean code
2024-07-06 02:59:40 +02:00
Frédéric FRANCE
29f223fd3c
fix checkFunctionArgumentTypes ( #30249 )
...
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
2024-07-04 17:47:31 +02:00
Laurent Destailleur
9af159cdd8
Replace "! empty($conf->global->$" with "getDolGlobalString($"
2024-07-03 20:05:29 +02:00
Frédéric FRANCE
74806473ab
fix cti ( #29842 )
...
* fix cti odt asset
* comment unused code in template
* phpdoc
* fix unreachable code
* fix unreachable code
* fix not falsy
2024-06-05 14:55:07 +02:00
Frédéric FRANCE
652c8526fa
fix cti ( #29813 )
...
* fix cti
* fix cti
* no photo in asset lines
* no photo in asset lines
* no photo in asset lines
* no photo in asset lines
* no photo in recruitment lines
* no photo in recruitment lines
* fix
* fix dead catch
2024-06-03 13:44:14 +02:00
Frédéric FRANCE
689cfc36eb
fix cti ( #29812 )
...
* fix cti
Dead catch - OdfException is never thrown in the try block.
* Update json.lib.php
2024-06-03 13:43:20 +02:00
Laurent Destailleur
48c5d9b0bc
Debug v20
2024-05-29 12:26:04 +02:00
Frédéric FRANCE
5b349cc318
clean code pdf ( #29399 )
2024-04-20 22:36:54 +01:00
Laurent Destailleur
56f9ec41c0
FIX regression. A lot of broken feature and corruption of data du to
...
deprecation management.
2024-04-03 22:34:59 +02:00
Laurent Destailleur
3bbbf8ac38
Clean code
2024-03-24 16:03:00 +01:00
MDW
baaa7c721e
Fix PHPdoc typing ($cols, $phpmin)
2024-03-24 14:19:09 +01:00
MDW
83ca2f80d8
Fix PHPdoc for typing
2024-03-22 09:51:49 +01:00
Laurent Destailleur
372c8445fd
Merge pull request #28809 from mdeweerd/PhanPluginPrintfIncompatibleArgumentTypeWeak
...
Fix & enable PhanPluginPrintfIncompatibleArgumentTypeWeak occurrences
2024-03-15 16:32:40 +01:00
MDW
0f8b9e73f0
Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences
...
# Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences
Fix the PhanPluginPrintfIncompatibleArgumentTypeWeak occurences and fix the rule
2024-03-14 23:00:47 +01:00
Frédéric France
26fe76733c
fix warnings
2024-03-13 18:20:41 +01:00
Frédéric France
d666a0f35e
clean
2024-03-12 08:03:41 +01:00
Frédéric France
ac5d19aecd
Merge remote-tracking branch 'upstream/develop' into clean_mod_code
2024-03-11 18:54:16 +01:00
Laurent Destailleur
7226c7c25a
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-03-11 18:30:27 +01:00
Laurent Destailleur
c2602eadf7
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-03-11 18:29:07 +01:00
Laurent Destailleur
330abe14fe
FIX Option MAIN_DOC_USE_TIMING can be a string with date format
2024-03-11 18:28:20 +01:00
Frédéric France
7bcb635a4e
clean code and phpdoc
2024-03-11 18:13:48 +01:00
MDW
8655d5a86b
QUAL Use phan to help detect new issues ( #27706 )
...
* Qual: Add phan flow
- Add phan configuration (config, baseline, stubs);
- Add github action;
- Update apstats.php.
* Add directives to ignore false phan notices
* Qual: Add typing hints for extrafields TPL files
# Qual: Add typing hints for extrafields TPL files
Add typing hints for phan on view files
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-02-21 18:14:29 +01:00
Laurent Destailleur
e9a0905fba
Use same return
2024-02-13 11:14:11 +01:00
MDW
7b54824d49
Fix #28071 - New branch to fix bad merge ( #28083 )
...
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
* Qual: Introduce getDataToShowPhoto to prepare generic code
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Fix missing trans
* Fix langs
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Remove useless files in web templates
* Clean code
* Fix duplicate translation key
* Fix duplicate translation key
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Fix duplicate key
* Fix $object
* Debug v19
* WIP SMSing
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* WIP EMAILINGS_SUPPORT_ALSO_SMS
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* WIP SMSing
* Debug the "validate" feature
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Clean code
* Move rights->x->y into hasRight('x', 'y')
* Move rights->x->y into hasRight('x', 'y')
* Move rights->x->y into hasRight('x', 'y')
* Move rights->x->y into hasRight('x', 'y')
* Move rights->x->y into hasRight('x', 'y')
* Move rights->x->y into hasRight('x', 'y')
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
* Enhance rector to fix empty($user->rights->modulex->perm1)
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
* Fix template to use v19 dev rules
* Fix use v19 dev rules
* Fix phpunit
* Debug v19
* Clean code
* Use rector to convert user->rights into user->hasRight
* Clean code
* Use rector to convert user->rights into user->hasRight
* Use rector to convert user->rights into user->hasRight
* Clean code
* Fix phpcs
* add editorconfig for sql files (#27999 )
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
* add model_pdf field in llx_ticket-ticket.sql (#27996 )
* add model_pdf field in llx_ticket-ticket.sql
* Update 19.0.0-20.0.0.sql
* Update 19.0.0-20.0.0.sql
* Improve wording in README (#27994 )
* fix phpstan (#27989 )
* fix phpstan
* Update UserRightsToFunction.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
* Qual: Fix spelling/working in datapolicy translations (#28006 )
# Qual: Fix spelling/wording in datapolicy translations
Fixed some spelling and wording in datapolicy translations.
* qual: phpstan for htdocs/ticket/class/ticketstats.class.php (#27986 )
htdocs/ticket/class/ticketstats.class.php 98 Parameter #1 $year (string) of method TicketStats::getNbByMonth() should be compatible with parameter $year (int) of method Stats::getNbByMonth()
* Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
* Fix user with readonly perm on email template must be able to read.
* Fix doc
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Better message
* Add missing fields in merge of thirdparty
* Debug v19 selection of ticket printer per terminal
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Use constant
* NEW: Adding a recipient on emails sent, change status to sent partialy.
* fix travis (#28052 )
* fix travis
* Update partnership.class.php
* fix php doc (#28047 )
* fix undefined array key (#28048 )
* Add region and departament for Cuba (#28046 )
* Update llx_10_c_regions.sql
Add Cuba Regions (id_country=77)
* Update llx_20_c_departements.sql
Add Provinces Cuba (id country=77)
* Find the typo (#28050 )
* Find the typo
* clean code
* add last_main_doc field to product (#28045 )
* add las_main_doc field to product
* add field fetch
* NEW Add Categorie filter for ActionComm (#28041 )
* New Add Categorie filter for ActionComm
New Add Categorie filter for ActionComm
* Fix space errors
Fix space errors
* Fix space errors 2
Fix space errors 2
* Update cunits.class.php (#28056 )
FIX: error SQL when creating a Cunit
* Update codespell-lines-ignore.txt to avoid PR merge conflict
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com >
Co-authored-by: thibdrev <thibault.drevet@gmail.com >
Co-authored-by: sonikf <93765174+sonikf@users.noreply.github.com >
Co-authored-by: Ikarus <44511582+LeKarSol@users.noreply.github.com >
Co-authored-by: Anthony Damhet <73399671+EchoLoGeek@users.noreply.github.com >
Co-authored-by: Quentin-Seekness <72733832+Quentin-Seekness@users.noreply.github.com >
2024-02-09 15:58:49 +01:00
MDW
89004f7e03
Qual: Spelling htdocs/core ( #27491 )
...
Highlights:
- initialY in pdf_standard.modules.php was unused
- remove (otherwise -> initially) (+same in other file)
2024-01-13 19:48:20 +01:00
MDW
39769482b1
Qual: Fix typing hints for DoliDB ( #27484 )
...
# Qual: Fix typing hints for DoliDB
This should help the static tools for type and method checking.
2024-01-13 15:50:02 +01:00
Laurent Destailleur
4501872f17
Clean code with rector 2
2024-01-05 04:33:58 +01:00
Charlène Benke
de020ca4ab
php 8.1 depreciated strftime
2023-12-30 08:13:16 +01:00
Laurent Destailleur
fb083a6cfc
Fix warning with rector
2023-12-13 16:33:17 +01:00
Laurent Destailleur
9e1b90e4a1
Fix with php-cs-fixer
2023-12-04 12:07:31 +01:00
