Laurent Destailleur
d24069d5e2
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-10-03 20:35:33 +02:00
MDW
1834c37c16
Qual: Fix phan notices ( #31212 )
...
* Qual: Fix phan notices
# Qual: Fix phan notices
Fix several phan notices related to classes with UnknownObject
classes.
* Qual: Fix phan notices
* Qual: Fix phan notices
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-10-03 19:40:34 +02:00
Hasanuzzaman Sattar
b85b826b18
FIX#31241 ( #31245 )
2024-10-03 16:33:18 +02:00
Laurent Destailleur
42471decac
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-10-03 15:50:44 +02:00
Laurent Destailleur
59004c6fe8
FIX Revert storing of ticket files into event dir, too many troubles.
...
Files must remains into ticket directory.
2024-10-03 15:04:32 +02:00
Laurent Destailleur
294cab04be
Track event BILL_SUPPLIER_CREATE in agenda
2024-10-02 19:48:12 +02:00
MDW
8236aed22f
Qual: Fix phan notices ( #31193 )
...
# Qual: Fix phan notices
Fix phan notices in several classes that have UnknownObjectMethod calls and classes
that had notices in relation with these classes
2024-09-30 10:05:24 +02:00
Laurent Destailleur
09b1496058
Debug module webhook
2024-09-27 16:43:02 +02:00
Laurent Destailleur
96046c40a8
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-09-27 16:13:39 +02:00
Laurent Destailleur
364bef7f79
FIX webhook must send POST in body. Add WEBHOOK_POST_SEND_DATA_IN_BODY
...
for this.
2024-09-27 16:11:00 +02:00
Laurent Destailleur
cc95331fc6
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-09-23 22:09:24 +02:00
Laurent Destailleur
7b5c4b2e99
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2024-09-23 21:57:16 +02:00
Laurent Destailleur
c10e968600
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-09-23 21:52:08 +02:00
MaximilienR-easya
fd0338cb1c
Backport Fix error on empty(NOLOGIN) ( #30594 )
...
* initial commit
* Backport Fix from develop
* Fix precommit
* Correction as sugested in the PR
* Deleted too much last commit
* this time it's good
2024-09-23 03:53:22 +02:00
MDW
115627a054
Qual: Fix PhanPluginUnknownObjectMethodCall where is the only phan notice ( #30957 )
...
* Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice
# Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice
Fix PhanPluginUnknownObjectMethodCall in files where it is the only phan notice
* Update phan baseline
* Fix $website global type in some contexts
2024-09-16 01:49:38 +02:00
Laurent Destailleur
4b1b0084c9
Fix phan
2024-09-10 02:22:12 +02:00
Laurent Destailleur
613c25b5ff
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-09-10 02:02:16 +02:00
Laurent Destailleur
def1cfe27e
Debug clone tasks
2024-09-10 01:57:46 +02:00
Laurent Destailleur
8d786cb73a
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-09-01 14:35:58 +02:00
Laurent Destailleur
3f9b2d9d57
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2024-09-01 14:15:57 +02:00
Laurent Destailleur
80411ff95c
Content-type should be enough. So wa can accept error message in html
2024-09-01 14:08:28 +02:00
Lucas Marcouiller
cfd56c0653
fix #30800 bad GetUrlContent with no hearders for webhook ( #30803 )
...
Co-authored-by: Hystepik <lmarcouiller@nltechno.com >
2024-08-31 19:41:29 +02:00
William Mead
5f7f0b2e3c
Qual isolate FichinterLigne class to separate file ( #30784 )
...
* Moved FichinterLigne class to separate file
* Fixed class properties PHPDoc
* Updated PHPDoc
* Fixed author id usage
* Fixed user author id
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-29 17:39:17 +02:00
Laurent Destailleur
8958aed2ef
Fix cursor
2024-08-28 03:30:06 +02:00
MDW
f5c7ca1769
Qual: Fix PhanPluginUnknownObjectMethodCall in classes with high occurence ( #30754 )
...
* Qual: Fix PhanPluginUnknownObjectMethodCall in import.php
* Qual: PHPDoc for import/export array types
* Qual: Add PHPDoc types to import.class.php
* Fix PhanPluginUnknownObjectMethodCall in stats.class.php
* Add methods expected on ModeleImport child classes
* Force imapemail type for phan
* Qual: Update phan baseline
* Qual: Fix Undefined/Undeclared phan notices in module_help
* Update baseline
2024-08-27 04:51:41 +02:00
jyhere
f551a1e34e
FIX: Possible warnings in WorkflowManager ( #30737 )
...
Possible warnings if $object->fetchObjectLinked() is called earlier (e.g by an external module)
2024-08-23 15:05:34 +02:00
MDW
d71cd352d5
Qual: Fix PhanUndeclaredMethod ( #30661 )
...
* Qual: Fix PhanUndeclaredMethod cases
* Fix PhanUndeclaredMethod cases
* Qual: Remove PhanUndeclaredMethod exceptions
* Fix spelling "disacard"
* Improve phpdoc, add abstract method to trait for typing
* Improve phpdoc typing for PHanUndeclaredMethod
* Suppress phan notices for guarded AliasNbPages calls
* Fix return value for printFile stub
* Fix getting message from Exception
* Define dummy getAllByProducts(), typing for it.
* Fix typo in comment
* Qual: Better typing for apiService (phan)
* Test that the Generic OAuth Service is provided
* Qual: Fix getSqlArrayForStats typing
* Force modTcpdfbarcode
* Correct typing hint
* Set ModelePDFAsset typehint
* Fix ModelePDFUserGroup typing hint
* Fix phan typing hints htdocs/core/modules/printing/printgcp.modules.php
* Fix write_file in ModelePDFStock*
* Update printsheet.php
* Adjust typing hint for barcode generator
* Update printsheet.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-19 02:05:27 +02:00
MDW
75ed925f06
Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") ( #30563 )
...
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint in phan config to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjects
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Fix: MemberNumRefNumbers getExample does not take any arguments
Found thanks to adding the typing for phan!
* Qual: Correct forced type for $module
* Qual: Ignore phan false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Ignore false positive
* Qual: phan/Ignore false positive, replace depr.prop with method
* Qual: Fix typing for count by adding is_array check
* Qual: replace depr.prop `nom` with method
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Fix depr.prop with getter and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: Improve typing for mymodule template
* Make info method arguments match calls
* Make PrintingDriver abstract class because we added abstract methods
* Add phpdoc typing for phan
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update header wit correct information
* Update getExample method signature
* Update getExample method signature
* Correct reference to class in comment
* Force php phan typing for numbering modules
* Correct $_GLOBALS to $GLOBALS
* Add phpdoc to indicat type of properties
* Correct default to null
* Improve getNextValue typehint
* Improve getNextValue typehint
* Qual: Improve ModeleNumRefTakepos typing
* Qual: Improve ModeleNumRefRecruitmentJobPosition typing
* Fix default for $langs
* Do not use non-existing ModeleNumRefTakepos::nom
* Allow getNextValue argument to be null
* Correct $_GLOBAL into $GLOBALS
* Improve typing for ldap functions
* Allow null for outputlangs argument
* Improve typing for printOriginLine
* Improve typing for linkedObject access
* Fix PhanTypeMismatchArgumentNullableInternal and optimize
* Fix PhanPossiblyUndeclaredVariable by setting default value
* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4
* getToolTip does not accept null, changed to ''
* Improve getNextValue typing
* Change PrintingDriver back to normal class (instantiated)
And add errors for functions that should be overloaded
* Adjust pringOriginLine typing to match parent
* Fix phpdoc for getNextValue
* Fix phan typing
* Add/Improve phpdoc typing hints
* Qual: Adjustments to match typing
* Update typing for unit, use GETPOSTINT
* ModeleNumRefTask needs Project
* Fix several notices appearing after update from develop
* Index for choices is int, use GETPOSTINT
* Qual: Ignore empty foreach
* Force BOMLine on object line
* phan typing to indicate that linked objects are BOM
* Type the correct variable name (phan)
* Add typing for $langs
* Type to CommonNumRefGenerator (no class for availabilities)
* Resolve several phan notices after update from dev branch
* Extra typing fixes
* Move common attributes to parent class (phan)
* Add typing to Calendar class
* Improve typing hints
* Add typing to pdf_eagle_proforma
* Qual: Add typing for token in generic_oauthcallback.php
* Add typing for objMod
* Correct getNextValue function signature (phpstan)
* Fix typing (phpstan)
* Update version declarations (fix phpstan)
* Fix phpstan typing issues
* Adjust typing (phpstan)
* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
MDW
e570f59e2d
Qual: Phan fixes (mainly Initial type cannot be inferred) in popular changed classes ( #30604 )
...
* Update setValueFrom $id type to include null
* Only 2 arguments for ModeleNumRefMembers::getToolTip
* Fix PhanTypeConversionFromArray
* Only 6 args for PaymentSalary::addPaymentToBank
* Fix typing hints (array -> string)
* Fix uninitialized variables
* Add cssview to attributes phpdoc
* Avoid double typing specification (Phan notice)
* Qual: Ensure variable is defined (phan)
* Ensure phpdoc typing for verif method
* Ensure phpdoc typing for getNextValue method
* Add status as data key in cols array
* Ensure preg_replace operates on string (phan)
* Correct type for desiredstock
* Fix typing with casts (phan)
* Fix check that notification already exists
* Initialise fk_parent_id to fix typing issue
* Qual: Fix phan notices for Societe & related
* Qual: Fix typing for Facture and related
* Qual: Fix typing for Product & related
* Update baseline
* Fix new phpstan notices
2024-08-14 01:24:55 +02:00
Laurent Destailleur
ee298218be
NEW Add more log information
2024-07-29 12:16:41 +02:00
Frédéric FRANCE
55bc8b7b15
phpdoc ( #30180 )
2024-06-29 19:36:32 +02:00
Frédéric FRANCE
ad93a54402
fix phpstan ( #29961 )
...
Expression in empty() is not falsy.
2024-06-10 14:07:28 +02:00
Lucas Marcouiller
56d8564bce
Fix #29797 add test on Target status ( #29860 )
...
Co-authored-by: Hystepik <lmarcouiller@nltechno.com >
2024-06-06 23:32:19 +02:00
battosai30
d0b183f12a
Update interface_95_modWebhook_WebhookTriggers.class.php ( #29795 )
...
Allow webhook request on the same machine or on the local network
2024-05-31 15:07:01 +02:00
Laurent Destailleur
82908a30eb
Clean phan warnings
2024-05-30 13:37:17 +02:00
Laurent Destailleur
59ae417912
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-05-23 12:52:28 +02:00
Laurent Destailleur
2a3372b3dc
Fix warning
2024-05-17 12:59:02 +02:00
Laurent Destailleur
a99e72ce93
Fix warning
2024-05-17 12:58:12 +02:00
Laurent Destailleur
7e8285fa3a
Fix warning
2024-05-16 15:44:44 +02:00
Laurent Destailleur
e3c26a2084
Debug v20
2024-05-15 17:12:16 +02:00
lelex86
671ae12bee
Fix: content-type haeder missing for webhook ( #29588 )
...
Data sent by webhooks is encoded in JSON and sent using the CURLOPT_POSTFIELDS function in cURL. However, the Content-Type header is not explicitly specified. By default, cURL automatically sets the Content-Type header to application/x-www-form-urlencoded, which can cause issues with certain applications.
To avoid this, I explicitly set the Content-Type header to application/json. This ensures that the data is sent in the correct format and that applications receiving the data can process it correctly.
2024-05-02 19:40:30 +02:00
Laurent Destailleur
db8785869e
Fix warning
2024-04-30 13:24:07 +02:00
Laurent Destailleur
f5adfeca59
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-04-29 13:39:20 +02:00
Laurent Destailleur
d9847070b3
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-04-29 13:34:41 +02:00
Laurent Destailleur
94e93aea05
Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0
2024-04-29 13:32:47 +02:00
Laurent Destailleur
77ac3fe3f0
Fix error
2024-04-29 11:34:58 +02:00
Laurent Destailleur
d3fe7fca09
Try to fix cti
2024-04-29 11:32:54 +02:00
Laurent Destailleur
9e654e65dd
Debug v20
2024-04-29 11:04:19 +02:00
HENRY Florian
768846191b
fix: when invoice is created by WORKFLOW_ORDER_AUTOCREATE_INVOICE on ORDER_CLOSE, the invoice must have the default bank account of the thirdparty is it's empty on order ( #29462 )
...
* fix: when invoice is created by WORKFLOW_ORDER_AUTOCREATE_INVOICE on ORDER_CLOSE, the invoice must have the default bank account of the thirdparty is it's empty on order
* fix: add control on back stattement
2024-04-27 12:49:27 +02:00
Laurent Destailleur
64ecea7c83
FIX #26959
2024-04-14 02:53:20 +02:00
