2
0
forked from Wavyzz/dolibarr
Commit Graph

92 Commits

Author SHA1 Message Date
MDW
d2568a0878 Qual: Enable PhanUndeclaredVariableAssignOp 2024-03-18 13:12:53 +01:00
Laurent Destailleur
bb0e18deae Merge pull request #28922 from mdeweerd/fix/printf
Fix & enable Phan printf checks
2024-03-17 21:08:26 +01:00
MDW
7a4f5ec4f8 Qual: Enable some low occurence notifications 2024-03-17 20:12:27 +01:00
MDW
aa5aa2bf26 Add one more index to the theme_datacolor 2024-03-17 19:49:10 +01:00
MDW
d73886281c Qual: Set typing for global 2024-03-17 18:56:44 +01:00
MDW
81d5f30466 Qual: Enable PhanPluginPrintfIncompatibleArgumentType 2024-03-17 18:56:43 +01:00
MDW
4232713e96 Qual: enable PhanPluginPrintfVariableFormatString 2024-03-17 18:21:35 +01:00
Laurent Destailleur
91c5868020 Merge pull request #28909 from mdeweerd/fix/PhanPluginUnknownClosureReturnType
Fix & enable PhanPluginUnknownClosureReturnType
2024-03-17 03:03:35 +01:00
MDW
551eaa115c Fix & enable PhanPluginUnknownClosureReturnType
# Fix & enable PhanPluginUnknownClosureReturnType

Fix last PhanPluginUnknownClosureReturnType & enable the notice as
all are fixed
2024-03-17 00:10:18 +01:00
MDW
ef6eea3ed2 Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
# Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname

PhanTypeExpectedObjectOrClassName should be fixed by testing that the classname is not
empty.
2024-03-17 00:03:20 +01:00
Laurent Destailleur
7930226c0b Merge branch 'develop' into qual/no_PhanTypeMismatchPropertyProbablyReal_exceptions 2024-03-16 21:37:43 +01:00
Laurent Destailleur
75fae0f27d Merge branch 'develop' into fix/PhanTypeMismatchReturn 2024-03-16 16:08:08 +01:00
MDW
cb55fb0864 Remove PhanTypeMismatchPropertyProbablyReal exceptions in baseline 2024-03-16 14:56:55 +01:00
MDW
ee97747eb6 Qual: Update phan baseline with issue we're not fixing now 2024-03-16 13:52:53 +01:00
MDW
725e419a46 Qual: Enable PhanTypeMismatchReturn 2024-03-16 13:52:19 +01:00
MDW
7b53202f74 Qual: Enable detection of use of DeprecatedFunctions 2024-03-16 13:27:52 +01:00
Laurent Destailleur
a247b474d7 Merge pull request #28885 from mdeweerd/fix/phan/low_occurrence
Fix some phan notifications with low occurrence
2024-03-16 11:48:10 +01:00
MDW
8a83388905 Qual: Enable several phan notifications 2024-03-16 00:00:25 +01:00
MDW
375e4d7ccf Qual: Enable PhanTypeMismatchArgumentInternalReal 2024-03-15 23:41:17 +01:00
Laurent Destailleur
372c8445fd Merge pull request #28809 from mdeweerd/PhanPluginPrintfIncompatibleArgumentTypeWeak
Fix & enable PhanPluginPrintfIncompatibleArgumentTypeWeak occurrences
2024-03-15 16:32:40 +01:00
Laurent Destailleur
0ee6fd6bad Merge pull request #28877 from mdeweerd/PhanTypeMismatchDefault
Fix & enable PhanTypeMismatchDefault
2024-03-15 15:44:30 +01:00
Laurent Destailleur
b658beab99 Merge pull request #28872 from mdeweerd/fix/PhanTypeMismatchReturnProbablyReal
Fix & enable PhanTypeMismatchReturnProbablyReal
2024-03-15 15:24:31 +01:00
Laurent Destailleur
1a722fa436 Merge branch 'develop' into fix/PhanTypeMismatchPropertyProbablyReal 2024-03-15 15:07:35 +01:00
MDW
1af4e90027 Qual: enable PhanTypeMismatchDefault 2024-03-15 14:53:07 +01:00
MDW
c7ad91cfc0 Qual: Enable PhanTypeMismatchReturnProbablyReal 2024-03-15 14:20:58 +01:00
Laurent Destailleur
066565938c Merge pull request #28812 from mdeweerd/fix/PhanTypeSuspiciousEcho
Fix & enable PhanTypeSuspiciousEcho
2024-03-15 11:02:33 +01:00
Laurent Destailleur
11c77c410b Merge pull request #28864 from mdeweerd/fix/PhanUndeclaredTypeReturnType
Fix & enable PhanUndeclaredTypeReturnType
2024-03-15 11:01:11 +01:00
MDW
651b5a22eb Fix & enable PhanTypeSuspiciousEcho
# Fix & enable PhanTypeSuspiciousEcho

Fix occurences by improving typing - array key was not found and
supposed null in a print statement.

Example:
  PhanTypeSuspiciousEcho Suspicious argument $menu_array[$i]['prefix'] of type null for an echo/print statement

Enabled detection because all cases are fixed
2024-03-15 10:14:40 +01:00
MDW
ec6786ece3 Detect PhanTypeMismatchPropertyProbablyReal 2024-03-15 10:12:52 +01:00
MDW
3384a0b847 Fix & enable PhanUndeclaredTypeReturnType
# Fix & enable PhanUndeclaredTypeReturnType

One typo, and replace 'number' with int or int|float
2024-03-15 10:07:15 +01:00
Laurent Destailleur
470e68829d Merge branch 'develop' into fix/PhanTypeInvalidUnaryOperandNumeric 2024-03-15 10:03:50 +01:00
Laurent Destailleur
80e2e59373 Merge pull request #28862 from mdeweerd/fix/PhanTypeMismatchPropertyDefault
Fix & enable PhanTypeMismatchPropertyDefault
2024-03-15 09:33:40 +01:00
Laurent Destailleur
e238cc204e Merge pull request #28750 from mdeweerd/fix/PhanPluginSuspiciousParamPosition
Fix: Resolve several PhanPluginSuspiciousParamPosition cases
2024-03-15 08:45:25 +01:00
Laurent Destailleur
1a63080e44 Merge branch 'develop' into fix/PhanTypeMismatchPropertyDefault 2024-03-15 08:41:23 +01:00
Laurent Destailleur
176d8173a6 Merge pull request #28861 from mdeweerd/fix/PhanPluginPHPDocInWrongComment
Fix & enable PhanPluginPHPDocInWrongComment
2024-03-15 08:28:47 +01:00
MDW
9fd8b8c8e8 Qual: Enable PhanTypeMismatchPropertyDefault 2024-03-15 03:55:53 +01:00
Laurent Destailleur
b23e627a05 Merge pull request #28800 from mdeweerd/PhanPluginDuplicateConditionalUnnecessa
Fix & enable PhanPluginDuplicateConditionalUnnecessary "X ? Y : Y"
2024-03-15 00:27:58 +01:00
Laurent Destailleur
c49968bb4b Merge pull request #28825 from mdeweerd/fix/PhanNoopBinaryOperator
Fix & Enable PhanNoopBinaryOperator
2024-03-14 23:55:33 +01:00
MDW
ab7879c4a2 Fix & enable PhanPluginPHPDocInWrongComment
# Fix & enable PhanPluginPHPDocInWrongComment

Ignore error in file where the notification occurs & enable detection.
2024-03-14 23:36:24 +01:00
Laurent Destailleur
e478fd8cbc Merge pull request #28859 from mdeweerd/fix/PhanPluginUnknownClosureParamType
Fix & enable PhanPluginUnknownClosureParamType
2024-03-14 23:10:37 +01:00
Laurent Destailleur
2508523f66 Merge pull request #28826 from mdeweerd/fix/PhanNoopProperty
Fix & enable PhanNoopProperty
2024-03-14 23:08:00 +01:00
MDW
0f8b9e73f0 Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences
# Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

Fix the PhanPluginPrintfIncompatibleArgumentTypeWeak occurences and fix the rule
2024-03-14 23:00:47 +01:00
MDW
43342c8978 Qual: Allow PhanNoopBinaryOperator (all fixed) 2024-03-14 22:57:43 +01:00
MDW
a408288ba1 Fix & enable PhanPluginUnknownClosureParamType
# Fix & enable PhanPluginUnknownClosureParamType

Typing of anonymous functions to fix this notice.
Optimised some minor things.
2024-03-14 22:42:26 +01:00
MDW
97f4e4f462 Qual: Disable PhanPluginDuplicateCatchStatementBody which requires PHP7.1 for fix
# Qual: Disable PhanPluginDuplicateCatchStatementBody which requires PHP7.1 for fix

To fix this PHP7.1 is required, so skipping the message in the extended
report as well.
2024-03-14 20:05:32 +01:00
MDW
b2cbf7fe3c Qual: Enable PhanPluginDuplicateConditionalUnnecessary notices (all fixed) 2024-03-14 19:47:27 +01:00
MDW
69be3bbca6 Fix PhanTypeInvalidUnaryOperandNumeric & remove from exceptions
# Fix PhanTypeInvalidUnaryOperandNumeric & remove from exceptions

Fix by casting result of date() or by adding typing hints.

(This notification indicates a unary '-' or similar is performed
on a value that may not be a number).
2024-03-14 19:39:49 +01:00
MDW
49416784ce Fix PhanPluginSuspiciousParamPosition 2024-03-14 19:39:29 +01:00
MDW
b28f6a2cba Enable PhanNoopProperty 2024-03-14 19:37:47 +01:00
MDW
0127cc76f5 Qual: Enable PhanTypeInvalidUnaryOperandIncOrDec (all fixed) 2024-03-13 17:38:14 +01:00