Wavyzz/dolibarr-fork
2
0
Fork 0
forked from Wavyzz/dolibarr
Code Pull Requests Activity
132,560 Commits 36 Branches 189 Tags
4768243bf44cb15b322769712a55b8ea2b0977d0
Commit Graph

500 Commits

Author SHA1 Message Date
Laurent Destailleur
06ae1deb1b Fix better error message when using bad character_set_client 2024-03-18 17:27:06 +01:00
Frédéric FRANCE
1783d68fd4 Update pgsql.class.php 2024-03-18 14:10:55 +01:00
MDW
66c592717d Fix PhanTypeMismatchBitwiseBinaryOperands by typing argument 2024-03-17 20:12:35 +01:00
MDW
9eed23c6d0 Fix return type by cast or typing update 
# Fix return type by cast or typing update

Fix most PhanTypeMismatchReturn notifications.

The remaining ones are likely real bugs or need more Dolibarr
knowledge to fix them efficiently
 2024-03-16 13:52:12 +01:00
MDW
6e5c4ef851 Fix PHPDoc date_m typo 2024-03-11 21:43:50 +01:00
Laurent Destailleur
b963a9ab36 Fix phpunit 2024-03-11 16:30:33 +01:00
Laurent Destailleur
2cbeca6d4f Merge pull request #28668 from atm-john/fix_element_type_part_04 
NEW : Factoring and Fix external module elementType limit - Part 04
 2024-03-11 16:29:34 +01:00
Laurent Destailleur
553587b660 Update DoliDB.class.php 2024-03-11 16:27:46 +01:00
Laurent Destailleur
5b921d0dc4 Update DoliDB.class.php 2024-03-11 16:26:17 +01:00
MDW
dbfb1180ee Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions (#28749) 
# Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions

Fix occurences of PhanPluginDuplicateIfStatements which are if statements where the
consecutive branches execute the same code, making it useles to test the condition
 2024-03-11 12:58:51 +01:00
MDW
6d9e7b8144 Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal (#28732) 
* Fix: False positive for PhanTypeMismatchArgumentInternalProbablyReal

* Qual: phan: suppress false positive on ssl_set

* Qual: Enable PhanTypeMismatchArgumentInternalProbablyReal

# Qual: Enable PhanTypeMismatchArgumentInternalProbablyReal

PhanTypeMismatchArgumentInternalProbablyReal are fixed and reporting can
be enabled.

* Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal by improving typing

* Qual: Rewrite/optimize to fix PhanTypeMismatchArgumentInternalProbablyReal

# Qual: Rewrite/optimize to fix PhanTypeMismatchArgumentInternalProbablyReal

False positive detecting that  is not an int, rewriting to check
impact
 2024-03-10 01:55:56 +01:00
MDW
0b19aa415c Fix: Initialise array before assigning values (#28728) 
* Qual: Enable PhanUndeclaredVariableDim

# Qual: Enable PhanUndeclaredVariableDim

The notifications are fixed in the code so the detection no longer
needs to be suppressed in the default flow

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Qual: Add type hint to array to avoid phan notification

* Qual: Add type hint to array to avoid phan notification

* Qual: Enable PhanParamSpecial1 (all resolved)

* Qual: Ignore false PhanTypeArraySuspiciousNullable

* Qual: Improve typing to fix PhanTypeArraySuspicious

* Qual: Fix PhanTypeArraySuspicious by replacing null assignment with empty array

* Qual: Fix PhanTypeArraySuspicious by testing as instancof DebugBar

* Qual: Fix PhanTypeComparisonToArray with enhanced typing

* Qual: Fix PhanTypeComparisonToArray with enhanced typing

* Qual: Enable phan messages that no longer appear

* Qual: Exclude phan stubs from codesniffer ruleset
 2024-03-09 16:32:02 +01:00
Laurent Destailleur
cb58ad2e60 Merge branch 'develop' into fix_element_type_part_04 2024-03-08 22:06:53 +01:00
thibdrev
cc5366249a qual: phpdoc for htdocs/core/db/mysqli.class.php (#28703) 
PHPDoc update to reflect what the code does today.

This update however doesn't solve this PHPStan warning:
htdocs/core/db/mysqli.class.php	243	Return type (mysqli|null) of method DoliDBMysqli::connect() should be compatible with return type (resource) of method Database::connect()
 2024-03-08 12:10:09 +01:00
ATM john
24059b0b8d get rows security 2024-03-06 17:24:23 +01:00
MDW
eb1f6be1e2 Qual: Add information from backtrace when mysql request fails. (#28583) 
# Qual: Add information from backtrace when mysql request fails.

This helps locate the line that was responsible for the SQL request
 2024-03-02 19:57:59 +01:00
lamrani abdelwadoud
b41020a801 Fix method by changing return type (#28507) 
* FIX return method getListOfCharacterSet by adding null type

* Fix return method getListOfCollation by adding return null
 2024-02-28 20:05:33 +01:00
MDW
8655d5a86b QUAL Use phan to help detect new issues (#27706) 
* Qual: Add phan flow

- Add phan configuration (config, baseline, stubs);
- Add github action;
- Update apstats.php.

* Add directives to ignore false phan notices

* Qual: Add typing hints for extrafields TPL files

# Qual: Add typing hints for extrafields TPL files

Add typing hints for phan on view files

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-02-21 18:14:29 +01:00
Lucas Marcouiller
f84ae10dbf Fix some php warnings (#28278) 
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
 2024-02-19 17:57:16 +01:00
Frédéric FRANCE
3a1e6d2a58 fix phpstan pgsql.class.php (#28152) 2024-02-13 09:03:30 +01:00
Laurent Destailleur
eb4f53665d Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 
Conflicts:
	.github/workflows/pre-commit.yml
	ChangeLog
	dev/tools/codespell/codespell-lines-ignore.txt
	htdocs/comm/mailing/card.php
	htdocs/contact/card.php
	htdocs/langs/en_US/admin.lang
	htdocs/modulebuilder/template/core/modules/mailings/mailinglist_mymodule_myobject.modules.php
 2024-02-07 18:30:10 +01:00
Laurent Destailleur
4aeda8d28d Fix escapeforlike/escape 2024-02-03 15:29:40 +01:00
MDW
044d342956 Fix: LABEL is required on the db classes. 
# Fix: LABEL is required on the db classes.

Define const in parent type so that it is required in the subclasses.
 2024-01-29 18:56:17 +01:00
MDW
3a4cef8705 fixup! QUAL Force subclass MINVERSION (#26314) 2024-01-23 21:20:35 +01:00
MDW
4b162cefee QUAL Force subclass MINVERSION (#26314) 
* Define DoliDB::VERSIONMIN as mandatory constant in subclass

See https://stackoverflow.com/a/43134924/6378634

This also helps static tool checks
 2024-01-23 20:47:19 +01:00
Frédéric France
03e29c6960 fix param 2024-01-20 09:22:38 +01:00
MDW
b4b0cdf105 Fix: Deprecated mysqli::init() in PHP8.1 
# Fix: Deprecated mysqli::init() in PHP8.1

See https://www.php.net/manual/en/migration81.deprecated.php#migration81.deprecated.mysqli
 2024-01-18 22:04:19 +01:00
MDW
89004f7e03 Qual: Spelling htdocs/core (#27491) 
Highlights:
- initialY in pdf_standard.modules.php was unused
  - remove (otherwise -> initially) (+same in other file)
 2024-01-13 19:48:20 +01:00
Laurent Destailleur
aba9afe9f1 NEW Add method getPublicImageOfObject() for website module 2024-01-12 13:05:28 +01:00
Laurent Destailleur
8874ef8454 Debug v19 2023-12-23 18:47:38 +01:00
Laurent Destailleur
97ae114265 FIX Universal search syntax accept string with ' in the IN 2023-12-19 15:01:21 +01:00
Laurent Destailleur
44f24746ed Fix warnings 2023-12-15 13:49:09 +01:00
Laurent Destailleur
dae7bb5e80 Fix phpstan 2023-12-15 11:02:50 +01:00
Laurent Destailleur
dc134cddba FIX Remove useless code line that make phpstan hang with not enough 
memory
 2023-12-15 10:46:49 +01:00
Can Arslan
9a5a24a634 FIX: PHPDoc return type 2023-12-11 16:03:20 -07:00
Frédéric FRANCE
61b79fda17 avoid phpstan error with phpdoc 2023-12-06 15:46:39 +01:00
Laurent Destailleur
2eb630cd00 Fix with php-cs-fixer 2023-12-04 12:05:02 +01:00
Frédéric FRANCE
53c8a3acf8 clean phpdoc for phpstan (#26905) 2023-12-01 19:51:32 +01:00
Laurent Destailleur
fa79a93a51 Fix warning 2023-11-27 12:16:09 +01:00
Laurent Destailleur
53dab922fd Fix php8.2 warnings 2023-11-27 11:39:32 +01:00
MDW
3c966469ef QUAL No return values in __construct(), correct PHPDoc for typing (#26768) 2023-11-20 23:47:06 +01:00
MDW
24f8488b48 QUAL Force subclass MINVERSION (#26314) 
* Define DoliDB::VERSIONMIN as mandatory constant in subclass

See https://stackoverflow.com/a/43134924/6378634

This also helps static tool checks

* fixup! Define DoliDB::VERSIONMIN as mandatory constant in subclass
 2023-10-21 16:27:52 +02:00
Laurent Destailleur
553776a77a Enhance error message when set character set failed 2023-10-05 12:58:44 +02:00
Laurent Destailleur
76a7801975 Fix warning 2023-10-05 11:27:00 +02:00
Laurent Destailleur
d02c615f40 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into 
develop
 2023-09-16 15:14:22 +02:00
Laurent Destailleur
5e0bd9bb71 Avoid warning 2023-09-16 13:53:29 +02:00
Laurent Destailleur
818b1193b1 Fix escapesql 2023-09-15 16:19:05 +02:00
Laurent Destailleur
00609fb6c7 FIX Warning 2023-09-14 15:31:05 +02:00
Laurent Destailleur
630e305161 Standardize db drivers. No more static class. 2023-08-04 04:18:59 +02:00
Laurent Destailleur
6a962cbefa Debug v19 2023-08-01 17:06:22 +02:00