Laurent Destailleur
0968183f6a
Merge pull request #28794 from mdeweerd/fix/PhanPluginDuplicateIfCondition
...
Fix: fix/PhanPluginDuplicateIfCondition
2024-03-12 21:24:06 +01:00
MDW
8bd965fb80
Fix duplicate if condition
...
# Fix duplicate if condition
Removed the duplicate which had a different action but it was not effective in the code
so it was removed (it looks like a leftover).
2024-03-12 19:09:06 +01:00
Frédéric France
fc732b1be5
fix mod barcode product
2024-03-12 18:49:29 +01:00
MDW
3d47d9b894
Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
...
# Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
PhanTypeExpectedObjectOrClassName should be fixed by testing that the classname is not
empty.
2024-03-12 18:40:06 +01:00
MDW
a59fd68987
Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
...
# Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
PhanTypeExpectedObjectOrClassName should be fixed by testing that the classname is not
empty.
2024-03-12 18:40:05 +01:00
MDW
7825954f2a
Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
...
# Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
PhanTypeExpectedObjectOrClassName should be fixed by testing that the classname is not
empty.
2024-03-12 18:40:04 +01:00
Laurent Destailleur
a6926c29c0
Merge pull request #28778 from fappels/develop_fix_delivery_note
...
Fix shipping is not a delivery_note (is sub module of shipping)
2024-03-12 14:53:51 +01:00
Laurent Destailleur
ee3fa7f643
Merge pull request #28776 from mdeweerd/fix/phpdoc1
...
Fix: PHPdoc and minor code changes from phpstan logs
2024-03-12 14:27:52 +01:00
Laurent Destailleur
d62ef14064
Merge pull request #28768 from mdeweerd/fix/PhanTypeMismatchDeclaredParamNullable
...
Fix: PhanTypeMismatchDeclaredParamNullable & enable detection
2024-03-12 14:19:41 +01:00
Laurent Destailleur
f4b6dd927d
Merge pull request #28771 from mdeweerd/typeing/module_parts
...
Qual: Typing : make all $module_parts fields optional and add missing
2024-03-12 14:15:56 +01:00
Francis Appels
6f1b184f17
Merge remote-tracking branch 'Dolibarr/develop' into develop_fix_delivery_note
2024-03-12 14:13:41 +01:00
Laurent Destailleur
949c885477
Merge branch 'develop' into fix/phpdoc1
2024-03-12 14:11:30 +01:00
Francis Appels
7ff68a5819
Fix shipping is not a delivery_note (sub module of shipping)
2024-03-12 11:07:18 +01:00
Frédéric FRANCE
c8714ea50b
clean
2024-03-12 09:54:32 +01:00
Frédéric FRANCE
9b4c8f2445
clean
2024-03-12 09:48:42 +01:00
Frédéric FRANCE
0bcd1035cc
clean
2024-03-12 09:29:11 +01:00
Frédéric FRANCE
bb7ecb956f
clean
2024-03-12 09:24:48 +01:00
Frédéric France
ddfd1fbfd4
clean
2024-03-12 08:10:29 +01:00
Frédéric France
424eabf966
clean
2024-03-12 08:08:44 +01:00
Frédéric France
16f161e263
clean
2024-03-12 08:06:42 +01:00
Frédéric France
d666a0f35e
clean
2024-03-12 08:03:41 +01:00
Frédéric France
8b79cfa095
clean
2024-03-12 00:16:06 +01:00
MDW
eefe123dcb
fixup! fix phpstan ( #28727 )
2024-03-11 23:46:53 +01:00
Frédéric France
a300206c28
clean code and phpdoc
2024-03-11 21:59:48 +01:00
MDW
4e20c644c2
Qual: Correct PHPdoc typing
2024-03-11 21:51:04 +01:00
Frédéric France
23ae21958b
clean code and phpdoc
2024-03-11 20:57:48 +01:00
Frédéric France
ac5d19aecd
Merge remote-tracking branch 'upstream/develop' into clean_mod_code
2024-03-11 18:54:16 +01:00
Frédéric France
50e8c19b7e
clean code and phpdoc
2024-03-11 18:50:18 +01:00
Frédéric France
71a65557bb
clean code and phpdoc
2024-03-11 18:36:05 +01:00
Frédéric France
6f3ba871e0
clean code and phpdoc
2024-03-11 18:33:41 +01:00
Laurent Destailleur
7226c7c25a
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-03-11 18:30:27 +01:00
Frédéric France
e160ba6ba4
clean code and phpdoc
2024-03-11 18:29:41 +01:00
Laurent Destailleur
c2602eadf7
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-03-11 18:29:07 +01:00
Laurent Destailleur
330abe14fe
FIX Option MAIN_DOC_USE_TIMING can be a string with date format
2024-03-11 18:28:20 +01:00
Frédéric France
f19fc5c70c
clean code and phpdoc
2024-03-11 18:18:59 +01:00
Frédéric France
7bcb635a4e
clean code and phpdoc
2024-03-11 18:13:48 +01:00
MDW
8e1b6543b8
Qual: Typing : make all $module_parts fields optional and add missing
...
# Qual: Typing : make all $module_parts fields optional and add missing
According to the initialisations of the modules all fields for $module_parts are optional
and some keys were missing in the definition.
This is updated.
2024-03-11 18:13:04 +01:00
MDW
b7acea0ec4
Fix: PhanTypeMismatchDeclaredParamNullable notices
...
# Fix: PhanTypeMismatchDeclaredParamNullable notices
PHPDoc must indicate param is nullable if the default is null
with explicit typing.
(+Improved some other typing from generic Object to CommonObject).
2024-03-11 16:47:38 +01:00
Laurent Destailleur
39ea68ace4
Try fix phan
2024-03-11 15:20:56 +01:00
Laurent Destailleur
61d328093c
Fix warnings
2024-03-11 14:28:55 +01:00
MDW
b72cf193c4
Fix some cases of PhanTypeSuspiciousStringExpression ( #28751 )
...
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
* Fix PhanTypeSuspiciousStringExpression
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-03-11 14:01:28 +01:00
Laurent Destailleur
0f2121e3ba
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-03-11 13:46:08 +01:00
MDW
dbfb1180ee
Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions ( #28749 )
...
# Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions
Fix occurences of PhanPluginDuplicateIfStatements which are if statements where the
consecutive branches execute the same code, making it useles to test the condition
2024-03-11 12:58:51 +01:00
MDW
aee0509473
Qual: Force typing on variable fixing several phan notices ( #28740 )
...
* Qual: Force typing on variable fixing several phan notices
# Qual: Force typing on variable fixing several phan notices
Forcing DolibarrModules on $objMod after assignment to fix typing checks
* Qual: Fix typing on import_label/export_label
2024-03-11 12:56:55 +01:00
Philippe Grand
e25fb6f39b
update code, better compliance with php8 ( #28746 )
...
* update code, better compliance with php8
* update code, better compliance with php8
2024-03-11 12:54:32 +01:00
Laurent Destailleur
ec1b8284c9
Rename files to use an english name
2024-03-10 15:52:29 +01:00
MDW
37afba949e
Fix most PhanTypeMismatchDimAssignment notices ( #28739 )
...
* Qual: Add typing to fix PhanTypeMismatchDimAssignment notice
* Fix: Initialise array for code in somme
* Qual: Update type hint for argument in _Set_Format
* Qual: Update type hint for childtables
* Qual: Add typing to attributes
* Qual: Add typing for _msgContent
* Qual: Suppress PhanTypeMismatchDimAssignment
* Qual: Add typing for liste
* Qual: Add typing to fields
* Qual: Add typing hint for $objMod
* Qual: Modify assignment of array with bool keys for phan typing
Demonstration:
```
php -r '$a=[true=>"yes",false=>"no"];var_dump($a);'
# Result demonstrates bool keys are converted to int.
Command line code:1:
array(2) {
[1] =>
string(3) "yes"
[0] =>
string(2) "no"
}
```
* Qual: Add typing hint to indicate value is not null
* Force non-null type on $paramname
* Qual: Add typing hint to getCats()
* Update inc.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-03-10 01:53:04 +01:00
MDW
0b19aa415c
Fix: Initialise array before assigning values ( #28728 )
...
* Qual: Enable PhanUndeclaredVariableDim
# Qual: Enable PhanUndeclaredVariableDim
The notifications are fixed in the code so the detection no longer
needs to be suppressed in the default flow
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Qual: Add type hint to array to avoid phan notification
* Qual: Add type hint to array to avoid phan notification
* Qual: Enable PhanParamSpecial1 (all resolved)
* Qual: Ignore false PhanTypeArraySuspiciousNullable
* Qual: Improve typing to fix PhanTypeArraySuspicious
* Qual: Fix PhanTypeArraySuspicious by replacing null assignment with empty array
* Qual: Fix PhanTypeArraySuspicious by testing as instancof DebugBar
* Qual: Fix PhanTypeComparisonToArray with enhanced typing
* Qual: Fix PhanTypeComparisonToArray with enhanced typing
* Qual: Enable phan messages that no longer appear
* Qual: Exclude phan stubs from codesniffer ruleset
2024-03-09 16:32:02 +01:00
Frédéric FRANCE
e00a9816f8
fix phpstan ( #28727 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-03-09 14:48:06 +01:00
Laurent Destailleur
a8444e72cd
Use user->hasRight
2024-03-09 01:45:31 +01:00
