MDW
fd9d48faac
Fix phpstan CommonObject->fields - notnull is optional field
2024-03-19 00:32:00 +01:00
MDW
2917b34519
Fix phpstan $fields property issue
...
Fix Property FactureFournisseur::$fields (array) does not accept default value of type array{rowid: array
2024-03-19 00:31:58 +01:00
MDW
a5d16b326b
Fix: Initialise $amount_ttc_diff to fix PhanUndeclaredVariableAssignOp
2024-03-18 13:12:49 +01:00
Laurent Destailleur
5e51092efd
Merge pull request #28926 from frederic34/phpstanphpstan
...
fix phpstan
2024-03-17 21:57:25 +01:00
Laurent Destailleur
ebba438fbe
Merge pull request #27528 from altairisfr/rdb
...
[DATA_MODEL] rename commande_fournisseur_dispatch into receptiondet_batch
2024-03-17 21:31:27 +01:00
Frédéric France
17ea003a69
fix phpstan
2024-03-17 21:20:36 +01:00
Laurent Destailleur
90ecb139b3
Merge pull request #28919 from mdeweerd/fix/trim
...
Fix several useless trims or bad arguments to trim (PhanTypeMismatchArgumentInternal) & related bugs
2024-03-17 21:14:13 +01:00
MDW
7ab07a1549
Fix PhanPluginSuspiciousParamOrder in updete() by removeing arg
2024-03-17 20:12:47 +01:00
MDW
18cfd0dae6
Fix PhanTypeComparisonFromArray by testing $error field
...
# Fix PhanTypeComparisonFromArray by testing $error field
getListOfPayments always returns an array, comparing it to 0 is invalid.
To know if there was an error, we should test error, not the size of the result.
Updated getListOfPayments as well to initialize error to ""
2024-03-17 20:12:45 +01:00
MDW
e56546515c
Fix unneeded trim, unneeded urlencode
2024-03-17 15:04:48 +01:00
Laurent Destailleur
de58435ef1
FIX: if we stop for security purpose, we must exit a non zero value.
2024-03-16 23:08:15 +01:00
Laurent Destailleur
487a55750a
Fix warnings
2024-03-16 22:13:00 +01:00
Laurent Destailleur
e994d6650f
Fix regression in GETPOST limit
2024-03-16 11:41:00 +01:00
Laurent Destailleur
79aa9fb1f1
Code simpler
2024-03-15 20:29:21 +01:00
Laurent Destailleur
0ee6fd6bad
Merge pull request #28877 from mdeweerd/PhanTypeMismatchDefault
...
Fix & enable PhanTypeMismatchDefault
2024-03-15 15:44:30 +01:00
MDW
82157757f0
Fix PhanTypeMismatchDefault by updating defaults
2024-03-15 14:53:03 +01:00
MDW
61b55f21ab
Fix PhanTypeMismatchDefault with typing hint
2024-03-15 14:53:02 +01:00
MDW
575e620300
Fix Assign 0 to fk_project, not null (dolibarr's way)
2024-03-15 10:12:02 +01:00
Laurent Destailleur
80e2e59373
Merge pull request #28862 from mdeweerd/fix/PhanTypeMismatchPropertyDefault
...
Fix & enable PhanTypeMismatchPropertyDefault
2024-03-15 09:33:40 +01:00
Laurent Destailleur
e238cc204e
Merge pull request #28750 from mdeweerd/fix/PhanPluginSuspiciousParamPosition
...
Fix: Resolve several PhanPluginSuspiciousParamPosition cases
2024-03-15 08:45:25 +01:00
MDW
23785393a3
Add csslist to json keys
2024-03-15 03:55:52 +01:00
MDW
9ea2b38c47
Fix PhanTypeMismatchPropertyDefault
2024-03-15 03:48:17 +01:00
MDW
cbd42a7906
Fix PhanPluginSuspiciousParamPosition by renaming arg (local assign)
2024-03-14 19:39:46 +01:00
Frédéric France
ad13f6fc76
fix phpstan is incompatible with
2024-03-14 18:46:17 +01:00
MDW
a997447ce3
Fix PhanPluginRedundantAssignment
2024-03-13 01:04:54 +01:00
MDW
af5816f344
Fix PhanPluginRedundantAssignment
2024-03-13 01:04:53 +01:00
MDW
b1b6ce6dc0
Fix PhanPluginMixedKeyNoKey by using explicit keys
2024-03-12 21:35:48 +01:00
Laurent Destailleur
74b8162d22
Merge pull request #28700 from mdeweerd/urlencode/fixuptype
...
Fix: Ensure the argument type for urlencode is string
2024-03-12 14:43:41 +01:00
Laurent Destailleur
9e16016125
Merge pull request #28770 from mdeweerd/typing/fields
...
Fix: Repeat fields typing in CommonClass children
2024-03-12 14:30:36 +01:00
Laurent Destailleur
949c885477
Merge branch 'develop' into fix/phpdoc1
2024-03-12 14:11:30 +01:00
MDW
88d59896ec
Qual: 'enabled' in fields can be string ('isModEnabled(...)')
...
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')
Update PHPdoc to allow that enabled is a string
2024-03-12 13:38:08 +01:00
MDW
1ea9a7fa48
Qual: set default value to match PHPdoc type
2024-03-11 22:10:04 +01:00
Frédéric France
23ae21958b
clean code and phpdoc
2024-03-11 20:57:48 +01:00
MDW
23eea84309
Fix: Repeat fields typing in CommonClass children
...
# Fix: Repeat fields typing in CommonClass children
phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:34 +01:00
Laurent Destailleur
01c3808478
Merge pull request #28618 from solution-libre/fix-cloned-supplier-order-creation-date
...
FIX cloned supplier order creation date as now
2024-03-11 16:34:35 +01:00
Laurent Destailleur
0f2121e3ba
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-03-11 13:46:08 +01:00
Florent Poinsaut
674e668b78
FIX cloned supplier order creation date as now
2024-03-11 12:42:16 +00:00
Laurent Destailleur
ae7e8a972b
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-03-11 13:39:26 +01:00
Laurent Destailleur
e72671bf50
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-03-11 13:39:04 +01:00
Laurent Destailleur
f40ad6e90a
Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0
2024-03-11 13:31:55 +01:00
Maximilien Valenzano
68441677f7
fix: update currency when selected supplier ( #28760 )
2024-03-11 12:41:30 +01:00
Frédéric FRANCE
895aa5ee85
fix phpstan ( #28735 )
...
* fix phpstan
* fix phpstan
* fix phpstan
2024-03-10 01:44:08 +01:00
MDW
6a2a50d10b
Fix: Ensure string type for urlencode()
2024-03-09 16:56:01 +01:00
MDW
81e8da34ef
Fix: Ensure string type for urlencode()
2024-03-09 16:56:00 +01:00
MDW
beb0cfe5b4
Fix: Ensure string type for urlencode()
2024-03-09 16:55:59 +01:00
MDW
24b0a17c30
Fix: Ensure string type for urlencode()
2024-03-09 16:55:58 +01:00
MDW
97a20b8aa9
Fix: Ensure string type for urlencode()
2024-03-09 16:55:57 +01:00
MDW
3a6e3404e2
Fix: Ensure string type for urlencode()
2024-03-09 16:55:56 +01:00
MDW
0b19aa415c
Fix: Initialise array before assigning values ( #28728 )
...
* Qual: Enable PhanUndeclaredVariableDim
# Qual: Enable PhanUndeclaredVariableDim
The notifications are fixed in the code so the detection no longer
needs to be suppressed in the default flow
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Qual: Add type hint to array to avoid phan notification
* Qual: Add type hint to array to avoid phan notification
* Qual: Enable PhanParamSpecial1 (all resolved)
* Qual: Ignore false PhanTypeArraySuspiciousNullable
* Qual: Improve typing to fix PhanTypeArraySuspicious
* Qual: Fix PhanTypeArraySuspicious by replacing null assignment with empty array
* Qual: Fix PhanTypeArraySuspicious by testing as instancof DebugBar
* Qual: Fix PhanTypeComparisonToArray with enhanced typing
* Qual: Fix PhanTypeComparisonToArray with enhanced typing
* Qual: Enable phan messages that no longer appear
* Qual: Exclude phan stubs from codesniffer ruleset
2024-03-09 16:32:02 +01:00
le-reparateur
b601dabf66
Update fournisseur.product.class.php ( #28729 )
...
* Update fournisseur.product.class.php
#28710
* Update fournisseur.product.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-03-09 15:14:23 +01:00