2
0
forked from Wavyzz/dolibarr
Commit Graph

167 Commits

Author SHA1 Message Date
MDW
8602ca9885 Fix: implode->join and duplicated if condition (#28761)
* Fix: join->implode

# Fix: join->implode

Update new cases of join

* Fix: Duplicate if condition in if/else sequence

# Fix: Duplicate if condition in if/else sequence

Fixed repeated if condition and action
2024-03-11 12:55:55 +01:00
Laurent Destailleur
f32bf4b3a7 Fix join -> implode 2024-03-11 12:38:21 +01:00
Laurent Destailleur
0887664888 NEW: All fetchAll() method now support the USF syntax. 2024-03-11 11:23:34 +01:00
Laurent Destailleur
a63d7e0802 Fix regression 2024-03-07 19:06:08 +01:00
Laurent Destailleur
e6b2756c19 QUAL The signature for all ->delete() method has been modified to match
the modulebuilder template (so first param is now always $user), except
  the delete for thirdparty (still accept the id of thirdparty to delete
as first parameter). Will probably be modified into another version.
2024-03-07 17:58:02 +01:00
Laurent Destailleur
c544efec7f QUAL: Remove use of customurl filter. Must use the USF syntax. 2024-03-05 03:51:36 +01:00
thibdrev
2b4bc3b4bc qual: phpstan for htdocs/resource/class/dolresource.class.php (#28352)
htdocs/resource/class/dolresource.class.php	723	Property Dolresource::$busy (int) does not accept string.

htdocs/resource/class/dolresource.class.php	726	Property Dolresource::$mandatory (int) does not accept string.
2024-02-22 13:22:24 +01:00
William Mead
37a31f75b7 Qual clean dolresource class (#28308)
* Use address, town, zip & email from CommonPeople

* Use element & table_element from CommonObject

* Updated PHPDoc

* Deleted unused properties

* Revert "Use element & table_element from CommonObject"

This reverts commit 88a06164d1.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-21 13:59:41 +01:00
Laurent Destailleur
a95cd96278 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-19 16:47:21 +01:00
Laurent Destailleur
213cca0c8d Fix warning and migration error 2024-02-19 16:47:04 +01:00
William Mead
8c186d570c Added resource URL (#28277) 2024-02-19 16:40:25 +01:00
Laurent Destailleur
87c9fa1902 Fix phpunit 2024-02-18 23:23:57 +01:00
William Mead
0ad5f06059 Qual resource date user (#28209)
* Added resource creation date & modification date

* Added user create & user modify

* Cleaned code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-18 22:58:17 +01:00
thibdrev
f7f9dfd77c qual: phpstan - Property CommonObject::$tms (int) does not accept string. (#28247)
* Update paymentdonation.class.php

* Update paymentexpensereport.class.php

* Update productbatch.class.php

* Update propalmergepdfproduct.class.php

* Update productstockentrepot.class.php

* Update stocktransfer.class.php

* Update dolresource.class.php

* Update paymentsalary.class.php

* Update salary.class.php
2024-02-18 14:56:31 +01:00
William Mead
423e0d9124 Fixed empty status (#28200) 2024-02-16 12:15:36 +01:00
William Mead
0a0edcf273 Qual clean dolresource (#27864)
* Updated PHPDoc

* Cleaned code & comments. Typed method parameters.

* Cleaned code

* Force int cast

* Fixed PHP 7.0 compatibility

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-15 16:49:54 +01:00
Frédéric FRANCE
5f1c679142 fix warning (#28177)
* fix warning

* clean properties

* clean properties
2024-02-15 13:59:19 +01:00
William Mead
d612e32c06 NEW resource phone, email & maxusers (#28185)
* Added resource phone, email & max_users

* Cleaned code

* Added phone, email & max_users

* Cleaned code. Removed fields shown in header.

* Cleaned code

* Fixed resource create

* Add MaxUsers localization
2024-02-15 13:44:29 +01:00
Laurent Destailleur
038fcbab3d Fix compatibility 2024-02-08 00:24:27 +01:00
Laurent Destailleur
18a6d9695c Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-01-20 17:55:39 +01:00
Laurent Destailleur
72f2547422 Update dolresource.class.php 2024-01-20 00:46:02 +01:00
William Mead
89257dbd76 Updated parameter clean for numeric values 2024-01-19 11:32:19 +01:00
William Mead
ee101fd6ff Updated code comments 2024-01-19 10:45:55 +01:00
William Mead
8fbeb2deac Merge branch 'develop' into fix-dolresource-phpstan-lvl3
# Conflicts:
#	htdocs/resource/card.php
2024-01-19 09:55:07 +01:00
Frédéric FRANCE
2dca7faf26 phpdoc 2024-01-18 21:37:43 +01:00
William Mead
097a220674 Cleaned code 2024-01-18 12:40:37 +01:00
William Mead
2782f32c1f Fixed PHPDoc 2024-01-18 12:16:05 +01:00
William Mead
1c1c4396a9 Merge branch 'develop' into new-resource-full-address 2024-01-15 10:16:06 +01:00
William Mead
8d0f013378 Merge branch 'develop' into fix-resource-phpstan 2024-01-15 09:25:50 +01:00
MDW
39769482b1 Qual: Fix typing hints for DoliDB (#27484)
# Qual: Fix typing hints for DoliDB

This should help the static tools for type and method checking.
2024-01-13 15:50:02 +01:00
MDW
342ab85195 Qual: Spelling htdocs/[q-z]* (#27447)
# Qual: Fix spelling htdocs/[q-z]*

Probably fixes a bug:

- htdocs/webservices/server_thirdparty.php
  No other occurence of adress found.
  -'adress'=>->adress,- +'address'=>->address,+
2024-01-12 17:18:52 +01:00
William Mead
c533dc3f4c Fixed method filter argument type. Cleaned code. 2024-01-12 12:34:49 +01:00
William Mead
b70a3cfe7d Refactored property init 2024-01-10 16:27:26 +01:00
William Mead
352e54f407 Merge branch 'Dolibarr:develop' into new-resource-full-address 2024-01-09 16:38:28 +01:00
Frédéric FRANCE
4268f3e27f fix incorrect default value 2024-01-08 18:34:32 +01:00
Laurent Destailleur
b28ae5d8d3 Clean code 2023-12-27 12:12:20 +01:00
William Mead
ce6386fc10 Merge branch 'develop' into new-resource-full-address
# Conflicts:
#	htdocs/resource/class/dolresource.class.php
#	htdocs/resource/element_resource.php
2023-12-14 11:38:25 +01:00
Frédéric FRANCE
61b79fda17 avoid phpstan error with phpdoc 2023-12-06 15:46:39 +01:00
Laurent Destailleur
619155f65e Fix with php-cs-fixer 2023-12-04 13:53:48 +01:00
Frédéric FRANCE
53c8a3acf8 clean phpdoc for phpstan (#26905) 2023-12-01 19:51:32 +01:00
Laurent Destailleur
e8dc651877 Fix php8.2 warnings 2023-11-27 11:56:32 +01:00
William Mead
63f1e44493 Cleaned method naming 2023-11-16 09:45:04 +01:00
William Mead
514c40f281 Cleaned PHPDoc 2023-11-16 09:32:17 +01:00
William Mead
b2b27d2d5b Cleaned create method error handling 2023-11-16 09:16:10 +01:00
William Mead
9c86f7d242 Refactored create method with try catch for dol_syslog calls. Cleaned create method PHPDoc. 2023-11-16 08:47:11 +01:00
William Mead
59af3dac7f Cleaned code 2023-11-16 08:10:49 +01:00
William Mead
72e95027af Cleaned code 2023-11-15 17:04:40 +01:00
William Mead
4aee2010ca Moved class property initialisation to constructor 2023-11-15 17:01:30 +01:00
William Mead
51955efb56 Refactored resource create method 2023-11-15 16:51:16 +01:00
William Mead
55e0c69633 Refactored create method parameter cleaning 2023-11-15 09:01:47 +01:00