2
0
forked from Wavyzz/dolibarr
Commit Graph

241 Commits

Author SHA1 Message Date
Laurent Destailleur
861725e87b Merge pull request #33070 from frederic34/patch-11
fix phpdoc
2025-02-13 17:29:41 +01:00
Frédéric FRANCE
781bff6e9d Update date.lib.php 2025-02-13 15:06:01 +01:00
Frédéric FRANCE
0524c4ea10 Update date.lib.php 2025-02-13 13:48:43 +01:00
Kévin Begot
d727977cb7 fix: cast timestamp to int 2025-02-13 13:38:48 +01:00
Frédéric FRANCE
8df094317d fix phpdoc 2025-02-13 13:33:05 +01:00
MDW
1a2d4ed6be Qual: Fix phan (product-2) 2025-02-09 20:14:25 +01:00
Laurent Destailleur
8b04314ea3 Add a TODO 2025-02-02 01:08:40 +01:00
Chloé
303b7423f3 fix: update list_public_holiday return type 2024-12-24 11:01:15 +01:00
Chloé
39e509f380 fix: list_public_holiday function return type 2024-12-24 10:50:29 +01:00
Benoît PASCAL
fed049e93e feat: add function to get public holidays list within period 2024-12-24 10:36:53 +01:00
Laurent Destailleur
8ccab8a5fa Doc 2024-11-11 14:45:30 +01:00
Laurent Destailleur
7e8fff6cb0 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-11-10 18:28:05 +01:00
Laurent Destailleur
4d29fd4beb More complete fix for #31746 2024-11-10 18:23:17 +01:00
Frédéric FRANCE
940324f76d fix dol_time_plus_duree with unit egal mn instead i (#31746)
* fix dol_time_plus_duree with unit egal mn instead i

* Update date.lib.php
2024-11-10 18:15:57 +01:00
Pichi1966
b6945d0c27 Fix function num_between_day in date.lib.php in Dev code v21 (#31732)
When debugging Asset Module, I discovered that function num_between_day is returning 0 when $timestampStart equals (==) $timestampEnd and $lastday == 1
Normally it has to return
0 if $lastday = 0
1 if $lastday = 1
2024-11-08 14:46:44 +01:00
MDW
e7539f2e19 Qual: Fix notices in .lib.php files (#31672)
* Qual: Fix notices in .lib.php files

* Update wrapper.php

* Update availabilities_card.php

* Update index.php

* Update document.controller.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 12:32:13 +01:00
MDW
28e78d6cb4 Qual: Fix phan/stan notices for conferenceorbooth, facture-re, productcustomerprice (#31541) 2024-10-25 14:18:17 +02:00
MDW
0d2f1cf666 Qual: Fix phpstan notices (int expected) (#31485)
# Qual: Fix phpstan notices (int expected)

Fix several notices where int was expected (casting/phpdoc/GETPOSTINT).
Separate phpstan exceptions for methods containing 'pdf' from
other methods/functions.
2024-10-24 14:01:30 +02:00
Laurent Destailleur
78e17b5d49 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-03 20:26:32 +02:00
Laurent Destailleur
37c55004e7 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-10-03 16:17:27 +02:00
Laurent Destailleur
6a09e7c91a Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-10-03 16:15:06 +02:00
Sylvain Legrand
5d58a33f37 Fix tz array (#31240)
The list of time zones included in the 'get_tz_array()' function no longer matches the list of zones supported by PHP!
See the pages "https://www.php.net/manual/fr/timezones.php"

When using these values, this caused a 500 error: "PHP Fatal error: Uncaught Exception: DateTimeZone::__construct(): Unknown or bad timezone (Pacific/Enderbury) " for example =>
$arraytz = get_tz_array();
foreach ($arraytz as $key => $value) {
$date = new DateTime();
$date->setTimezone(new DateTimeZone($value));
}

When several zone names could be used for the same time zone, I favored the canonical name (The primary, preferred zone name).
See the table "https://en.wikipedia.org/wiki/List_of_tz_database_time_zones"
2024-10-03 15:38:41 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
Laurent Destailleur
6ca2e746ca Fix DOS attack by using num_public_holiday() - repeated sql in loop 2024-09-23 13:09:45 +02:00
Laurent Destailleur
c6554aa935 PERF Reduce nb of requests into num_public_holiday 2024-09-23 13:02:43 +02:00
Frédéric FRANCE
97392965e1 fix ignored phpstan (#30645)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan
2024-08-16 20:13:02 +02:00
MDW
8b71242997 Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests (#30544)
* Remove PhanPluginDuplicateExpressionAssignmentOperation from baseline

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* fixup! Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-07 02:53:45 +02:00
Laurent Destailleur
da577e8a24 Debug look and feel v20 2024-06-12 00:45:23 +02:00
Charlène Benke
79c2b9ea8e Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-05-21 17:10:18 +02:00
Charlène Benke
c035536a6c pentecote renamed on pentecost (#29712)
in dictionnary table we use pentecost, not pentecote

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-21 17:08:29 +02:00
Frédéric FRANCE
2279fa5d2d clean code (#29713)
* clean code

* fix typo

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-21 17:06:26 +02:00
MDW
e2b0295308 Adjust to real typings 2024-03-27 10:18:34 +01:00
MDW
fab3a7a02b Fix typing with casts 2024-03-22 09:52:38 +01:00
MDW
d591d258f1 Fix null return by returning 0 2024-03-20 21:58:44 +01:00
MDW
c0e8e053b8 Fix port arg to count by adding typing information 2024-03-19 02:59:09 +01:00
MDW
25dd2433a1 Fix PhanPluginPrintfIncompatibleArgumentType by typing/casting 2024-03-17 18:56:47 +01:00
Laurent Destailleur
f9f549ef26 Work on generic filter 2024-02-17 04:07:34 +01:00
MDW
93881d8b2d Qual: correct/improve typing annotations (#28155)
# Qual: correct/improve typing annotations

Improve typing annotations in date library.
2024-02-13 08:51:46 +01:00
Christophe TREMBLAY-GUILLOUX
df1a14e905 Merge branch 'develop' of github.com:Dolibarr/dolibarr into develop 2024-01-26 15:13:11 +01:00
Christophe TREMBLAY-GUILLOUX
3ae575348b MINOR: bad description 2024-01-26 10:35:25 +01:00
Frédéric France
03e29c6960 fix param 2024-01-20 09:22:38 +01:00
Laurent Destailleur
47bb0cd17a Merge pull request #27544 from thibdrev/patch-1
fix phpstan
2024-01-15 21:54:31 +01:00
thibdrev
f5e0a9c411 phpstan
Function dol_get_first_day() should return int but returns string.
Function dol_get_last_day() should return int but returns string.
2024-01-15 20:56:59 +01:00
thibdrev
f41a5bc752 phpstan
Function dol_get_first_day() should return int but returns string.
Function getWeekNumber() should return int but returns string.
2024-01-15 18:54:33 +01:00
Laurent Destailleur
3ac7706a63 Clean code 2024-01-15 11:28:25 +01:00
MDW
89004f7e03 Qual: Spelling htdocs/core (#27491)
Highlights:
- initialY in pdf_standard.modules.php was unused
  - remove (otherwise -> initially) (+same in other file)
2024-01-13 19:48:20 +01:00
Laurent Destailleur
e5f5c499a4 Update date.lib.php 2023-12-28 12:42:15 +01:00
Idayat NOUFOU
a2a9d8d9ad Fix: Unsupported operand types 2023-12-28 10:49:45 +01:00
Laurent Destailleur
b28ae5d8d3 Clean code 2023-12-27 12:12:20 +01:00
Laurent Destailleur
1babae58a4 Fix with php-cs-fixer 2023-12-04 12:05:28 +01:00