2
0
forked from Wavyzz/dolibarr
Commit Graph

1502 Commits

Author SHA1 Message Date
Frédéric FRANCE
d0830b3159 fix phpstan (#29602)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

fix phpstan

fix phpstan

fix phpstan

fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-05 00:34:19 +02:00
Laurent Destailleur
e3daa23949 Look and feel v20 2024-04-30 09:45:28 +02:00
Vaadasch
28bfbccf9d NEW Update expense report card.php to allow pdf preview even without thumbnail (#29491)
* Update card.php to allow pdf preview even without thumbnail

In the event of a bug of imagick, PDF are not generating image.png and there is no link to open the PDF reader.

Changing to allow opening of PDF reader by clicking on the icon.

* Eurgh, whitespaces

* Update card.php

* Update card.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-27 17:41:12 +02:00
noec764
713cc38f1c NEW: Expense Report: Add conf to block line creation if line date is out of range (#29427)
* NEW: Expense Report new line add conf to Block if line date out of range

* Update expensereport.php

---------

Co-authored-by: Noé <noe@scopen.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-22 14:56:30 +02:00
Laurent Destailleur
1e3b2c6a7c Try to fix GETPOSTINT regressions 2024-04-19 13:34:48 +02:00
Frédéric FRANCE
4ed203bece fix phpstan (#29382)
* fix phpstan

* remove unused code
2024-04-18 11:21:09 +01:00
Laurent Destailleur
0f1369a192 Standardize GUI 2024-04-12 02:00:28 +02:00
Laurent Destailleur
b5de782c6b Fix use the good HTTP code 2024-04-07 14:59:25 +02:00
thibdrev
229c2dd4b6 qual: phpstan for api_expensereports.class.php
htdocs/expensereport/class/api_expensereports.class.php	608	Method ExpenseReports::getPayments() should return array but returns object.

htdocs/expensereport/class/api_expensereports.class.php	680	Method ExpenseReports::updatePayment() should return int but returns object.
2024-04-04 21:06:31 +02:00
Laurent Destailleur
ad79acf63c QUAL removed duplicate language file 2024-04-04 11:00:35 +02:00
Laurent Destailleur
2947287e3f Look and feel v20 2024-04-03 16:22:16 +02:00
Laurent Destailleur
fffe74246c Fix all short tables must use the setup for the number of rows 2024-04-03 15:30:10 +02:00
Laurent Destailleur
7715513ac9 Some API HTTP return code were moved from 401 to 403 to better follow
REST specification.
2024-04-02 14:47:49 +02:00
Laurent Destailleur
9811ef1a78 Fix phpstan 2024-04-02 14:43:05 +02:00
Laurent Destailleur
990216b13f NEW Api parameters are sanitized by the WAF, same code than GET/POST 2024-04-02 13:07:13 +02:00
Laurent Destailleur
e3037794aa Look and feel v20 2024-04-01 15:04:20 +02:00
Frédéric France
7a7b1953ed fix phpstan 2024-03-28 20:34:33 +01:00
Hystepik
e2fc57b135 expense report line 2024-03-27 12:53:03 +01:00
Laurent Destailleur
6a0678e717 Merge branch 'develop' into PhanTypeInvalidRightOperandOfNumericOp 2024-03-23 17:36:29 +01:00
Laurent Destailleur
f7323cd7bf Update list.php 2024-03-23 16:30:46 +01:00
MDW
c517a8008a Fix PhanTypeInvalid{Left,Right}OperandOfNumericOp mostly by typing, casting, idate 2024-03-23 02:06:48 +01:00
Hystepik
7054f90d76 Fix expensereport bad search_user 2024-03-22 15:38:10 +01:00
MDW
08733e8aed Fix a final left add operand typing issue + some typos 2024-03-22 09:52:43 +01:00
MDW
1164ba68d5 Fix labelStatus typing, casts for typing, PHPdoc 2024-03-22 09:52:40 +01:00
MDW
a853f8e6be Fix type with cast/idate/phpdoc 2024-03-22 09:52:23 +01:00
MDW
1e0f368d6a Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:16 +01:00
MDW
aeefca7e7e Fix $arrayfields typing lost by dol_sort_array() by forcing the type 2024-03-20 23:29:48 +01:00
MDW
9b2c6e2afb Fix arg type to preg_match(),preg_replace() with cast 2024-03-20 04:09:28 +01:00
Laurent Destailleur
5d073ac208 Fix hasRights into hasRight 2024-03-19 22:02:42 +01:00
MDW
a46dfec5c6 Fix return type for deleteLine 2024-03-19 00:32:05 +01:00
MDW
fd9d48faac Fix phpstan CommonObject->fields - notnull is optional field 2024-03-19 00:32:00 +01:00
Frédéric France
17ea003a69 fix phpstan 2024-03-17 21:20:36 +01:00
Frédéric France
26303dc4d3 fix phan 2024-03-17 13:21:34 +01:00
Frédéric France
5e5995731d fix phan 2024-03-17 13:17:51 +01:00
Frédéric France
912be1e1bd fix phan 2024-03-17 13:15:37 +01:00
MDW
71a32b8a52 Merge branch 'develop' into fix/file_ref 2024-03-16 23:36:17 +01:00
Laurent Destailleur
de58435ef1 FIX: if we stop for security purpose, we must exit a non zero value. 2024-03-16 23:08:15 +01:00
MDW
ebd531e308 Fix use array instead of fileinfo
# Fix use  array instead of fileinfo

Detected with PhanTypeSuspiciousStringExpression, seperate PR
because of functional impact (to check)
2024-03-16 21:03:20 +01:00
Laurent Destailleur
e994d6650f Fix regression in GETPOST limit 2024-03-16 11:41:00 +01:00
Laurent Destailleur
79aa9fb1f1 Code simpler 2024-03-15 20:29:21 +01:00
Laurent Destailleur
0ee6fd6bad Merge pull request #28877 from mdeweerd/PhanTypeMismatchDefault
Fix & enable PhanTypeMismatchDefault
2024-03-15 15:44:30 +01:00
Laurent Destailleur
33656f26c9 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-15 15:22:07 +01:00
Laurent Destailleur
e3c4c1aff0 Fix warning 2024-03-15 15:16:22 +01:00
Laurent Destailleur
1a722fa436 Merge branch 'develop' into fix/PhanTypeMismatchPropertyProbablyReal 2024-03-15 15:07:35 +01:00
MDW
8495a75f43 Fix PhanTypeMismatchDefault by removing defaults, update typing
Also remove some unused references to globals
2024-03-15 14:53:01 +01:00
MDW
59abbda92f Fix Assign 0 to fk_bank not null (dolibarr's way) 2024-03-15 10:12:01 +01:00
Laurent Destailleur
470e68829d Merge branch 'develop' into fix/PhanTypeInvalidUnaryOperandNumeric 2024-03-15 10:03:50 +01:00
MDW
23785393a3 Add csslist to json keys 2024-03-15 03:55:52 +01:00
MDW
6b0f48ade7 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:48:16 +01:00
MDW
a12553944a Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:48:15 +01:00