Jon Bendtsen
9142dbb4d2
FIX BUG: default value not changed when updating an extrafield using API #33949 ( #33950 )
...
* FIX BUG: default value not changed when updating an extrafield #33949
Update can now change default value for extrafields and fixes #33949
* Also use $default in updateExtrafields
The previous commit changed postExtrafields, but that is okay, because both needs to be changed
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2025-04-24 02:33:32 +02:00
Jon Bendtsen
783807af14
Tiniest event attendee API - just the POST endpoint ( #33934 )
...
* check if MAIN_AGENDA_XCAL_EXPORTKEY is set before using it
* suggestion from frederic34
* adding 5 new statuses and their functions
* adding 5 new statuses and their functions
* copy and modified from email template api
* remove some unset because they are present in the database
* all objects are ConferenceOrBoothAttendee's
* load eventattendee API file from eventorganization/ folder
* ref is not required and should perhaps be banned because it is ignored during create + nonexisting apifetch function replaced with call to just fetch + making usre to use the correct class
* variable named paid is unused?
* get all event attendees
* fixing the sql statement
* adjusting function checking access rights
* UNTESTED! multicompany support by leftjoining with the projet table which does have an entity column + adjusting checkAccessRights function to prepare for testing project visibility
* adding more statuses and explaining boarding pass better
* expanding access rights checks with a project id and starting to use that after fetch so we know the project_id
* checking if the user has access to the project specified in fk_project
* phan fix getting right
* checking if isModEnabled('multicompany')
* will only show rows of projects which is either public or the user is a contact of
* 2 new status changing functions and some protection for the existing status changing functions
* fix pre-commit check
* typo fix = that should be ==
* adding extrafields and linkedobjectids to event attendee
* should be back to develop branch contents so PR can be smaller
* reducing PR size, just GET and POST
* smallest commit, just the post and functions needed by post
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk >
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2025-04-22 11:45:50 +02:00
ldestailleur
7db8252225
Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop
2025-04-21 13:52:25 +02:00
ptibogxiv
f1fbb98acd
Fix api_setup.class.php ( #33930 )
2025-04-20 18:55:35 +02:00
Frédéric FRANCE
255300a29e
test fix phan ( #33879 )
...
* test fix phan
* test fix phan
* test fix phan
* test fix phan
* test fix phan
2025-04-16 19:55:44 +02:00
Jon Bendtsen
772337d162
redoing PR Api objectlinks #33738 ( #33781 )
...
* redoing PR Api objectlinks #33738
* loading objectlinks api from main api folder
* bringing $FIELDS up to develop branch standard
* trying to tell phan the expected array types
* phan return and input type specifications
* trying to fix 'Method ObjectLink::_makeobject() should return int but return statement is missing.'
* trying to return an ObjecTLink
* get returns an ObjectLink object
* making sure that function _makeobject always has an return
* making sure deleteByValues always has a return statement
* remove empty line
* making sure getByValues always has a return value
* trying to fix phan for _validate
* no < around objectlink
* trying to fix some phan and phan-stan errors
* public variable target should be fk_target
* making TRIGGER_PREFIX more like in core/class/commonobject.class.php
* trying to save and use the notrigger value
* typecast objectlink fk_source and fk_target to string in the hope that they are later made correctly to int
* whitespace to trigger a build of my branch
* back to being int - because that is what they are
* trying to typecast
* trying to help PHPStan to validate fk_source and fk_target
* trying to use the same way as are used
* splitting over multiple lines
* Fix: update ObjectLink return type in API methods
### FIX: Update ObjectLink return type in API methods
- Updated the return type of several methods from `ObjectLink` to `Object` to reflect a return type compatible with Luracast/Restler
* fix: refactor field setting in ObjectLinks class
# Fix: Refactor field setting in ObjectLinks class
- Removed the static `$INTFIELDS` array and moved its logic to a new private
method `_setObjectLinkField`.
- Updated `create`, `getByValues`, and `deleteByValues` methods to use
`_setObjectLinkField` for setting fields.
- Cleaned up the code by removing redundant field validation and type casting
logic.
* noting that relation type can both be string and null
* escaping strings before parsing them to the database
* -> not global
* trying to fix phpstan errors by flipping so the string part is first
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk >
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
Co-authored-by: MDW <mdeweerd@users.noreply.github.com >
2025-04-16 14:49:39 +02:00
ldestailleur
1325b249b0
Clean code to fix some phan warnings
2025-04-01 09:36:36 +02:00
ldestailleur
1726312fc3
Fix travis
2025-03-24 18:23:31 +01:00
Charlène Benke
5fe018cdba
NEW ; Add hook on API call ( #33501 )
...
* NEW ; Add hook on API call
* Update index.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2025-03-19 13:53:17 +01:00
ldestailleur
461cf5616e
Clean code. WIP To manage permission on extrafields.
2025-03-18 14:55:37 +01:00
MDW
f625f8de60
Qual: Fix api phan notices
2025-03-05 13:22:08 +01:00
MDW
6b9361d252
Fix phpstan notices
2025-03-02 20:49:48 +01:00
MDW
035ede5874
Qual: Fix phan notices in API classes
2025-03-02 20:49:46 +01:00
ldestailleur
b65189f4e3
Fix regression
2025-02-17 18:18:57 +01:00
ldestailleur
33d722c84f
API use syntax "Authorization: Bearer ..." instead of "DOLAPIKEY: ..."
2025-02-17 16:02:22 +01:00
MDW
a42bc6755c
Qual: Fix PhanPluginUnknownPropertyType, PhanPossiblyUndeclaredVariable
2025-01-27 10:24:16 +01:00
Frédéric France
86e1625793
fix phpstan
2025-01-06 18:27:30 +01:00
Jon Bendtsen
e22ec699c0
FIX better error when api tempdir is not writeable ( #32150 )
...
* When api/temp folder does not exist or isn't writeable dol_syslog what the folder is and print where to find that information
* flipping line order
* putting suslog line first
* back to original print
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk >
2024-12-01 23:18:38 +01:00
Laurent Destailleur
c2a3a93342
Debug v21 - renameto avoid future conflit
2024-11-24 14:58:40 +01:00
MDW
9ec4618199
Qual: Fix FunctionArray phan notices ( #31754 )
...
* Qual: Fix FunctionArray phan notices
* Fix class name in typing of htdocs/modulebuilder/index.php
* Fix customreports phpdoc
* Adjust file type after completeFileArrayWithDatabaseInfo
* Further phpdoc typing improvements
* More phpdoc
* Improve typing with cast on position field
* Force phpstan version
* Add phpstan exception
* Fix array index type + adjust phan config comment
2024-11-11 14:48:18 +01:00
Frédéric FRANCE
92ef950e6d
fix phpstan ( #31761 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* hide new error with phpstan 1.12.9
2024-11-10 23:47:14 +01:00
Frédéric FRANCE
0d7bc505d3
add phpdoc and clean phpstan baseline ( #31702 )
...
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
* add phpdoc and clean phpstan baseline
2024-11-06 19:39:46 +01:00
Frédéric FRANCE
1adc883b56
add baseline exclude for phpstan ( #31632 )
...
* add baseline exclude for phpstan
* update
* update
* update
* update
* update
* merge
* restore one filter
* delete old errors
* fix
* fix
* fix
* $moreforfilter can t be empty
* fix
* enable check
* refresh baseline
* add phpdoc
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-04 23:53:20 +01:00
Frédéric FRANCE
0f563edb5f
replace fetch_projet() and fetch_project() by fetchProject() ( #29821 )
...
* fix cti
* fix cti
* deprecate fetch_projet fetch_project to fetchProject
* deprecate fetch_projet fetch_project to fetchProject
* deprecate fetch_projet fetch_project to fetchProject
* odfHandler->setSegment only throw OdfExceptionSegmentNotFound
* odfHandler->setSegment only throw OdfExceptionSegmentNotFound
* fix deprecated
* fix
* fix sql
2024-10-26 22:43:44 +02:00
Frédéric FRANCE
44fdcdd8ed
can set position of file with dol_move ( #31201 )
...
* can set position of file with dol_move
* Update api_documents.class.php
* Update api_documents.class.php
* fix
* fix
* fix
* fix
* fix
2024-09-30 16:49:38 +02:00
Frédéric FRANCE
a760fc0092
fix phpstan ( #31189 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-29 21:51:51 +02:00
Laurent Destailleur
2f506b0948
Merge branch '14.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-09-26 03:46:21 +02:00
thomas-Ngr
bb40a43c5f
FIX Add same security test whe nuploading files from API than from GUI ( #31114 )
...
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-26 03:13:34 +02:00
MDW
099dbd9c1e
Qual: Fix notices for htdocs/admin/* ( #30982 )
...
* Fix (Possibly)UndeclaredGlobalVariable
* Update phan baseline
* Fix (Possibly)UndeclaredGlobalVariable (2)
* Qual: Fix notices for htdocs/admin/*
# Qual: Fix notices for htdocs/admin/*
Fixes most phan/phpstan noticies for files under htdocs/admin/* and ai.
2024-09-18 03:27:25 +02:00
Laurent Destailleur
bf697f83eb
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2024-09-12 21:50:31 +02:00
ptibogxiv
d40e0c6026
Fix api_setup.class.php ( #30938 )
...
new fix because old disappared
2024-09-12 21:09:28 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) ( #30649 )
...
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
14d5b4bcc3
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-09-02 12:14:51 +02:00
ptibogxiv
5ddf586413
FIX api.class.php for expense reports ( #30818 )
...
* FIX api.class.php
Descriptions of line in expense reports are named comments
* Update api.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-01 15:10:08 +02:00
MaximilienR-easya
89a1e74df3
Force usage of another authentication when there is only openid_connect since he doesn't work for api, ws, and cdav login ( #30777 )
2024-08-29 09:20:02 +02:00
atm-lena
545015d27b
NEW llxHeader BodyCss divers ( #30723 )
...
Co-authored-by: atm-lena <lena.papazian@atm-consulting.fr >
2024-08-23 15:22:03 +02:00
Laurent Destailleur
5797a0db3f
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-22 02:54:55 +02:00
ptibogxiv
99bcf84a31
Fix api_setup.class.php ( #30682 )
2024-08-20 03:18:40 +02:00
MDW
b0087aaf61
Qual: Enable phan on modulebuilder ( #30652 )
...
* Allow null for buyer, and force '' for in printObjectLine(s)
* Allow null for Contact in show_actions_done
* Qual: Enable phan on modulebuilder
# Qual: Enable phan on modulebuilder
Most files of the modulebuilder template can be checked as regular files.
It will help improve the template
* Update baseline (enable modulebuilder notices)
* Add properties that are expected to exist on modules_boxes
* Qual: Ignore false positive (phan)
* Set phpdoc type to include null on formAddObjectLine
* Qual: Fixes for modulebuilder (phan, phpstan, bugs, format)
* Fix phpcs for intracom
* Make ModeleBoxes:showBox() signature match child class's
* Fix *box::showBox() phpdoc types
* Update index.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-18 18:16:08 +02:00
MDW
75ed925f06
Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") ( #30563 )
...
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint in phan config to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjects
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Fix: MemberNumRefNumbers getExample does not take any arguments
Found thanks to adding the typing for phan!
* Qual: Correct forced type for $module
* Qual: Ignore phan false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Ignore false positive
* Qual: phan/Ignore false positive, replace depr.prop with method
* Qual: Fix typing for count by adding is_array check
* Qual: replace depr.prop `nom` with method
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Fix depr.prop with getter and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: Improve typing for mymodule template
* Make info method arguments match calls
* Make PrintingDriver abstract class because we added abstract methods
* Add phpdoc typing for phan
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update header wit correct information
* Update getExample method signature
* Update getExample method signature
* Correct reference to class in comment
* Force php phan typing for numbering modules
* Correct $_GLOBALS to $GLOBALS
* Add phpdoc to indicat type of properties
* Correct default to null
* Improve getNextValue typehint
* Improve getNextValue typehint
* Qual: Improve ModeleNumRefTakepos typing
* Qual: Improve ModeleNumRefRecruitmentJobPosition typing
* Fix default for $langs
* Do not use non-existing ModeleNumRefTakepos::nom
* Allow getNextValue argument to be null
* Correct $_GLOBAL into $GLOBALS
* Improve typing for ldap functions
* Allow null for outputlangs argument
* Improve typing for printOriginLine
* Improve typing for linkedObject access
* Fix PhanTypeMismatchArgumentNullableInternal and optimize
* Fix PhanPossiblyUndeclaredVariable by setting default value
* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4
* getToolTip does not accept null, changed to ''
* Improve getNextValue typing
* Change PrintingDriver back to normal class (instantiated)
And add errors for functions that should be overloaded
* Adjust pringOriginLine typing to match parent
* Fix phpdoc for getNextValue
* Fix phan typing
* Add/Improve phpdoc typing hints
* Qual: Adjustments to match typing
* Update typing for unit, use GETPOSTINT
* ModeleNumRefTask needs Project
* Fix several notices appearing after update from develop
* Index for choices is int, use GETPOSTINT
* Qual: Ignore empty foreach
* Force BOMLine on object line
* phan typing to indicate that linked objects are BOM
* Type the correct variable name (phan)
* Add typing for $langs
* Type to CommonNumRefGenerator (no class for availabilities)
* Resolve several phan notices after update from dev branch
* Extra typing fixes
* Move common attributes to parent class (phan)
* Add typing to Calendar class
* Improve typing hints
* Add typing to pdf_eagle_proforma
* Qual: Add typing for token in generic_oauthcallback.php
* Add typing for objMod
* Correct getNextValue function signature (phpstan)
* Fix typing (phpstan)
* Update version declarations (fix phpstan)
* Fix phpstan typing issues
* Adjust typing (phpstan)
* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
Laurent Destailleur
2f643b8f99
Fix API_DISABLE_LOGIN_API
2024-08-17 16:30:47 +02:00
Laurent Destailleur
03bc26dcbb
Fix API_DISABLE_LOGIN_API
2024-08-17 16:29:52 +02:00
thibdrev
e5c0150be4
qual: avoid double negations by introducing getDolGlobalBool() ( #30618 )
...
* Update index.php
* Update api.class.php
* Update pdf_eratosthene.modules.php
* Update pdf_sponge.modules.php
* Update pdf_cyan.modules.php
* Update partnershiputils.class.php
* Update paypalfunctions.lib.php
* Update societe.class.php
* Update functions.lib.php - create getDolGlobalBool()
* Update index.php
* Update api.class.php
* Update pdf_eratosthene.modules.php
* Update pdf_sponge.modules.php
* Update pdf_cyan.modules.php
* Update partnershiputils.class.php
* Update paypalfunctions.lib.php
* Update societe.class.php
* Update functions.lib.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-13 22:50:31 +02:00
ptibogxiv
700ee5b39e
NEW translation with action triggers API ( #30595 )
...
* NEW translation with action triggers API
* Update api_setup.class.php
2024-08-13 12:16:10 +02:00
Jon Bendtsen
f1678b7524
NEW: API_LOGINS_ALLOWED_FOR_GET_EXTRAFIELD ( #30562 )
...
* introducing new global variable API_LOGINS_ALLOWED_FOR_GET_EXTRAFIELDS, code copied and modified from public function getModules()
* trying to use a different method to read the variable
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk >
2024-08-11 00:06:00 +02:00
Jon Bendtsen
d4387e7e16
replacing ->global-> with getDolGlobalString because phan complained in a different commit ( #30589 )
...
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk >
2024-08-10 23:23:09 +02:00
MDW
aa49419e8f
Qual: Fix/initial type cannot be inferred ( #30591 )
...
* Update baseline
* Add/update phpdoc typings
* Fix type for AssetDepreciationOptions as is
* Fix typing for Asset->depreciation_lines
* $card is used in derived classes, add it back to ActionsAdherentCardCommon
* Adjust code with typing/corrections for defined types
* Fix typos, code update to match typing, extra typing
* Add type cast for numeric operation
* Phpdoc/cast adjustments detected because of new phpdoc hints
2024-08-10 23:21:46 +02:00
MDW
45ed4caeb2
Qual: Enable Phan Simplify rule and fix notices ( #30537 )
...
* Qual: Phan - Enable Simplyfy expression
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Update functions2.lib.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-07 03:05:02 +02:00
Jon Bendtsen
227bca1867
NEW API /setup endpoint for getting action triggers ( #30538 )
...
* New API /setup endpoint for getting action triggers. This makes it easier to know which ID number to specify to enable PROPAL_VALIDATE notifications
* introducing page and limit, also because phan was complaining
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk >
2024-08-07 03:00:51 +02:00
MDW
8b71242997
Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests ( #30544 )
...
* Remove PhanPluginDuplicateExpressionAssignmentOperation from baseline
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* fixup! Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-07 02:53:45 +02:00
