Alexandre Janniaux
1113ae6dc1
Qual: Commonobject reverse happy path ( #34599 )
...
* commonobject: getRangOfLine: reverse happy and error path
* commonobject: getIdOfLine: reverse error and happy path
2025-06-21 14:35:01 +02:00
ldestailleur
703d4358a5
Debug v22
2025-06-20 12:34:10 +02:00
ldestailleur
9c2da8b9b6
Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop
2025-06-19 11:31:44 +02:00
ldestailleur
a78e63dbf0
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0
2025-06-19 11:13:59 +02:00
ldestailleur
ec098b2632
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2025-06-19 10:59:07 +02:00
ldestailleur
0da1e6b464
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2025-06-19 10:48:18 +02:00
ldestailleur
247847cd14
Fix warnings
2025-06-19 10:39:19 +02:00
Alexandre Janniaux
0770e79749
commonobject: updateLineUp: use early return on query failure ( #34570 )
...
Simplify the code by early returning on query failure, which removes
almost every indentation level of the function.
It also highlights some important flaws here, since there is a return
without value (void return type) between the two queries if an error
happened, which would indicate the first query failed and nothing was
registered, but also an error check leading to printing an error message
if the second query fails, without actually reverting the first one, and
since there is no error code, there's no way to trigger a db->rollback()
from the caller code for this reason.
2025-06-19 10:12:55 +02:00
Alexandre Janniaux
1da9aab8d4
commonobject: updateRangOfLine: de-indent happy path ( #34569 )
...
There's no need for the else{} block when the if block early returns,
and it helps highlighting the happy path. Note that this kind of change
only make sense when one of the block is an error, not a choice between
two possibilities.
2025-06-19 10:11:12 +02:00
Frédéric FRANCE
bf2d6f1f1e
fix CI ( #34553 )
...
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2025-06-19 10:10:42 +02:00
ldestailleur
06a5b4947d
Fix CI
2025-06-18 15:59:28 +02:00
Alexandre Janniaux
f04a390cb5
commonobject: getChildrenOfLine: early return on query error ( #34547 )
...
This makes the code more readable by deindenting two whole levels on the
happy path.
2025-06-18 14:19:37 +02:00
ldestailleur
8208b1d40f
Debug v22
2025-06-17 01:13:09 +02:00
Laurent Destailleur
13f483d7a9
Merge branch 'develop' of github.com:Dolibarr/dolibarr into develop
2025-06-14 16:03:56 +02:00
Laurent Destailleur
8d7a5e9945
Debug v22
2025-06-14 15:59:13 +02:00
Marc de Lima Lucio
467c772504
FIX: common fields: php warning with select input field ( #34495 )
2025-06-14 11:58:25 +02:00
IC-Nicolas
6474c7fbdd
FIX display error ( #34494 )
...
* FIX display error
* FIX CI
2025-06-14 11:57:58 +02:00
HENRY Florian
e17b36b0c7
fix: warning Form IA and settings ( #34426 )
...
* fix: warning Form IA and settings
* fix: warning Form IA and settings
* Update html.formmail.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2025-06-13 16:13:02 +02:00
Laurent Destailleur
bfd2359fd8
Debug v22
2025-06-13 03:21:40 +02:00
ldestailleur
fdd02a0ebe
Fix CI
2025-06-11 18:17:56 +02:00
ldestailleur
175b79db3f
Fix CI
2025-06-11 18:07:33 +02:00
ldestailleur
7ad71279a7
Fix CI
2025-06-11 17:33:07 +02:00
ldestailleur
14a689c4a7
Debug v22
2025-06-11 15:08:52 +02:00
ldestailleur
9e26f5a98e
Debug v22
2025-06-11 12:45:15 +02:00
ldestailleur
267b65cd9b
Fix CI
2025-06-10 14:38:13 +02:00
Laurent Destailleur
b1812b1080
Debug v22
2025-06-10 02:24:08 +02:00
Laurent Destailleur
221c27c091
Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop
2025-06-09 18:15:59 +02:00
Laurent Destailleur
326c75dc51
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0
2025-06-09 17:58:54 +02:00
ldestailleur
9cc83f44de
Debug v22
2025-06-08 13:23:46 +02:00
ldestailleur
04f1176d50
Debug v22
2025-06-05 17:47:40 +02:00
ldestailleur
81ea4aaa8c
Try to fix CI
2025-06-04 16:18:03 +02:00
ldestailleur
02b9dfed38
Fix CI
2025-06-04 16:06:11 +02:00
ldestailleur
6d16d2298c
Try fix ci
2025-06-04 15:58:01 +02:00
ldestailleur
22e2087b9e
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2025-06-04 15:10:42 +02:00
kkhelifa-opendsi
115a430652
FIX: Fix delete ecm file into database when delete a contract ( #34310 )
2025-06-04 14:31:23 +02:00
ldestailleur
ae06fde2c5
Doc
2025-06-04 14:04:43 +02:00
ldestailleur
7ed8450d8a
Fix CI
2025-06-04 10:59:27 +02:00
Günter Lukas
eaf0ec2e30
Fix #34346 - SQL Error ( #34347 )
...
* Fix #34346 - SQL Error
* Update commonobject.class.php
2025-06-03 17:05:10 +02:00
ldestailleur
88e75755fa
Debug v22
2025-06-02 21:10:45 +02:00
ldestailleur
f3fb48dcde
Debug v22
2025-06-02 20:51:21 +02:00
ldestailleur
9135a63867
Debug v22
2025-06-02 17:11:38 +02:00
ldestailleur
7b8223d66a
Debug v22
2025-06-02 17:07:25 +02:00
ldestailleur
d543bdcffe
Debug v22
2025-06-02 16:59:46 +02:00
ldestailleur
36b00c5951
Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop
2025-06-02 14:59:18 +02:00
ldestailleur
78d261916f
Debug v22
2025-06-02 14:22:47 +02:00
ldestailleur
b3ada81875
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2025-05-28 09:57:55 +02:00
ldestailleur
95519edb78
Debug v22
2025-05-28 09:57:46 +02:00
Laurent Destailleur
c35965030c
Debug v22
2025-05-28 01:16:02 +02:00
Laurent Destailleur
3c3df0c24d
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2025-05-28 00:09:40 +02:00
Laurent Destailleur
1b3b123472
Debug v22
2025-05-28 00:09:02 +02:00
