MDW
58ba3e31fa
Qual: Fix spelling for crypted and referer ( #27408 )
...
# Qual: Fix spelling for crypted and referer.
The proper spelling is encrypted and referrer, but the code has
some occurences where referer and crypted need to be maintained.
To make verification easier, this spelling correction is limited to
mostly these corrections and some minor translations and a only a
few other corrections.
crypted and referer are added as exceptions for spelling after this fix.
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-01-11 10:07:06 +01:00
MDW
b09f379bd6
Qual: spelling in html.form ( #27407 )
...
# Qual: Fix spelling in htdocs/core/class/html.form.class.php .
Most changes are in the text, and some translations made of comments.
is changed to , and var was unused.
'clas=tagd is changed to class=tagd', slight possibility of visual impact.
is changed to , but used locally in foreach loops.
2024-01-11 10:03:08 +01:00
MDW
d7fc7b408f
Qual: Spelling commonobject ( #27409 )
...
# Qual: Fix spelling in commonobject.class.php.
Most corrections are in comments.
Variable was changed to and is local to the file.
Some comments were translated.
Variable was changed to , used locally.
2024-01-11 10:00:48 +01:00
Laurent Destailleur
6b42b48d20
NEW Can generate the email selector file
2024-01-11 02:47:42 +01:00
Laurent Destailleur
2ec2b420cb
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2024-01-10 22:11:34 +01:00
Laurent Destailleur
c15627016a
Fix bad test for disabling TCPDI. Add more phpunit
2024-01-10 21:51:32 +01:00
Frédéric FRANCE
df1e20e7c5
fix phpstan ( #27402 )
2024-01-10 19:53:04 +01:00
Frédéric FRANCE
3de98eb936
fix phpstan ( #27401 )
2024-01-10 19:52:55 +01:00
Frédéric FRANCE
850a9f951d
fix phpstan ( #27400 )
2024-01-10 19:52:21 +01:00
Laurent Destailleur
f0d910ecd3
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-01-10 19:20:16 +01:00
MDW
da0bebc9ae
Fix: formmail - add_attached_files - argument name consistency ( #27338 )
...
# Fix: formmail - add_attached_files - argument name consistency
Phan determined suspicious naming as arg #2 to add_attached_files is while
that was the name for the first argument by the caller.
Also, on examination, only the first parameter is needed as add_attached_files
handles the other two in the same manner.
2024-01-10 16:56:40 +01:00
MDW
95da30a224
Fix: files.lib.php - Add optional sort parameter to array_multisort for static tool check ( #27340 )
...
# Fix: files.lib.php - Add optional sort parameter to array_multisort for static tool check
Phan flags the call to array_multisort as suspicious - adding the optional sort parameter
avoids this.
2024-01-10 16:41:39 +01:00
Laurent Destailleur
0a00afcad3
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-01-10 16:24:49 +01:00
Laurent Destailleur
e9205dcdb1
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-01-10 16:23:01 +01:00
Frédéric FRANCE
6bc40a5e26
fix duplicate ( #27389 )
2024-01-10 16:17:30 +01:00
David
82c93e6812
FIX: typo when adding height after custom header ( #27384 )
...
'extra_under_header_shift' instead of 'extra_under_address_shift'
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-01-10 15:40:36 +01:00
David
5ea1c977a5
FIX: typo when adding height after custom header ( #27384 )
...
'extra_under_header_shift' instead of 'extra_under_address_shift'
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-01-10 15:40:04 +01:00
Laurent Destailleur
d41c4d954b
Merge pull request #27341 from mdeweerd/fix/add_missing_argument_getOnlineSignature
...
Fix: Add missing argument in getOnlineSignatureUrl
2024-01-10 15:37:14 +01:00
Laurent Destailleur
75746ba90e
Merge pull request #27373 from mdeweerd/fix/remove_extra_arg_mod_codeclient_constructs
...
FIX: Update mod_codeclient_* constructor to have $db argument as in callers.
2024-01-10 15:33:55 +01:00
nat
c06166267e
FIX #27312
2024-01-10 15:32:24 +01:00
Laurent Destailleur
464bd14424
Merge pull request #27328 from nat-itopie/develop
...
FIX #27312
2024-01-10 15:31:31 +01:00
Laurent Destailleur
c8f3333408
Merge pull request #27327 from frederic34/patch-12
...
fix phpdoc
2024-01-10 15:27:30 +01:00
Frédéric FRANCE
7b45347b01
dol_compress_dir creates invalid zip with windoze
2024-01-10 15:20:12 +01:00
Laurent Destailleur
e37dc22aa7
Merge pull request #27347 from frederic34/patch-14
...
dol_compress_dir creates invalid zip with windoze
2024-01-10 15:19:48 +01:00
Laurent Destailleur
706fecb97f
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2024-01-10 15:16:12 +01:00
Laurent Destailleur
b418bc9e1e
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2024-01-10 15:14:11 +01:00
Laurent Destailleur
e770259b3f
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-01-10 15:12:50 +01:00
Laurent Destailleur
f3911bccc8
Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0
2024-01-10 15:11:40 +01:00
Laurent Destailleur
64eff062f2
Clean code
2024-01-10 15:10:15 +01:00
Laurent Destailleur
2c1e7a8381
Merge pull request #27339 from mdeweerd/optim/dol_mimetype
...
Perf: Optimise dol_mimetype
2024-01-10 15:05:01 +01:00
Laurent Destailleur
da56b40ab5
Merge pull request #27329 from thibdrev/thibdrev-patch-1
...
qual move the code used to validate a SIRET into profid.lib.php
2024-01-10 15:03:42 +01:00
Laurent Destailleur
f711144428
Try to move tmp dir
2024-01-10 14:52:12 +01:00
Laurent Destailleur
c636487965
Merge pull request #27357 from frederic34/patch-17
...
Method should return null but return statement is missing
2024-01-10 14:30:34 +01:00
Laurent Destailleur
342897bfc3
Merge pull request #27358 from frederic34/patch-18
...
Method should return int|null but return statement is missing
2024-01-10 14:30:26 +01:00
Laurent Destailleur
7cf20b9e8f
Merge pull request #27360 from frederic34/patch-20
...
Method should return int|null but return statement is missing.
2024-01-10 14:30:15 +01:00
Laurent Destailleur
38994fa9ec
Merge pull request #27359 from frederic34/patch-19
...
Method should return null but return statement is missing.
2024-01-10 14:30:05 +01:00
Laurent Destailleur
e0c8a652e9
Merge pull request #27322 from frederic34/cleanboxescode
...
clean code of boxes
2024-01-10 14:28:16 +01:00
MDW
9d2bc42ee3
FIX: Update mod_codeclient_* constructor to have $db argument as in callers.
...
None of the mod_codeclient_* constructors has an argument.
Reported by phan as `PhanParamTooMany: Call with 1 arg(s) to \mod_codeclient_leopard::__construct() which only takes 0 arg(s) defined at htdocs/core/modules/societe/mod_codeclient_leopard.php:69`
in all modified files.
One exception in the card.php file because the code has no explicit detail,
but it also uses a mod_codeclient_ constructor.
2024-01-10 14:06:40 +01:00
Laurent Destailleur
25eb8b3988
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2024-01-10 12:50:07 +01:00
Laurent Destailleur
a1aeb580a9
Enable the phpdocmissing return
2024-01-10 12:45:23 +01:00
Laurent Destailleur
1e5076634b
Merge pull request #27361 from frederic34/patch-22
...
Function should return string|null but return statement is missing.
2024-01-10 12:44:16 +01:00
Laurent Destailleur
19f2e055d5
Merge pull request #27363 from frederic34/patch-23
...
fix phpdoc
2024-01-10 12:39:54 +01:00
Laurent Destailleur
bcb3d92e15
Merge pull request #27364 from mdeweerd/fix/donotreuse_key_inforeach
...
Fix: Do not reuse $key from scope as foreach key
2024-01-10 12:39:38 +01:00
Laurent Destailleur
1b3ca6de0a
Merge pull request #27365 from frederic34/patch-24
...
fix parameters
2024-01-10 12:39:10 +01:00
Laurent Destailleur
565c4b7a8b
Merge pull request #27369 from mdeweerd/fix/pdf_typing_hint
...
Fix: Typing hint for PDF set to TCPDF
2024-01-10 12:37:11 +01:00
Laurent Destailleur
aa5451e6d9
Merge pull request #27370 from frederic34/patch-27
...
fix phpdoc
2024-01-10 12:29:35 +01:00
Laurent Destailleur
971308ea08
Fix colspan
2024-01-10 11:25:45 +01:00
Laurent Destailleur
203245bf95
Fix #yogosha19838
2024-01-09 21:37:53 +01:00
Frédéric FRANCE
2ae3ed0348
fix phpdoc
2024-01-09 21:34:49 +01:00
MDW
ed2f5cb2bf
Fix: Typing hint for PDF set to TCPDF
...
# Fix: Set typing hint to TCPDF (not PDF)
There is no PDF proxy class in the project, change to TCPDF
to help static tools.
2024-01-09 21:29:23 +01:00