2
0
forked from Wavyzz/dolibarr
Commit Graph

12838 Commits

Author SHA1 Message Date
MDW
58ba3e31fa Qual: Fix spelling for crypted and referer (#27408)
# Qual: Fix spelling for crypted and referer.

The proper spelling is encrypted and referrer, but the code has
some occurences where referer and crypted need to be maintained.

To make verification easier, this spelling correction is limited to
mostly these corrections and some minor translations and a only a
few other corrections.

crypted and referer are added as exceptions for spelling after this fix.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-11 10:07:06 +01:00
MDW
b09f379bd6 Qual: spelling in html.form (#27407)
# Qual: Fix spelling in htdocs/core/class/html.form.class.php .

Most changes are in the text, and some translations made of comments.

 is changed to , and var was unused.
'clas=tagd is changed to class=tagd', slight possibility of visual impact.
 is changed to , but used locally in foreach loops.
2024-01-11 10:03:08 +01:00
MDW
d7fc7b408f Qual: Spelling commonobject (#27409)
# Qual: Fix spelling in commonobject.class.php.

Most corrections are in comments.
Variable  was changed to  and is local to the file.
Some comments were translated.
Variable  was changed to , used locally.
2024-01-11 10:00:48 +01:00
Frédéric FRANCE
df1e20e7c5 fix phpstan (#27402) 2024-01-10 19:53:04 +01:00
Frédéric FRANCE
3de98eb936 fix phpstan (#27401) 2024-01-10 19:52:55 +01:00
Frédéric FRANCE
850a9f951d fix phpstan (#27400) 2024-01-10 19:52:21 +01:00
Laurent Destailleur
f0d910ecd3 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-10 19:20:16 +01:00
MDW
da0bebc9ae Fix: formmail - add_attached_files - argument name consistency (#27338)
# Fix: formmail - add_attached_files - argument name consistency

Phan determined suspicious naming as arg #2 to add_attached_files is  while
that was the name for the first argument by the caller.

Also, on examination, only the first parameter is needed as add_attached_files
handles the other two in the same manner.
2024-01-10 16:56:40 +01:00
Laurent Destailleur
0a00afcad3 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-10 16:24:49 +01:00
nat
c06166267e FIX #27312 2024-01-10 15:32:24 +01:00
Laurent Destailleur
464bd14424 Merge pull request #27328 from nat-itopie/develop
FIX #27312
2024-01-10 15:31:31 +01:00
Laurent Destailleur
b418bc9e1e Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-01-10 15:14:11 +01:00
Laurent Destailleur
e770259b3f Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-01-10 15:12:50 +01:00
Laurent Destailleur
f3911bccc8 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-01-10 15:11:40 +01:00
Laurent Destailleur
c636487965 Merge pull request #27357 from frederic34/patch-17
Method should return null but return statement is missing
2024-01-10 14:30:34 +01:00
Laurent Destailleur
342897bfc3 Merge pull request #27358 from frederic34/patch-18
Method should return int|null but return statement is missing
2024-01-10 14:30:26 +01:00
Laurent Destailleur
7cf20b9e8f Merge pull request #27360 from frederic34/patch-20
Method should return int|null but return statement is missing.
2024-01-10 14:30:15 +01:00
Laurent Destailleur
203245bf95 Fix #yogosha19838 2024-01-09 21:37:53 +01:00
Laurent Destailleur
3b54a23f5b Add test code 2024-01-09 19:22:05 +01:00
Frédéric FRANCE
615acae89f Method should return int|null but return statement is missing. 2024-01-09 18:56:07 +01:00
Frédéric FRANCE
cc48dd54dd Update html.formadmin.class.php 2024-01-09 18:49:58 +01:00
Frédéric FRANCE
2fa639d595 Method should return int|null but return statement is missing 2024-01-09 18:46:54 +01:00
Frédéric FRANCE
dc3564f84a Method should return null but return statement is missing 2024-01-09 18:41:50 +01:00
Laurent Destailleur
78601732d2 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-09 17:13:20 +01:00
Laurent Destailleur
cdf2e4408c Debug v19 2024-01-09 16:56:32 +01:00
Laurent Destailleur
910a541c60 Clean code 2024-01-09 13:08:22 +01:00
nat
8e5d8988c6 Update extrafields.class.php 2024-01-08 02:45:26 +01:00
nat
dde442ff6e FIX #27312 2024-01-08 02:36:15 +01:00
Laurent Destailleur
7cbc1c98fc Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-07 13:40:36 +01:00
Laurent Destailleur
bf17b8767c Debug v19 2024-01-07 11:15:48 +01:00
Laurent Destailleur
ec83939a81 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-06 22:34:03 +01:00
Laurent Destailleur
fc36553265 Fix #yogosha19809 2024-01-06 22:33:39 +01:00
Laurent Destailleur
27fc5a2f84 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-06 16:56:28 +01:00
Laurent Destailleur
76ee9e506d Debug v19 2024-01-06 16:43:01 +01:00
Laurent Destailleur
e8fa7aeebb Merge pull request #27304 from alexandre-janniaux/discount-commonobject/1
QUAL: DiscountAbsolute: inherit CommonObject to implement errorsToString
2024-01-05 18:42:32 +01:00
Alexandre Janniaux
e3e2dd348d discount: remove now duplicated fields
Now that DiscountAbsolute is a CommonObject, some fields are duplicated
in the definition of the class and already defined in the CommonObject
class.
2024-01-05 14:55:00 +01:00
Alexandre Janniaux
8cfb183152 discount: add errorsToString()
$localobject->errorsToString() is available in most objects using $db or
other systems generating errors because they inherit from CommonObject.
However, DiscountAbsolute didn't inherit from it.

Extending CommonObject allows to implement the usual behaviour for core
objects like referencing the user doing the action.
2024-01-05 14:54:55 +01:00
Laurent Destailleur
4501872f17 Clean code with rector 2 2024-01-05 04:33:58 +01:00
Laurent Destailleur
ccaae7ab24 Clean code 2024-01-05 03:41:22 +01:00
Laurent Destailleur
cabaf7aad4 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-04 15:27:12 +01:00
Laurent Destailleur
b5cdfd5190 Rename class file for pdf generation to match Dolibarr standard 2024-01-04 15:23:46 +01:00
Laurent Destailleur
0ea29a9252 Doxygen 2024-01-04 15:00:56 +01:00
Laurent Destailleur
1b660bddf0 Fix parameter type 2024-01-04 14:48:02 +01:00
Florian HENRY
053e0981ad fix: pregmatch all always return empty array, muxt be tested like in findHtmlImages 2024-01-04 11:49:10 +01:00
Florian HENRY
43fceaf468 fix: pregmatch all always return empty array, muxt be tested like in findHtmlImages 2024-01-04 11:47:43 +01:00
Laurent Destailleur
1d751e9838 Merge pull request #27106 from altairisfr/noprint
add noprint parameter to select_conditions_paiements
2024-01-04 00:32:51 +01:00
John BOTELLA
d4d89b6bfb fix warning php 8.2 2024-01-03 14:53:31 +01:00
Laurent Destailleur
f36d31f5f9 Merge pull request #27275 from frederic34/patch-3
undefined variable $user
2024-01-02 12:28:01 +01:00
Laurent Destailleur
696c901e62 Merge pull request #27253 from Hystepik/fix-phpstan-warnings
Fix html.form warnings
2024-01-02 12:27:40 +01:00
Frédéric FRANCE
041de86b68 undefined variable $user 2024-01-02 12:21:44 +01:00