# Fix $mybool |=... which is binary op, not boolean op
This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
# Fix: Repeat fields typing in CommonClass children
phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
* Verifcation of variables
Modification of the variable setting before its use.
* To check if the property exists
* Modification as per @frederic34 suggestion
* Update propal.class.php
* Application of coding rules
Modification of the called function.
* Verification of variables
* Verification of variable
* Typo error
* Update actions_sendmails.inc.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fix: Replace deprecated module names in code strings
# Fix: Replace deprecated module names in code strings
A few cases that slipped through the manual replacements
* Qual: Enable deprecation notices in CodingPhpTest for isModEnabled
# Qual: Enable deprecation notices in CodingPhpTest for isModEnabled
As all detections are now fixed, we can enable the deprecation notice
trigger in the CodingPhpTest.
* Fixes an error by initializing ->line in the insert_discount method.
* Update propal.class.php
---------
Co-authored-by: David IGREJA <david@siladel.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* qual: phpstan for htdocs/comm/propal/class/propal.class.php
htdocs/comm/propal/class/propal.class.php 75 Property Propal::$table_element_line (int) does not accept default value of type string.
htdocs/comm/propal/class/propal.class.php 1414 Property CommonObject::$fk_delivery_address (int) does not accept string.
htdocs/comm/propal/class/propal.class.php 1426 Property CommonObject::$fk_project (int) does not accept string.
htdocs/comm/propal/class/propal.class.php 1499 Property CommonObject::$user_author (User) does not accept int.
* Update propal.class.php
use $object->user_creation_id rather than $object->user_author
* Qual: Spelling fixes that newly appeared.
# Qual: Fix spelling erros that appeared since the bulk updates.
These issues mostly appeared since the bulk updates (a few ones were postponed
to make sure no real spelling errors were missed.)
* Update modulebuilder.lib.php
* Update pdf_standard.modules.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
