2
0
forked from Wavyzz/dolibarr
Commit Graph

5095 Commits

Author SHA1 Message Date
MDW
949ccf312a Force type to fix PhanNonClassMethodCall 2024-03-24 15:40:24 +01:00
MDW
359a2688ff Fix PhanTypeInvalid{Left,Right}OperandOfNumericOp mostly by typing, casting, idate 2024-03-23 02:06:29 +01:00
MDW
0c8eae7240 Fix PhanTypeInvalid{Left,Right}OperandOfNumericOp mostly by typing, casting, idate 2024-03-23 02:06:28 +01:00
Laurent Destailleur
51a3641105 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	htdocs/bom/tpl/objectline_create.tpl.php
	htdocs/compta/bank/releve.php
	htdocs/core/class/html.formsetup.class.php
	htdocs/takepos/freezone.php
2024-03-22 02:35:37 +01:00
Laurent Destailleur
b658bde88a Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
Conflicts:
	htdocs/core/class/html.formsetup.class.php
	htdocs/takepos/index.php
2024-03-22 02:11:58 +01:00
Laurent Destailleur
7b0177a84d Move to getDolGlobalString 2024-03-22 00:37:56 +01:00
MDW
ecf24fd3b4 Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:06 +01:00
MDW
aeefca7e7e Fix $arrayfields typing lost by dol_sort_array() by forcing the type 2024-03-20 23:29:48 +01:00
Laurent Destailleur
0191993a16 FIX Selection of line to copy 2024-03-20 19:41:44 +01:00
MDW
34eb7c288a Fix arg type to preg_match(),abs(),trim() with cast 2024-03-20 04:08:34 +01:00
MDW
991ce81f93 Fix arg type to preg_match() and preg_replace() with cast 2024-03-20 04:08:34 +01:00
MDW
3812be38fe Fix arg type to abs() and preg_replace() with cast 2024-03-20 04:08:33 +01:00
MDW
4c3faabf3c Fix arg type to preg_replace() with cast 2024-03-20 04:08:32 +01:00
MDW
6eacf10d67 Fix arg type to preg_match with cast to string 2024-03-19 20:37:40 +01:00
Laurent Destailleur
10e3627c59 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-19 18:14:07 +01:00
Laurent Destailleur
e9e2105508 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	htdocs/accountancy/class/bookkeeping.class.php
	htdocs/core/class/CMailFile.class.php
	htdocs/core/lib/functions.lib.php
	htdocs/ticket/class/ticket.class.php
2024-03-19 18:12:13 +01:00
Laurent Destailleur
43a3f449c4 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-19 17:07:51 +01:00
ATM-Lucas
6f85a989f0 Condition on newDateLimReglement 2024-03-19 14:59:13 +01:00
MDW
4c5ceace40 Fix type of argument for round 2024-03-19 02:59:01 +01:00
MDW
fd9d48faac Fix phpstan CommonObject->fields - notnull is optional field 2024-03-19 00:32:00 +01:00
Laurent Destailleur
a956539b09 Merge pull request #28937 from mdeweerd/fix/PhanUndeclaredVariableAssignOp
Fix & enable PhanUndeclaredVariableAssignOp
2024-03-18 14:37:34 +01:00
Laurent Destailleur
3368041587 Fix filter 2024-03-18 14:04:10 +01:00
MDW
ef6b594001 Fix: Initilialise $amount_ttc_diff to fix PhanUndeclaredVariableAssignOp 2024-03-18 12:19:28 +01:00
Laurent Destailleur
de58435ef1 FIX: if we stop for security purpose, we must exit a non zero value. 2024-03-16 23:08:15 +01:00
MDW
13ab939691 Fix deprecated function calls 2024-03-16 13:27:51 +01:00
Laurent Destailleur
e15f243e95 Clean code - Remove a deprecated tag that should not exists. 2024-03-16 11:51:32 +01:00
Laurent Destailleur
e994d6650f Fix regression in GETPOST limit 2024-03-16 11:41:00 +01:00
Laurent Destailleur
79aa9fb1f1 Code simpler 2024-03-15 20:29:21 +01:00
Laurent Destailleur
80e2e59373 Merge pull request #28862 from mdeweerd/fix/PhanTypeMismatchPropertyDefault
Fix & enable PhanTypeMismatchPropertyDefault
2024-03-15 09:33:40 +01:00
Frédéric FRANCE
62c0df13ca Merge branch 'develop' into fixwarningsf 2024-03-15 09:03:21 +01:00
Laurent Destailleur
e238cc204e Merge pull request #28750 from mdeweerd/fix/PhanPluginSuspiciousParamPosition
Fix: Resolve several PhanPluginSuspiciousParamPosition cases
2024-03-15 08:45:25 +01:00
Frédéric France
b1ce17dd4e fix warning 2024-03-15 08:09:50 +01:00
Frédéric France
cca4bef00b fix warning 2024-03-15 08:06:27 +01:00
MDW
23785393a3 Add csslist to json keys 2024-03-15 03:55:52 +01:00
MDW
e7fde26b0f Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:44:47 +01:00
MDW
b7b05d4d49 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:44:46 +01:00
MDW
3b0d19a160 Fix unneed test 'X ? Y : Y' by assigning '' to note_private 2024-03-14 19:47:10 +01:00
MDW
3874830fc0 Fix PhanPluginSuspiciousParamPosition by renaming arg (local assign) 2024-03-14 19:39:41 +01:00
MDW
715b5ef38e Fix PhanPluginSuspiciousParamPosition by renaming arg (local assign) 2024-03-14 19:39:40 +01:00
Laurent Destailleur
c867bc2706 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-13 22:36:45 +01:00
Laurent Destailleur
8bfc0779c4 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-13 22:20:08 +01:00
Laurent Destailleur
a0b26ae7cd FIX Amount of localtaxes in foreign currency was wrong on screen and PDF 2024-03-13 22:04:44 +01:00
Laurent Destailleur
cad8f24322 Merge pull request #28799 from mdeweerd/fix/PhanPluginDuplicateExpressionAssignmentOperation
Fix & enable PhanPluginDuplicateExpressionAssignment
2024-03-13 14:49:21 +01:00
MDW
9ee7611a08 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:38 +01:00
MDW
ca8ccd84f0 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:37 +01:00
MDW
944ba8a4c0 Fix PhanPluginDuplicateExpressionAssignment (NOOP assignment) 2024-03-12 22:25:33 +01:00
MDW
d8c7aad698 Fix PhanPluginMixedKeyNoKey by using explicit keys 2024-03-12 21:35:45 +01:00
MDW
6a64b3a50f Fix duplicate if condition with same effect 2024-03-12 19:10:50 +01:00
Laurent Destailleur
74b8162d22 Merge pull request #28700 from mdeweerd/urlencode/fixuptype
Fix: Ensure the argument type for urlencode is string
2024-03-12 14:43:41 +01:00
MDW
88d59896ec Qual: 'enabled' in fields can be string ('isModEnabled(...)')
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')

Update PHPdoc to allow that enabled is a string
2024-03-12 13:38:08 +01:00