2
0
forked from Wavyzz/dolibarr
Commit Graph

196 Commits

Author SHA1 Message Date
MDW
effe9e79b5 Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:23 +01:00
Laurent Destailleur
e6b2756c19 QUAL The signature for all ->delete() method has been modified to match
the modulebuilder template (so first param is now always $user), except
  the delete for thirdparty (still accept the id of thirdparty to delete
as first parameter). Will probably be modified into another version.
2024-03-07 17:58:02 +01:00
Frédéric FRANCE
fba15178eb all initAsSpecimen return int (#28577)
* all initAsSpecimen return int

* all initAsSpecimen return int

* all initAsSpecimen return int
2024-03-02 16:38:35 +01:00
thibdrev
b4f9038710 qual: phpstan for htdocs/fourn/class/paiementfourn.class.php (#28066)
htdocs/fourn/class/paiementfourn.class.php	412	Property Paiement::$amount (float) does not accept string.
htdocs/fourn/class/paiementfourn.class.php	414	Property Paiement::$multicurrency_amount (float) does not accept string.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-08 00:18:31 +01:00
Laurent Destailleur
ce21af7b6c Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-23 22:17:46 +01:00
Laurent Destailleur
cca01cbda4 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-01-23 22:15:36 +01:00
Laurent Destailleur
b05d1c5f6e Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-01-23 22:03:28 +01:00
Laurent Destailleur
f5b6b8ece9 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 17.0 2024-01-23 21:33:52 +01:00
atm-lena
6f0a91856f Missing Translations 2024-01-22 12:42:34 +01:00
Frédéric France
03e29c6960 fix param 2024-01-20 09:22:38 +01:00
MDW
bd002480ce Qual: Spelling htdocs/[d-k]* (#27427)
Highlights:

- htdocs/install/doctemplates/websites/website_template-restaurant/containers/page249.tpl.php

  Potential functional change (fix) because toekn was changed to token:
   `<input type=hidden name=toekn`

- htdocs/install/upgrade2.php
  $filles changed to $children

- htdocs/intracommreport/class/intracommreport.class.php
  Local $enveloppe changed to $envelope.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-13 19:48:41 +01:00
Laurent Destailleur
4501872f17 Clean code with rector 2 2024-01-05 04:33:58 +01:00
Laurent Destailleur
b28ae5d8d3 Clean code 2023-12-27 12:12:20 +01:00
Frédéric FRANCE
8d39f4c149 fix default value 2023-12-16 11:07:09 +01:00
Frédéric FRANCE
61b79fda17 avoid phpstan error with phpdoc 2023-12-06 15:46:39 +01:00
Laurent Destailleur
a7125280bc Fix with php-cs-fixer 2023-12-04 12:12:12 +01:00
Laurent Destailleur
386c91790a Fix warning 2023-12-03 20:32:08 +01:00
Frédéric FRANCE
53c8a3acf8 clean phpdoc for phpstan (#26905) 2023-12-01 19:51:32 +01:00
Laurent Destailleur
e1f3765f16 Debug v19 2023-12-01 11:41:48 +01:00
Laurent Destailleur
56e8872ddc Clean code+warnings: The delete() method of AdherentType, Contact,
Delivery, MultiCurrency, CurrencyRate now need $user as first parameter.
2023-11-28 15:33:42 +01:00
Laurent Destailleur
7785ae93a1 Fix php8.2 warnings 2023-11-27 11:41:05 +01:00
Laurent Destailleur
a0bba05b02 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	htdocs/commande/class/api_orders.class.php
	htdocs/compta/facture/card.php
	htdocs/core/lib/functions.lib.php
	htdocs/core/lib/project.lib.php
	htdocs/fourn/class/api_supplier_orders.class.php
	htdocs/fourn/class/fournisseur.facture-rec.class.php
	htdocs/langs/en_US/stocks.lang
2023-11-17 18:24:53 +01:00
thibdrev
1ba7d135e0 delete method isReconciled() because it is now inherited (#26591) 2023-11-14 14:29:25 +01:00
Laurent Destailleur
c6c7b6692d Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-11-13 15:33:32 +01:00
thibdrev
86bad02b9d FIX #26553 Supplier invoice - Do not display the delete button for reconciled payment (#26554)
* do not display delete button if payment is reconciled

* add isReconciled() function

* phpcs fix: replace spaces by tab

* phpcs fix: Whitespace found at end of line

* phpcs
2023-11-12 23:41:59 +01:00
Laurent Destailleur
a318031034 QUAL Standardize code. Renamed ID of user properties into ->user_xxx_id 2023-10-24 11:37:29 +02:00
Pascal Hubrecht
0628dd057d FIX #26291 (#26292) 2023-10-20 12:53:03 +02:00
Ferran Marcet
6791a99527 Fix: Not loading thirdparty on supplier payment (#26235) 2023-10-17 15:44:57 +02:00
Laurent Destailleur
4f4ede2e32 Fix php8.2 warnings 2023-10-15 18:14:14 +02:00
Dev2a
fcd4c4e429 Fix: Change access to $conf->global to function getDolGlobal (automatique) 2023-10-08 23:19:49 +02:00
Laurent Destailleur
df76b9940d Debug v18 2023-08-05 13:27:56 +02:00
Didier 'OdyX' Raboud
f653f5c96c Fix multicurrency payments' currency quoting
PostgreSQL imposes single-quoting around strings; double-quotes cast to column names

Fixes a0d9419be5
2023-05-29 09:03:18 +02:00
Laurent Destailleur
4c09bd3e8d Merge pull request #24395 from SylvainLegrand/Improve_multicurrency_payments
Improve multicurrency payments
2023-05-21 02:40:39 +02:00
Laurent Destailleur
a4a014cfd5 Clean libelle into label 2023-04-08 15:08:55 +02:00
BadPixxel
57156dd022 FIX: Invoice Thirdparty never loaded at this point
Attempt to read property "default_lang" on null in /var/www/html/fourn/class/paiementfourn.class.php on line 353
2023-03-31 13:15:44 +02:00
Sylvain Legrand
a0d9419be5 Improve multicurrency payments 2023-03-30 19:06:47 +02:00
Laurent Destailleur
ec7627572f Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-03-27 18:32:25 +02:00
priojk
f693822d15 Stikler whitespace 2023-03-24 14:03:19 +01:00
priojk
3603952301 add hooks to customize automatic closing of invoices (e.g. cash discount) 2023-03-24 13:43:49 +01:00
FLIO
cd289ca8ac fix(qodana) fix function comment wrong return 2023-02-08 19:09:05 +01:00
Philippe GRAND
bb13074488 update code toward php8 compliance 2022-09-24 14:49:47 +02:00
Philippe GRAND
3737a85470 Update code 2022-09-03 11:25:51 +02:00
Frédéric France
e78f9a56be use isModEnabled 2022-08-23 20:16:28 +02:00
Philippe GRAND
dcb61e05f4 fix : The property num_prelevement does not seem to exist on PaiementFourn 2022-05-21 23:25:59 +02:00
Philippe GRAND
10c5ccb5bf fix : The property id_prelevement does not seem to exist on PaiementFourn 2022-05-21 23:19:52 +02:00
Laurent Destailleur
cb15a21e41 Merge branch '15.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	htdocs/core/class/commonobject.class.php
	htdocs/core/tpl/originproductline.tpl.php
	htdocs/fourn/facture/card.php
	htdocs/install/mysql/migration/14.0.0-15.0.0.sql
	htdocs/user/card.php
2022-04-11 21:22:27 +02:00
Laurent Destailleur
d6860ca41b FIX bad bank amount in accounting with multicurrency 2022-04-09 02:22:45 +02:00
Laurent Destailleur
eecbc05bc3 Show amount into popup of payment 2022-04-09 00:06:02 +02:00
Frédéric FRANCE
935482ee22 uniformize 2022-02-15 19:04:18 +01:00
Frédéric FRANCE
a613553f37 Merge branch 'hookgetnomurl' into patch-1 2022-02-15 18:44:06 +01:00