2
0
forked from Wavyzz/dolibarr
Commit Graph

224 Commits

Author SHA1 Message Date
Laurent Destailleur
6358f89c0d Fix phan warnings 2024-04-28 17:10:51 +02:00
MDW
bc5e5b67af Qual: Update phan baseline (#29300)
* Qual: Update phan baseline

* Init variable to ensure it is defined

* Init $module_part to ensure it is defined

* Init $modulepart to ensure it is defined

* phpdoc typing for getNetNeeds and getNetNeedsTree

* Enforce type for phan

* Initialise  $massactionbutton so that it is defined

* phpdoc: improve typing

* Encore character_set value is string (for typing)

* fixup! Qual: Update phan baseline

* Fix duplicate code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-12 01:06:52 +02:00
Laurent Destailleur
c87f24e3f4 Fix mysqli 2024-03-29 17:09:36 +01:00
Laurent Destailleur
ce274c403e Depreciate a method usage 2024-03-23 19:06:54 +01:00
Laurent Destailleur
7290ffd1ab Better support for postgesql 2024-03-21 15:57:45 +01:00
Laurent Destailleur
a6d5b32c2e Merge branch 'develop' into qual/db/typing 2024-03-21 14:13:58 +01:00
Laurent Destailleur
2d0e57ce7c Fix test for pgsql 2024-03-21 14:13:17 +01:00
Laurent Destailleur
8ab80490e6 Merge branch 'develop' into qual/db/typing 2024-03-21 13:57:13 +01:00
Laurent Destailleur
477fb7a035 Fix warning 2024-03-21 13:55:23 +01:00
Laurent Destailleur
0d6675114e Merge branch 'develop' into qual/db/typing 2024-03-21 13:19:51 +01:00
Laurent Destailleur
380c1092eb Fix warnings 2024-03-21 13:19:31 +01:00
Laurent Destailleur
e97f0a7668 Merge branch 'develop' into qual/db/typing 2024-03-21 13:06:35 +01:00
Laurent Destailleur
aee4ccc32c Fix warnings 2024-03-21 13:06:20 +01:00
Laurent Destailleur
9d5aa4a448 Fix sanitization 2024-03-21 13:02:41 +01:00
Laurent Destailleur
04d8a20b63 Merge branch 'develop' into qual/db/typing 2024-03-21 12:46:25 +01:00
Laurent Destailleur
aa77573cd9 Sanitize DDL instructions 2024-03-21 12:45:58 +01:00
Laurent Destailleur
171c32be34 Add DDLDropTable and DDLCreateTable into phpunit tests 2024-03-21 12:21:38 +01:00
Laurent Destailleur
ce2959b022 Clean method DDLCreateTable (used by modulebuilder only) #28996 2024-03-21 12:10:09 +01:00
Laurent Destailleur
27c0192b7c cast smallint 2024-03-21 11:17:15 +01:00
MDW
fc6af20479 Update typing for database functions 2024-03-21 00:00:00 +01:00
Laurent Destailleur
06ae1deb1b Fix better error message when using bad character_set_client 2024-03-18 17:27:06 +01:00
MDW
dbfb1180ee Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions (#28749)
# Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions

Fix occurences of PhanPluginDuplicateIfStatements which are if statements where the
consecutive branches execute the same code, making it useles to test the condition
2024-03-11 12:58:51 +01:00
MDW
6d9e7b8144 Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal (#28732)
* Fix: False positive for PhanTypeMismatchArgumentInternalProbablyReal

* Qual: phan: suppress false positive on ssl_set

* Qual: Enable PhanTypeMismatchArgumentInternalProbablyReal

# Qual: Enable PhanTypeMismatchArgumentInternalProbablyReal

PhanTypeMismatchArgumentInternalProbablyReal are fixed and reporting can
be enabled.

* Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal by improving typing

* Qual: Rewrite/optimize to fix PhanTypeMismatchArgumentInternalProbablyReal

# Qual: Rewrite/optimize to fix PhanTypeMismatchArgumentInternalProbablyReal

False positive detecting that  is not an int, rewriting to check
impact
2024-03-10 01:55:56 +01:00
thibdrev
cc5366249a qual: phpdoc for htdocs/core/db/mysqli.class.php (#28703)
PHPDoc update to reflect what the code does today.

This update however doesn't solve this PHPStan warning:
htdocs/core/db/mysqli.class.php	243	Return type (mysqli|null) of method DoliDBMysqli::connect() should be compatible with return type (resource) of method Database::connect()
2024-03-08 12:10:09 +01:00
MDW
eb1f6be1e2 Qual: Add information from backtrace when mysql request fails. (#28583)
# Qual: Add information from backtrace when mysql request fails.

This helps locate the line that was responsible for the SQL request
2024-03-02 19:57:59 +01:00
MDW
8655d5a86b QUAL Use phan to help detect new issues (#27706)
* Qual: Add phan flow

- Add phan configuration (config, baseline, stubs);
- Add github action;
- Update apstats.php.

* Add directives to ignore false phan notices

* Qual: Add typing hints for extrafields TPL files

# Qual: Add typing hints for extrafields TPL files

Add typing hints for phan on view files

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-21 18:14:29 +01:00
Frédéric France
03e29c6960 fix param 2024-01-20 09:22:38 +01:00
MDW
b4b0cdf105 Fix: Deprecated mysqli::init() in PHP8.1
# Fix: Deprecated mysqli::init() in PHP8.1

See https://www.php.net/manual/en/migration81.deprecated.php#migration81.deprecated.mysqli
2024-01-18 22:04:19 +01:00
MDW
89004f7e03 Qual: Spelling htdocs/core (#27491)
Highlights:
- initialY in pdf_standard.modules.php was unused
  - remove (otherwise -> initially) (+same in other file)
2024-01-13 19:48:20 +01:00
Laurent Destailleur
8874ef8454 Debug v19 2023-12-23 18:47:38 +01:00
Frédéric FRANCE
61b79fda17 avoid phpstan error with phpdoc 2023-12-06 15:46:39 +01:00
Frédéric FRANCE
53c8a3acf8 clean phpdoc for phpstan (#26905) 2023-12-01 19:51:32 +01:00
Laurent Destailleur
553776a77a Enhance error message when set character set failed 2023-10-05 12:58:44 +02:00
Laurent Destailleur
00609fb6c7 FIX Warning 2023-09-14 15:31:05 +02:00
Laurent Destailleur
630e305161 Standardize db drivers. No more static class. 2023-08-04 04:18:59 +02:00
Laurent Destailleur
6a962cbefa Debug v19 2023-08-01 17:06:22 +02:00
Olivier Lesueur
4a14ba2083 Use SSL connection to MySQL server if server name starts with ssl:// (#25525)
* Use SSL connection to MySQL server if server name starts with ssl://

* Update mysqli.class.php

---------

Co-authored-by: Olivier Lesueur <o.lesueur@crm.fnattp.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2023-08-01 16:58:32 +02:00
Laurent Destailleur
ec39199b85 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0
Conflicts:
	.travis.yml
	htdocs/api/class/api_documents.class.php
	htdocs/core/db/pgsql.class.php
2023-07-26 01:42:22 +02:00
Laurent Destailleur
8e94ea0504 Fix warning 2023-07-26 00:01:45 +02:00
Laurent Destailleur
738f58f46f Add protection when mysqli not available 2023-05-14 02:05:35 +02:00
Frédéric FRANCE
163bd91ebe Update mysqli.class.php 2023-04-20 18:53:04 +02:00
Frédéric FRANCE
9ae24a0369 fix bad edit 😳 2023-04-20 18:46:40 +02:00
Frédéric FRANCE
c6aa069705 Fix 😍 in dolibarr when using utf8mb4 2023-04-20 18:32:09 +02:00
Laurent Destailleur
a30242eadc Merge pull request #24507 from frederic34/repair_script
NEW repair script skip views
2023-04-18 17:24:52 +02:00
Laurent Destailleur
f02ff3f774 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-04-15 02:29:01 +02:00
Laurent Destailleur
f425bd4654 Fix sqlforlike when searching with like and _ string 2023-04-15 01:24:50 +02:00
Frédéric FRANCE
834cb83047 NEW repair script skip views 2023-04-14 10:06:10 +02:00
Laurent Destailleur
32d3a3190e Fix warning 2023-03-22 17:13:27 +01:00
Laurent Destailleur
5c6d0bc26f Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-01-30 03:01:13 +01:00
Laurent Destailleur
1bbcd3c403 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 17.0 2023-01-30 02:29:43 +01:00