2
0
forked from Wavyzz/dolibarr
Commit Graph

3833 Commits

Author SHA1 Message Date
Laurent Destailleur
2a39e9edca Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-26 15:56:30 +02:00
MDW
0ac595364b Qual: Fix phan/phpstan notices in class files (part 1) (#31501)
* Ignore phpstan configuration for spelling

* Qual: Fix phan notices in class files
2024-10-25 21:00:02 +02:00
Laurent Destailleur
405a741726 Fix doxygen 2024-10-25 14:30:51 +02:00
Alexandre SPANGARO
3e9068c1c6 FIX Accountancy - Loan - Error on transfer (#31546) 2024-10-25 13:42:46 +02:00
Alexandre Janniaux
0bdd209d06 QUAL: AccountancySystem: maintenance work to uniformize and clean up (#31391)
* accountancysystem: inherit CommonObject

This provides the common methods on the database objects like error
handling.

* accountancysystem: improve error reporting

Forward the database error to the caller when an error happens.

* accountancysystem: clean up class

The fields that were completely unused are removed. $ref is still kept
since it was filled by AccountancySystem::fetch(), but marqued as
deprecated to incite using the newer more descriptive pcg_version field.

* Update accountancysystem.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-19 03:37:44 +02:00
kkhelifa-opendsi
90a545637e NEW : Add hook after the line is processed in the sell journal page (#31439) 2024-10-19 01:38:36 +02:00
Alexandre Janniaux
4146c0df89 accountancysystem: fix object create() method (#31390)
The accountancysystem::create() method is not used in the code, and thus
was not updated, especially after the introduction of the whole new
accountancy system. The method is at least useful for the tests so fix
it to create values like in every other tests.
2024-10-14 16:50:32 +02:00
Alexandre SPANGARO
4a91c2c734 NEW Accountancy - Add general account on thirdparty - Code supplier part (#31318)
* NEW Accountancy - Add general account on thirdparty - SQL Part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* Fix Phan

* Use isModEnabled

* NEW Accountancy - Add general account on thirdparty - Code supplier part

* Fix phan

* Fix phan

* Fix phan

* Use list of account instead of  simple input

* Use list of account instead of simple input

* Tabs

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-14 12:05:07 +02:00
MDW
53cfbc35be Qual: Fix several phan & stan notices (#31308)
* Qual: Fix several phan & stan notices

# Qual: Fix several phan & stan notices

Several fixes in files while fixing UnknownClass notices

* Qual: Update prepare_head PHPDoc return types

# Qual: Update prepare_head PHPDoc return types

Provide detailed array return types for prepare_head functions.

* Fix new phan notice

* Better loadLangs typing and fix call to loadLangs

* Fix new issues (stats)

* Other fixes of new issues

* Qual: update phan baseline
2024-10-14 01:59:44 +02:00
Alexandre SPANGARO
c4409e44f9 QUAL Use table_element in sql querries (#31355)
* Use table element in sql querries

* Use table element in sql querries

* Use also $this->db->prefix()

* Use table_element in sql querries
2024-10-13 16:47:47 +02:00
Alexandre SPANGARO
6fe1adec7d NEW Accountancy - Add general account on thirdparty - Code customer part (#31294)
* NEW Accountancy - Add general account on thirdparty - SQL Part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* Fix Phan

* Use isModEnabled

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-09 01:51:12 +02:00
Alexandre SPANGARO
dfa1a5dd6e NEW Accountancy - Option to select the label operation (#31200)
* NEW Accountancy - Option to select the label operation

* NEW Accountancy - Option to select the label operation

* NEW Accountancy - Option to select the label operation

* NEW Accountancy - Option to select the label operation

* Fix codespell

* Fix CodeSniffer

* Fix Phan

* Some fix

* User function csvClean

* User function csvClean
2024-10-06 14:06:20 +02:00
MDW
f70c945931 Qual: Fix phan/stan notices (#31271)
# Qual: Fix phan/stan notices in relation with UnknownObjectMethodCall

Fix notices in classes with UnknownObjectMethodCall notices or classes
related with these.
2024-10-05 18:55:36 +02:00
thomas-Ngr
88879e0708 Add triggers on Bookkeeping class (#31204) 2024-10-03 20:52:39 +02:00
MDW
2d0b1de36f Qual: Add codespell entries to catch some css typos (#31222)
# Qual: Add codespell entries to catch some css typos

Added some codespell entries based on the observed typos in css
tags
2024-10-03 19:36:59 +02:00
Frédéric FRANCE
e07c04c62d fix precommit (#31235) 2024-10-03 16:07:23 +02:00
Laurent Destailleur
2c518be378 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-30 20:10:47 +02:00
Francis Appels
f101423901 FIX State dropdown is not working on User card #31198 (#31205)
* FIX State dropdown is not working on User card #31198

* Fix phan
2024-09-30 16:50:54 +02:00
Laurent Destailleur
7eb375d398 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-30 16:21:37 +02:00
Laurent Destailleur
afc77a5bca Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-30 14:04:49 +02:00
Laurent Destailleur
fde37d8172 Fix deadlock situation by adding a constant in hope to save user 2024-09-30 13:36:30 +02:00
Laurent Destailleur
91fe8213fa Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-30 13:26:43 +02:00
Laurent Destailleur
946726779c Fix test on setup 2024-09-30 13:23:04 +02:00
Laurent Destailleur
7b61965042 FIX autoselect the fiscal period by default 2024-09-30 13:19:39 +02:00
Laurent Destailleur
d2a279cc7d FIX autoselect the fiscal period by default 2024-09-30 13:13:15 +02:00
Laurent Destailleur
2d62400b22 FIX autoselect the fiscal period by default 2024-09-30 13:12:42 +02:00
Laurent Destailleur
218bfff6fa Tooltip to explain why button is disabled. 2024-09-30 11:55:32 +02:00
Laurent Destailleur
d7d8f87045 Clean code. Add permission test after action = something. 2024-09-30 11:38:29 +02:00
Laurent Destailleur
61e8382869 Fix SERVICE_ARE_ECOMMERCE_200238EC #31159 in transfer of sale journal 2024-09-30 10:46:51 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
Laurent Destailleur
fbc5dd4822 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-26 19:36:09 +02:00
Frédéric FRANCE
184589dbc0 fix phan branch 20.0 (#31133)
* fix phan branch 20.0

* Update index.php
2024-09-26 17:18:55 +02:00
Laurent Destailleur
ae2ceccc5b Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-26 03:44:09 +02:00
Laurent Destailleur
b32225283d Merge branch '20.0' of github.com:Dolibarr/dolibarr into develop 2024-09-25 22:32:36 +02:00
Frédéric FRANCE
a94cff63a7 fix phpstan (#31102)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-25 22:21:31 +02:00
Frédéric FRANCE
4b4d629b71 fix phan for branch 20.0 (#31105)
* fix phan

* Update card.php

* Update card.php

* Update main.lang

* Update card.php

* Update card.php
2024-09-25 22:17:40 +02:00
Laurent Destailleur
09d4c1f3b8 NEW Add tooltip on closing accounting setup 2024-09-25 20:22:19 +02:00
Laurent Destailleur
e8c45ace3b Clean code 2024-09-25 19:30:37 +02:00
Laurent Destailleur
59dadd88a3 FIX Duplicate trigger printFieldPreListTitle 2024-09-25 13:43:11 +02:00
Laurent Destailleur
ef5f56ddf4 Fix avoid sql error 2024-09-25 01:10:45 +02:00
Laurent Destailleur
7ff3d7356d FIX accounting transfer when nb of lines is not zero but amount is zero 2024-09-24 11:54:09 +02:00
Laurent Destailleur
ceee0a9885 Fix look and feel 2024-09-24 11:53:55 +02:00
Laurent Destailleur
37e5bd6ff8 FIX accounting transfer when nb of lines is not zero but amount is zero 2024-09-24 11:43:31 +02:00
Laurent Destailleur
bfa57f8dc6 Fix look and feel 2024-09-24 10:54:12 +02:00
Laurent Destailleur
7c41effbf4 Tooltip 2024-09-24 10:28:33 +02:00
Laurent Destailleur
cc95331fc6 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-23 22:09:24 +02:00
Laurent Destailleur
0f5e5e1e5b FIX Maxi debug edit/delete accounting transaction 2024-09-23 21:42:52 +02:00
Laurent Destailleur
33da02bbcd FIX Maxi debug edit/delete accounting tnasaction 2024-09-23 20:16:39 +02:00
Frédéric FRANCE
000173c7b9 fix phpstan (#31075)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-23 01:59:14 +02:00
kkhelifa-opendsi
c00650c403 NEW: Add hook on sell journal page for overwrite the processed journal data after the SQL request (#31033) 2024-09-20 01:41:40 +02:00