2
0
forked from Wavyzz/dolibarr
Commit Graph

786 Commits

Author SHA1 Message Date
Laurent Destailleur (aka Eldy)
10698ebf2a Doc 2024-12-13 14:13:17 +01:00
MDW
ec2a1928ba Qual: Update fields phpdoc to include fields that are defined/used in some cases
# Qual: Update fields phpdoc to include fields that are defined/used in some cases

comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
2024-12-05 02:36:50 +01:00
Laurent Destailleur (aka Eldy)
4e6d3217bc Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-12-02 01:58:06 +01:00
Laurent Destailleur (aka Eldy)
3284f21e91 Fix remind for expired membership ko when date of renewal does not end
with 00:00:00
2024-12-02 01:30:13 +01:00
David Beniamine
d2d592ebd6 Make sure that thirdparty is actually loaded before using it's country for lang (#32107) 2024-11-27 22:03:41 +01:00
Laurent Destailleur (aka Eldy)
353633cef8 Revert to use instead #32123 2024-11-27 21:59:20 +01:00
Laurent Destailleur (aka Eldy)
13ad68d8bf Try fix phan phpstan 2024-11-27 21:46:16 +01:00
Laurent Destailleur (aka Eldy)
6eb8870992 Test 2024-11-27 21:35:48 +01:00
Laurent Destailleur (aka Eldy)
c1d6e0411c Test 2024-11-27 21:31:14 +01:00
Laurent Destailleur (aka Eldy)
a6e8fbc899 Test 2024-11-27 21:26:23 +01:00
Laurent Destailleur (aka Eldy)
fbb4c3d025 Try to fix phan 2024-11-27 21:12:35 +01:00
Laurent Destailleur
dbba584dfb Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-11-22 09:19:12 +01:00
Frédéric FRANCE
75400611e1 fix phpstan (#32040)
* fix phpstan

* fix

* fix

* fix

* fix

* fix

* fix
2024-11-21 22:36:00 +01:00
Frédéric FRANCE
57d121664f set object entity at create (#32019)
* set object entity at create

* set object entity at create

* set object entity at create

* set object entity at create

* set object entity at create

* set object entity at create

* do not break multicompany thing

* do not break multicompany thing

* missing translation

* fix phpstan

* doc

* fix entity

* fix set entity
2024-11-21 19:11:32 +01:00
Frédéric FRANCE
943d10c60a fix phpstan and CI (#31969)
* fix phpstan

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline
2024-11-18 15:10:29 +01:00
Anthony Damhet
185c703c64 NEW Reminder Mail by Adherent Type (#30142)
* Reminder Mail by Adherent Type

In order to restrict the sending of emails only to this type of member

* String to Int

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-13 23:15:52 +01:00
iLLixM
3b0ccddaea set payment method information on new membership subscriptions (#31750)
When creating new membership subscriptions and choosing to create an invoice (for linked thirdparty), existing payment method information of the customer should be used.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-12 03:37:48 +01:00
iLLixM
08714ea39b New: set bank account information to invoice on new membership subscriptions (#31688)
* set bank account information on new membership subscriptions

When creating new membership subscriptions and choosing to create an invoice, existing bank account information should be used.

* (fix phpstan) set bank account on new membership subscriptions

set bank account information on new membership subscriptions

When creating new membership subscriptions and choosing to create an invoice, existing bank account information should be used. Added
2024-11-05 15:26:38 +01:00
Frédéric FRANCE
1adc883b56 add baseline exclude for phpstan (#31632)
* add baseline exclude for phpstan

* update

* update

* update

* update

* update

* merge

* restore one filter

* delete old errors

* fix

* fix

* fix

* $moreforfilter can t be empty

* fix

* enable check

* refresh baseline

* add phpdoc

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 23:53:20 +01:00
Laurent Destailleur
ff4344d5c8 Clean code 2024-10-24 01:12:58 +02:00
Frédéric FRANCE
0e1292e253 fix phpstan (#31177)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-29 02:49:34 +02:00
Laurent Destailleur
e8c45ace3b Clean code 2024-09-25 19:30:37 +02:00
MDW
5e02bec9df Qual: Fix getTooltipContentArray typing hints (#31081)
* Qual: Fix getTooltipContentArray typing hints

# Qual: Fix getTooltipContentArray typing hints

This defines the aray type for all getTooltipContentArray occurences

* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
MDW
76eaf8bd8d Qual: Fix phan notices in classes related to class using getNextValue. (#30925)
* FIX 🛟 phan

* getToolTip() can take null for $coc

* Fix uninitialized vars & arg types

* PHPDoc typing, argument fixes

* PHPDoc typing, argument fixes for AdherentType

* PHPDoc typing, argument fixes for AdherentStats

* Update baseline to enable adherent notices

* Fix PHPDoc typing in api_members

* Minor bug fixes, typing

* PHPDoc api_subscriptions

* PHPDoc Societe

* Ignore empty foreach notice

* Add initialiser

* Categorie is string, old int mode is deprecated

* Fix missing initialisations

* Fix missing initialisations adherents/note

* Fix typing (cast), initialisation of var

* Fix initialisations

* Fix argument types

* Improve array PHPDoc type

* PHPDoc array type

* PHPDoc: Improve typing

* Correct argument type to getNomUrl

* Improve typing for timespent

* Fix typing for getNextValue args

* Improve typing

* Fix typing hints contrat/card

* Update baseline

* Fix typing

* Fix extraparams property typing

* Fix argument typing

* Qual: Correct covariant type

* Impove typing for timespent

* Remove exclusion no longer matched (level 6)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
2024-09-12 21:16:42 +02:00
thibdrev
3dbd79dad8 qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. (#30712)
* Update adherent.class.php

* Update adherent_type.class.php

* Update availabilities.class.php

* Update propal.class.php

* Update account.class.php

* Update paymentvarious.class.php

* Update cashcontrol.class.php

* Update localtax.class.php

* Update remisecheque.class.php

* Update bonprelevement.class.php

* Update chargesociales.class.php

* Update contact.class.php

* Update contrat.class.php

* Update commonorder.class.php

* Update timespent.class.php

* Update don.class.php

* Update conferenceorbooth.class.php

* Update expedition.class.php

* Update expensereport.class.php

* Update paymentexpensereport.class.php

* Update fichinter.class.php

* Update fournisseur.commande.class.php

* Update holiday.class.php

* Update evaluation.class.php

* Update job.class.php

* Update position.class.php

* Update skill.class.php

* Update intracommreport.class.php

* Update knowledgerecord.class.php

* Update loan.class.php

* Update mo.class.php

* Update partnership.class.php

* Update inventory.class.php

* Update entrepot.class.php

* Update project.class.php

* Update holiday.class.php - fix phan error

* Update task.class.php

* Update reception.class.php

* Update recruitmentcandidature.class.php

* Update recruitmentjobposition.class.php

* Update paymentsalary.class.php

* Update salary.class.php

* Update supplier_proposal.class.php

* Update ticket.class.php

* Update user.class.php

* Update usergroup.class.php

* Update webportalinvoice.class.php

* Update webportalorder.class.php

* Update webportalpropal.class.php

* Update workstation.class.php

* Update facture.class.php
2024-08-22 03:31:04 +02:00
MDW
ca414de526 Qual: Fix $fields related notices with Phan (#30704)
* Qual: Typing hints/ignore directives for phan notices

* Update field typing
2024-08-21 13:23:35 +02:00
MDW
d71cd352d5 Qual: Fix PhanUndeclaredMethod (#30661)
* Qual: Fix PhanUndeclaredMethod cases

* Fix PhanUndeclaredMethod cases

* Qual: Remove PhanUndeclaredMethod exceptions

* Fix spelling "disacard"

* Improve phpdoc, add abstract method to trait for typing

* Improve phpdoc typing for PHanUndeclaredMethod

* Suppress phan notices for guarded AliasNbPages calls

* Fix return value for printFile stub

* Fix getting message from Exception

* Define dummy getAllByProducts(), typing for it.

* Fix typo in comment

* Qual: Better typing for apiService (phan)

* Test that the Generic OAuth Service is provided

* Qual: Fix getSqlArrayForStats typing

* Force modTcpdfbarcode

* Correct typing hint

* Set ModelePDFAsset typehint

* Fix ModelePDFUserGroup typing hint

* Fix phan typing hints htdocs/core/modules/printing/printgcp.modules.php

* Fix write_file in ModelePDFStock*

* Update printsheet.php

* Adjust typing hint for barcode generator

* Update printsheet.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-19 02:05:27 +02:00
Frédéric FRANCE
97392965e1 fix ignored phpstan (#30645)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan
2024-08-16 20:13:02 +02:00
MDW
54880f92cd Qual: Fix PhanTypeMismatchProperty and some other phan notices (#30542)
* Qual: Fix PhanTypeMismatchProperty and some other phan notices

* Qual: Phan fixes for BOM

* Phan - fix fields

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Fix $fields phpdoc

* Fix phan typing issues with intermediate var and ??

* Fix phan typing issue with ?? operator

* Ignore htdocs/install/install.forced.php for git

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Update baseline

* Qual: Phan fixes for BOM

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration

* Fix typing hints (phpstan)

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-15 17:05:00 +02:00
MDW
aa49419e8f Qual: Fix/initial type cannot be inferred (#30591)
* Update baseline

* Add/update phpdoc typings

* Fix type for AssetDepreciationOptions as is

* Fix typing for Asset->depreciation_lines

* $card is used in derived classes, add it back to ActionsAdherentCardCommon

* Adjust code with typing/corrections for defined types

* Fix typos, code update to match typing, extra typing

* Add type cast for numeric operation

* Phpdoc/cast adjustments detected because of new phpdoc hints
2024-08-10 23:21:46 +02:00
Laurent Destailleur
8a38ad2b0a Fix type field 2024-08-07 02:31:17 +02:00
MDW
d6948077b2 Qual: Fix spelling/update .pre-commit configuration (versions) (#30546)
* Qual: Update pre-commit configuration

* Qual: Update spelling

* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
Alexandre SPANGARO
76f616796c Add llxHeader body css for member (#30302)
* NEW : llxHeader body css for member

* NEW : llxHeader body css for member

* NEW : llxHeader body css for member

* NEW : llxHeader body css for member

* NEW : llxHeader body css for member

* NEW : llxHeader body css for member

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-07-06 14:32:06 +02:00
Laurent Destailleur
f34b6da91b Debug v20 2024-06-03 13:37:36 +02:00
Frédéric FRANCE
bae0c17811 clean code (#29800)
* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* Update adherent.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-31 15:09:41 +02:00
Laurent Destailleur
31a626b34d Fix phan 2024-05-31 14:59:16 +02:00
Laurent Destailleur
832aca30dc Debug v20 2024-05-29 22:19:52 +02:00
Laurent Destailleur
c32ece68f4 Debug v20 2024-05-15 17:55:16 +02:00
Frédéric FRANCE
d0830b3159 fix phpstan (#29602)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

fix phpstan

fix phpstan

fix phpstan

fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-05 00:34:19 +02:00
Frédéric FRANCE
b0695abca9 fix phan (#29591)
* fix phan

* fix typos and translations

* fix phan remove code doing nothing

* fix phan remove code doing nothing

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-03 18:01:17 +02:00
Laurent Destailleur
fd9475be03 Use same doc comment eveywhere. 2024-04-07 12:26:27 +02:00
Laurent Destailleur
38fb00489d PHPDoc 2024-04-05 13:44:59 +02:00
Laurent Destailleur
b58e439a17 Clean use of $_POST 2024-03-28 21:29:02 +01:00
Laurent Destailleur
13e903aca4 Clean use of $_POST 2024-03-28 20:44:51 +01:00
Laurent Destailleur
a7e33e6573 Merge pull request #29047 from mdeweerd/fix/PhanPluginUnknownObjectMethodCall1
Fixes for PhanPluginUnknownObjectMethodCall
2024-03-28 14:20:57 +01:00
Eric Seigne
0e269102ae use MailSentByTo 2024-03-28 09:38:09 +01:00
MDW
b29f3a609d Force typing (phan) for typing checks 2024-03-27 10:17:31 +01:00
Laurent Destailleur
4f540ae677 Fix label for date of end of membership 2024-03-25 12:09:19 +01:00
MDW
33486f10c0 Fix PhanTypeMismatchReturnNullable by initialising return value 2024-03-20 21:58:33 +01:00
MDW
fd9d48faac Fix phpstan CommonObject->fields - notnull is optional field 2024-03-19 00:32:00 +01:00