William Mead
3e72a9c85f
Fixed undefined array keys ( #30767 )
2024-08-27 02:39:22 +02:00
HENRY Florian
d551f200f2
new: when initHook() and restrictedArea() exists always execute first initHook() ( #30703 )
2024-08-20 23:32:43 +02:00
HENRY Florian
07c9dea71e
Qual: add fields array property into categorie class ( #30450 )
...
* new: add fields array into categorie class
* reveiw php stan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-20 23:23:30 +02:00
MDW
75ed925f06
Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") ( #30563 )
...
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint in phan config to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjects
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Fix: MemberNumRefNumbers getExample does not take any arguments
Found thanks to adding the typing for phan!
* Qual: Correct forced type for $module
* Qual: Ignore phan false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Ignore false positive
* Qual: phan/Ignore false positive, replace depr.prop with method
* Qual: Fix typing for count by adding is_array check
* Qual: replace depr.prop `nom` with method
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Fix depr.prop with getter and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: Improve typing for mymodule template
* Make info method arguments match calls
* Make PrintingDriver abstract class because we added abstract methods
* Add phpdoc typing for phan
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update header wit correct information
* Update getExample method signature
* Update getExample method signature
* Correct reference to class in comment
* Force php phan typing for numbering modules
* Correct $_GLOBALS to $GLOBALS
* Add phpdoc to indicat type of properties
* Correct default to null
* Improve getNextValue typehint
* Improve getNextValue typehint
* Qual: Improve ModeleNumRefTakepos typing
* Qual: Improve ModeleNumRefRecruitmentJobPosition typing
* Fix default for $langs
* Do not use non-existing ModeleNumRefTakepos::nom
* Allow getNextValue argument to be null
* Correct $_GLOBAL into $GLOBALS
* Improve typing for ldap functions
* Allow null for outputlangs argument
* Improve typing for printOriginLine
* Improve typing for linkedObject access
* Fix PhanTypeMismatchArgumentNullableInternal and optimize
* Fix PhanPossiblyUndeclaredVariable by setting default value
* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4
* getToolTip does not accept null, changed to ''
* Improve getNextValue typing
* Change PrintingDriver back to normal class (instantiated)
And add errors for functions that should be overloaded
* Adjust pringOriginLine typing to match parent
* Fix phpdoc for getNextValue
* Fix phan typing
* Add/Improve phpdoc typing hints
* Qual: Adjustments to match typing
* Update typing for unit, use GETPOSTINT
* ModeleNumRefTask needs Project
* Fix several notices appearing after update from develop
* Index for choices is int, use GETPOSTINT
* Qual: Ignore empty foreach
* Force BOMLine on object line
* phan typing to indicate that linked objects are BOM
* Type the correct variable name (phan)
* Add typing for $langs
* Type to CommonNumRefGenerator (no class for availabilities)
* Resolve several phan notices after update from dev branch
* Extra typing fixes
* Move common attributes to parent class (phan)
* Add typing to Calendar class
* Improve typing hints
* Add typing to pdf_eagle_proforma
* Qual: Add typing for token in generic_oauthcallback.php
* Add typing for objMod
* Correct getNextValue function signature (phpstan)
* Fix typing (phpstan)
* Update version declarations (fix phpstan)
* Fix phpstan typing issues
* Adjust typing (phpstan)
* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
Noé Cendrier
57e9e5f845
FIX: PHPDoc wrong return value ( #30634 )
...
* FIX: PHPDoc wrong return value
* better type
* FIX: there is more types for Categorie::containing() return
2024-08-14 16:05:24 +02:00
Laurent Destailleur
a765760e81
Update doxygen
2024-08-14 14:52:35 +02:00
MDW
e570f59e2d
Qual: Phan fixes (mainly Initial type cannot be inferred) in popular changed classes ( #30604 )
...
* Update setValueFrom $id type to include null
* Only 2 arguments for ModeleNumRefMembers::getToolTip
* Fix PhanTypeConversionFromArray
* Only 6 args for PaymentSalary::addPaymentToBank
* Fix typing hints (array -> string)
* Fix uninitialized variables
* Add cssview to attributes phpdoc
* Avoid double typing specification (Phan notice)
* Qual: Ensure variable is defined (phan)
* Ensure phpdoc typing for verif method
* Ensure phpdoc typing for getNextValue method
* Add status as data key in cols array
* Ensure preg_replace operates on string (phan)
* Correct type for desiredstock
* Fix typing with casts (phan)
* Fix check that notification already exists
* Initialise fk_parent_id to fix typing issue
* Qual: Fix phan notices for Societe & related
* Qual: Fix typing for Facture and related
* Qual: Fix typing for Product & related
* Update baseline
* Fix new phpstan notices
2024-08-14 01:24:55 +02:00
Lucas Marcouiller
a671c91d3e
QUAL bankline category table name ( #30419 )
...
* FIX bankline category table name
* remove bad space
---------
Co-authored-by: Hystepik <lmarcouiller@nltechno.com >
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-07-28 17:43:46 +02:00
Laurent Destailleur
c9b92bb32d
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-25 18:21:47 +02:00
Laurent Destailleur
6b076821e3
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2024-07-25 18:20:01 +02:00
Laurent Destailleur
f4611fcec9
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-07-25 18:06:37 +02:00
Sylvain Legrand
89b558a1b1
Fixes loss of rich text wrapping for translated category descriptions ( #30433 )
...
If multi-language is enabled, saving translations of category descriptions loses the rich text wrapping (wysiwyg)
2024-07-23 19:36:09 +02:00
Lucas Marcouiller
c8fb079893
FIX bank categorie table name ( #30415 )
...
Co-authored-by: Hystepik <lmarcouiller@nltechno.com >
2024-07-18 23:57:19 +02:00
Laurent Destailleur
147a8bfaee
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
...
Conflicts:
htdocs/adherents/subscription/list.php
htdocs/categories/viewcat.php
htdocs/contrat/card.php
htdocs/contrat/list.php
htdocs/eventorganization/conferenceorbooth_list.php
htdocs/expedition/list.php
htdocs/societe/card.php
2024-07-11 10:44:39 +02:00
Alexandre SPANGARO
013835e547
Use HasRight() ( #30333 )
2024-07-10 18:59:04 +02:00
Frédéric FRANCE
94feb2cfa7
fix phpstan expects values ( #30324 )
...
* fix phpstan expects values
* fix phpstan expects values
2024-07-09 19:28:59 +02:00
Alexandre SPANGARO
96afcaa476
Better comments ( #30200 )
...
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* CI Missing language key
* Update eventorganization.lang
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-06-30 21:02:50 +02:00
Laurent Destailleur
f413481f7d
Clean code
2024-06-17 13:48:15 +02:00
thibdrev
b14d20bc4c
qual fix PHAN warning when using $product->fetch($id) with $id not being an integer ( #30019 )
...
* qual fix phan warning on $object->fetch('')
TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($id) is '' of type '' but \Product::fetch() takes int (no real type) defined at htdocs/product/class/product.class.php:2540 (the inferred real argument type has nothing in common with the parameter's phpdoc type)
htdocs/variants/class/ProductCombination.class.php 773
* Update api_categories.class.php
* Update api_categories.class.php
* Update api_products.class.php
* Update api_products.class.php
* Update combinations.php
2024-06-15 15:53:36 +02:00
Pichi1966
d8b4f9248d
# NEW : add ActionComm categories accessible thru API ( #30005 )
...
* Update api_categories.class.php
Add Actioncomm Categories management thru API
* Update api_categories.class.php
* Update api_categories.class.php
* Update api_categories.class.php
* Update api_categories.class.php
* Update api_categories.class.php
2024-06-13 08:53:30 +02:00
Laurent Destailleur
82908a30eb
Clean phan warnings
2024-05-30 13:37:17 +02:00
Laurent Destailleur
d723abc487
Debug v20
2024-05-28 23:52:33 +02:00
Laurent Destailleur
e92fa65208
Debug v20
2024-05-24 01:41:53 +02:00
Frédéric FRANCE
83c04db0ef
fix phpunit ( #29696 )
...
* fix phpunit
* fix phpunit
* fix phpunit
2024-05-15 18:07:05 +02:00
Frédéric FRANCE
9d291c50b8
fix warnings ( #29682 )
...
* fix warning
* Update categorie.class.php
* Update main.inc.php
* Update traduction.php
* Update SecurityTest.php
2024-05-15 15:08:34 +02:00
Laurent Destailleur
954d20b6d8
Fix warning
2024-05-13 12:54:48 +02:00
Laurent Destailleur
2451bf82ca
Fix phpstan
2024-05-13 12:46:18 +02:00
Laurent Destailleur
46a3941e84
Debug v20
2024-05-08 12:40:15 +02:00
Laurent Destailleur
8b84be2d6c
Add select component to support correctly option C
...
ONTACT_USE_SEARCH_TO_SELECT
2024-05-07 19:59:20 +02:00
Laurent Destailleur
55d2f3d9fc
Debug v20
2024-05-06 10:00:18 +02:00
Laurent Destailleur
0b9bd5408b
Debug v20: Encapsulate the feature using leaflet/geophp into a constant
...
MAIN_USE_GEOPHP. Fix webportal module.
2024-05-03 02:39:35 +02:00
Frédéric FRANCE
7c73d7d2bd
fix phpstan ( #29520 )
...
* fix phpstan
* Update user.class.php
* typo
2024-04-28 18:20:58 +02:00
Laurent Destailleur
55c8048639
Try to fix phan warnings
2024-04-28 13:02:49 +02:00
Laurent Destailleur
21995b881b
Try to fix phan warning
2024-04-28 12:45:52 +02:00
Laurent Destailleur
21d8925bb9
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2024-04-28 12:31:40 +02:00
Laurent Destailleur
5b777188e2
Fix Phan
2024-04-28 01:47:18 +02:00
Frédéric FRANCE
82d63247d7
fix phpstan pgsql.class.php ( #29511 )
...
* fix phpstan pgsql.class.php
* Update Database.interface.php
* fix phan
fix phan
fix phan
* fix phan
* fix phan
* fix phan
* fix phan
fix phan
fix phan
fix phan
fix phan
* fix phan
* fix phan
* fix phan
* fix phan
2024-04-27 22:01:34 +02:00
Laurent Destailleur
e0231b6244
Debug v20
2024-04-20 19:32:38 +02:00
Laurent Destailleur
cfa71c869f
Debug v20
2024-04-10 20:56:50 +02:00
Laurent Destailleur
edec5fb6f1
Doc
2024-04-10 16:45:16 +02:00
Laurent Destailleur
046ffbc024
FIX getObjectsInCateg must not return corrupted orphelins
2024-04-10 16:31:50 +02:00
Laurent Destailleur
9771370fc1
FIX Color must not be saved with the # char
2024-04-08 18:47:41 +02:00
Laurent Destailleur
dc77cf736d
Fix css
2024-04-08 18:42:11 +02:00
Laurent Destailleur
0a48d1ad56
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2024-04-08 03:38:04 +02:00
Laurent Destailleur
b5de782c6b
Fix use the good HTTP code
2024-04-07 14:59:25 +02:00
Laurent Destailleur
d32bb1668f
Update categorie.class.php
2024-04-04 18:58:10 +02:00
Laurent Destailleur
2fbe1fe149
Update categorie.class.php
2024-04-04 18:55:32 +02:00
Benjamin Falière
e505ebf0f7
FIX: categories protection limit
2024-04-03 15:04:03 +02:00
Laurent Destailleur
7715513ac9
Some API HTTP return code were moved from 401 to 403 to better follow
...
REST specification.
2024-04-02 14:47:49 +02:00
Laurent Destailleur
990216b13f
NEW Api parameters are sanitized by the WAF, same code than GET/POST
2024-04-02 13:07:13 +02:00