2
0
forked from Wavyzz/dolibarr
Commit Graph

872 Commits

Author SHA1 Message Date
MDW
46eb5f83c2 Qual: Updates for phpstan notices (#30509)
* Fix int<0> typing to int<0,0> for phpstan

* Fix phpdoc for phpstan

* Fix phpdoc for phpstan

* Qual: Several phpstan notice fixes

* Fix phpdoc

* Qual: totalpaid is never null, remove null test

* improve phpdoc typing

* Also return null to statisfy phpstan

* Allow null value for $var

* object->Object to make it meaningful

* Type EvalMathStack properties

* Comment out unused private methods (phpstan)

* Changes for phpstan (return values, phpdoc, code)

* Change order of tests for phpstan

* phpdoc object to Object for correct typing

* Typing hing for phpstan

* UPdate test for phpstan

* Change phpdoc position for phpstan

* Update phpdoc for phpstan

This needs further improvement

* Change $op to $ope to fix phpstan

* Update sqlite3.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-01 12:59:45 +02:00
Laurent Destailleur
147a8bfaee Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	htdocs/adherents/subscription/list.php
	htdocs/categories/viewcat.php
	htdocs/contrat/card.php
	htdocs/contrat/list.php
	htdocs/eventorganization/conferenceorbooth_list.php
	htdocs/expedition/list.php
	htdocs/societe/card.php
2024-07-11 10:44:39 +02:00
Alexandre SPANGARO
128769811c Add css bodylist on list (#30334)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-07-11 00:45:05 +02:00
Alexandre SPANGARO
013835e547 Use HasRight() (#30333) 2024-07-10 18:59:04 +02:00
Frédéric FRANCE
94feb2cfa7 fix phpstan expects values (#30324)
* fix phpstan expects values

* fix phpstan expects values
2024-07-09 19:28:59 +02:00
Laurent Destailleur
8a4f550d64 Debug v20 2024-07-09 17:33:27 +02:00
Alexandre SPANGARO
96afcaa476 Better comments (#30200)
* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* CI Missing language key

* Update eventorganization.lang

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-06-30 21:02:50 +02:00
Frédéric FRANCE
4b275dc148 add phpdoc (#30208)
* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* clean phpdoc
2024-06-30 19:39:01 +02:00
Laurent Destailleur
0a15655720 Debug v20 2024-06-27 10:41:55 +02:00
Laurent Destailleur
3c1acd82b6 Debug look and feel v20 2024-06-22 14:31:37 +02:00
Mathieu Moulin
abcb1dad4b Define CommonObject relation in CommonObjectLine classes (#29956) 2024-06-10 16:08:39 +02:00
Laurent Destailleur
326e611851 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-05-29 14:46:55 +02:00
Alexandre SPANGARO
e134875bd3 FIX #29403 HRM - Unable to delete a skill in a job Profile (#29779) 2024-05-29 12:31:13 +02:00
Laurent Destailleur
66f4562300 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-05-23 14:50:17 +02:00
Laurent Destailleur
a854e58905 FIX Missing $param in hook call for list 2024-05-23 14:41:56 +02:00
Laurent Destailleur
458ffdb23e css 2024-05-09 18:15:57 +02:00
Frédéric FRANCE
d0830b3159 fix phpstan (#29602)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

fix phpstan

fix phpstan

fix phpstan

fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-05 00:34:19 +02:00
Laurent Destailleur
0b9bd5408b Debug v20: Encapsulate the feature using leaflet/geophp into a constant
MAIN_USE_GEOPHP. Fix webportal module.
2024-05-03 02:39:35 +02:00
MDW
2115980560 Qual: Fix Phan notices in CommonObject (#29354)
* Fix PhanPluginSimplifyExpressionBool in commonobject

* Fix commonobject for phan notices

* Allow null for $usedolidb argument

* Allow null for $outputlangs argument of \dol_format_address()

* Fix multiple phan notices

* Ignore PhanTypeArraySuspiciousNullable

* Fix PhanTypeMismatchArgumentProbablyReal

* Update baseline

* Improve typings

* Update type specification getCountry/withCode

* Fix CommonObject Phan notices & update baseline

* Fix phan notices

* Correct typing for showInputField to be the same as parent class

* Fix PhanPluginSimplifyExpressionBool in commonobject

* Fix commonobject for phan notices

* Allow null for $usedolidb argument

* Allow null for $outputlangs argument of \dol_format_address()

* Fix multiple phan notices

* Ignore PhanTypeArraySuspiciousNullable

* Fix PhanTypeMismatchArgumentProbablyReal

* Update baseline

* Improve typings

* Update type specification getCountry/withCode

* Fix CommonObject Phan notices & update baseline

* Fix phan notices

* fixup! Correct typing for showInputField to be the same as parent class
2024-05-02 19:33:51 +02:00
Laurent Destailleur
e3daa23949 Look and feel v20 2024-04-30 09:45:28 +02:00
Laurent Destailleur
0c54fe40a6 Doc 2024-04-25 10:23:28 +02:00
Laurent Destailleur
b7a07d8348 Look and feel v20 2024-04-19 15:54:09 +02:00
Laurent Destailleur
0f1369a192 Standardize GUI 2024-04-12 02:00:28 +02:00
Laurent Destailleur
fd9475be03 Use same doc comment eveywhere. 2024-04-07 12:26:27 +02:00
Frédéric FRANCE
7cf6a0821f fix phpdoc for ismultientitymanaged (#29245)
* fix phpdoc

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-06 17:38:39 +02:00
Laurent Destailleur
38fb00489d PHPDoc 2024-04-05 13:44:59 +02:00
Laurent Destailleur
d4268de403 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-04-04 16:52:38 +02:00
Laurent Destailleur
60bc60db48 FIX #29225 2024-04-04 16:48:27 +02:00
Laurent Destailleur
fffe74246c Fix all short tables must use the setup for the number of rows 2024-04-03 15:30:10 +02:00
Laurent Destailleur
e3037794aa Look and feel v20 2024-04-01 15:04:20 +02:00
MDW
5ca5d67939 Improve phpdoc typing 2024-03-31 01:03:33 +01:00
Frédéric France
7a7b1953ed fix phpstan 2024-03-28 20:34:33 +01:00
Hystepik
48a8ce6612 Fix fatal error on skill_card 2024-03-27 12:55:06 +01:00
Laurent Destailleur
7a1e0fb808 Merge pull request #29058 from mc2rcanarslan/patch-18
FIX: use hasRight function
2024-03-25 21:38:00 +01:00
Can Arslan
e1787360d5 FIX: hasRight function
Also fixes;

PHP Warning:  Undefined property: stdClass::$write in /htdocs/hrm/job_list.php on line 137

PHP Warning:  Undefined property: stdClass::$delete in /htdocs/hrm/job_list.php on line 138
2024-03-25 13:06:18 -06:00
Can Arslan
0ed297d8ca FIX: used hasRight function
Also fixes;
PHP Warning:  Undefined property: stdClass::$write in /htdocs/hrm/position_list.php on line 138
PHP Warning:  Undefined property: stdClass::$delete in /htdocs/hrm/position_list.php on line 139
2024-03-25 13:03:28 -06:00
Laurent Destailleur
7b0177a84d Move to getDolGlobalString 2024-03-22 00:37:56 +01:00
MDW
519da00897 Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:35 +01:00
MDW
ee5d837fcc Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:33 +01:00
MDW
b3cda67e36 Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:32 +01:00
MDW
579f2dee4c Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:30 +01:00
MDW
f28af956f9 Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:29 +01:00
MDW
169d1a2ff8 Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:28 +01:00
MDW
0df51158dd Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:26 +01:00
Laurent Destailleur
6b1f490ee1 Merge branch 'develop' into phpstanphpstan 2024-03-19 02:05:42 +01:00
MDW
fd9d48faac Fix phpstan CommonObject->fields - notnull is optional field 2024-03-19 00:32:00 +01:00
Frédéric France
a8627c9315 fix phpstan 2024-03-17 22:06:53 +01:00
Frédéric France
09a953d18f fix phpstan 2024-03-17 22:04:10 +01:00
Laurent Destailleur
de58435ef1 FIX: if we stop for security purpose, we must exit a non zero value. 2024-03-16 23:08:15 +01:00
MDW
8c29ca9033 Fix PhanNoopVariable for $i by changing loop to while
# Fix PhanNoopVariable for $i by changing loop to while

`$i` looked like a NOOP on $i which is provided as an argument to
the function.  Changed to while to improve readability and avoid thinking
that `$i` needs initialisation and fix the notification
2024-03-16 00:00:26 +01:00