* insertExtrafields(): simplify by returning 0 early if array_options is empty
* insertExtrafields(): simplify by using local variables $newValue and $attributeType
* insertExtrafields(): refactor by grouping the empty value cases for geodatabase-type extrafields
* insertExtrafields(): refactor by using a static mapping of geodata types to their ST_* db function on ExtraField class
* FIX: when an object that is shared across multiple entities already has some extrafields from another entity that are not reachable from the current entity, their values are lost
* Compliance with
- phan ( Closure Closure($key) has no declared or inferred parameter type for $key)
- php-stan (Error: Property ExtraFields::$geoDataTypes has no type specified)
* fill extrafields default values in case THIRDPARTY_PROPAGATE_EXTRAFIELDS_TO_SUPPLIER_ORDER applies
* Fix: send param changecompany when changing company on a supplier order creation
* Improved ergonomics through UI design
In IT conventions, the Cancel button is on the left and the Create button on the right. On Dolibarr, it's currently the other way round, which is rather counter-intuitive when you reflexively click. Correction to improve the GUI while respecting cultural norms.
* Update html.form.class.php with const
* Update html.form.class.php
* Update html.form.class.php
* Update html.form.class.php
* Update html.form.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* redoing PR Api objectlinks #33738
* loading objectlinks api from main api folder
* bringing $FIELDS up to develop branch standard
* trying to tell phan the expected array types
* phan return and input type specifications
* trying to fix 'Method ObjectLink::_makeobject() should return int but return statement is missing.'
* trying to return an ObjecTLink
* get returns an ObjectLink object
* making sure that function _makeobject always has an return
* making sure deleteByValues always has a return statement
* remove empty line
* making sure getByValues always has a return value
* trying to fix phan for _validate
* no < around objectlink
* trying to fix some phan and phan-stan errors
* public variable target should be fk_target
* making TRIGGER_PREFIX more like in core/class/commonobject.class.php
* trying to save and use the notrigger value
* typecast objectlink fk_source and fk_target to string in the hope that they are later made correctly to int
* whitespace to trigger a build of my branch
* back to being int - because that is what they are
* trying to typecast
* trying to help PHPStan to validate fk_source and fk_target
* trying to use the same way as are used
* splitting over multiple lines
* Fix: update ObjectLink return type in API methods
### FIX: Update ObjectLink return type in API methods
- Updated the return type of several methods from `ObjectLink` to `Object` to reflect a return type compatible with Luracast/Restler
* fix: refactor field setting in ObjectLinks class
# Fix: Refactor field setting in ObjectLinks class
- Removed the static `$INTFIELDS` array and moved its logic to a new private
method `_setObjectLinkField`.
- Updated `create`, `getByValues`, and `deleteByValues` methods to use
`_setObjectLinkField` for setting fields.
- Cleaned up the code by removing redundant field validation and type casting
logic.
* noting that relation type can both be string and null
* escaping strings before parsing them to the database
* -> not global
* trying to fix phpstan errors by flipping so the string part is first
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
Co-authored-by: MDW <mdeweerd@users.noreply.github.com>
