2
0
forked from Wavyzz/dolibarr
Commit Graph

40028 Commits

Author SHA1 Message Date
ldestailleur
d828828bef CSS 2025-06-25 12:15:17 +02:00
ldestailleur
44043ea008 Clean code - Debug v22 2025-06-24 19:33:50 +02:00
ldestailleur
765caf894b Debug v22 2025-06-24 17:55:11 +02:00
ldestailleur
6bd37636f5 Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-06-24 14:07:45 +02:00
Alexandre Janniaux
efd95ad107 Qual commonobject: line_max: factor conditonals together (#34600)
* commonobject: line_max: factor conditonals together

The SQL request is shared, except for the additional filter.

* Update commonobject.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-06-23 18:28:13 +02:00
ldestailleur
115afbbb76 Add critical info into unalterable log to help debug
FIX: Must be able to filter on signature.
2025-06-23 14:04:36 +02:00
ldestailleur
ec5275e1d9 Fix picto download/upload 2025-06-23 03:36:27 +02:00
ldestailleur
14a196b5c6 Debug v22 2025-06-23 00:08:14 +02:00
ldestailleur
040393abe5 Debug v22 2025-06-22 22:50:56 +02:00
HENRY Florian
bfa389daea fix: Bad contact URL link on Task list on project (#34431)
* fix: Bad contact URL link on Task list on project

* Update project.lib.php

* fix stan

* Update project.lib.php

* Update project.lib.php

* Update project.lib.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-06-22 20:13:01 +02:00
ldestailleur
17a0ec87fe Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0 2025-06-22 17:25:29 +02:00
ldestailleur
743ca4bb03 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2025-06-22 17:19:41 +02:00
ldestailleur
5042c0959e Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2025-06-22 17:16:51 +02:00
ldestailleur
23004a7999 Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-06-22 13:00:55 +02:00
lvessiller-opendsi
ce1243140f FIX js warning (Backport commit 84d982c) (#34555)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-06-22 12:49:52 +02:00
Charlène Benke
bec0e9983f create invoice and order categorie table when we enable it (#34450)
* create invoice and order categorie table if not enabled

* Update modFacture.class.php

* Update modCommande.class.php

* Update modCategorie.class.php

* Update modCommande.class.php

* Update modFacture.class.php

* Update modCategorie.class.php

* Update modCommande.class.php

* Update modFacture.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-06-22 12:13:16 +02:00
Charlène Benke
10c9c41526 COMPANY_ELEPHANT_DATE_START_ENABLE Checkbox not save (#34516)
* COMPANY_ELEPHANT_DATE_START_ENABLE Checkbox not save

* Update mod_codeclient_elephant.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-06-21 16:50:45 +02:00
apsolauv
88e78d1667 Fix return type and error type getSumCreditNotesUsed (#34527)
Co-authored-by: Alex SOLAUV <test@test.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-06-21 16:16:47 +02:00
kkhelifa-opendsi
79a6825e6f FIX - Add others allowed tags (table, tr, td) for the prices history table displayed in the link url of the supplier product in supplier product prices list (#34532)
* FIX - Add others allowed tags (table, tr, td) for the prices history table displayed in the link url of the supplier product in supplier product prices list

* Fix

* Fix
2025-06-21 16:10:26 +02:00
HENRY Florian
931384db35 fix: manage correctly external module object link with myobject@mymodule element type (#34530)
* fix: manage correctly external module object link with myobject@mymodule element type

* add more doc in template module builder

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-06-21 16:09:54 +02:00
ldestailleur
dc641d7380 Debug v22 2025-06-21 15:29:54 +02:00
Maxime Kohlhaas
4f3a0177c6 Fix : in messaging view, the event status was missing (#34533) 2025-06-21 15:18:27 +02:00
ldestailleur
aa56fb6491 Doc 2025-06-21 14:54:53 +02:00
ldestailleur
cf8beb8505 Fix error return 2025-06-21 14:39:53 +02:00
Alexandre Janniaux
1a3430f40a commonobject: updateLineDown: use early return on query failure (#34598)
Simplify the code by early returning on query failure, which removes
almost every indentation level of the function.

It also highlights some important flaws here, since there is a return
without value (void return type) between the two queries if an error
happened, which would indicate the first query failed and nothing was
registered, but also an error check leading to printing an error message
if the second query fails, without actually reverting the first one, and
since there is no error code, there's no way to trigger a db->rollback()
from the caller code for this reason.
2025-06-21 14:36:07 +02:00
Marc
52c827c2bb FIX #34541 (#34597) 2025-06-21 14:35:20 +02:00
Alexandre Janniaux
1113ae6dc1 Qual: Commonobject reverse happy path (#34599)
* commonobject: getRangOfLine: reverse happy and error path

* commonobject: getIdOfLine: reverse error and happy path
2025-06-21 14:35:01 +02:00
ldestailleur
7ed2cddd4b Fix CI 2025-06-20 16:16:04 +02:00
Frédéric FRANCE
7c0604047e fix missing translation (#34587)
* fix missing translation

* fix missing translation
2025-06-20 15:48:58 +02:00
Günter Lukas
603f46a173 Fix #34593 (#34594)
* Fix #34593

* Fix whitespace

* Fix phpstan error

* undi fix in dolibarrtriggers.class.php

* Fix #34593
2025-06-20 15:43:39 +02:00
ldestailleur
446efdc432 Clean dead code 2025-06-20 14:00:29 +02:00
ldestailleur
2a85b73fa2 Add MULTICURRENCY_SHOW_ALSO_MAIN_CURRENCY_ON_PDF for legal requirement
that need both currencies on PDF
2025-06-20 14:00:14 +02:00
ldestailleur
703d4358a5 Debug v22 2025-06-20 12:34:10 +02:00
ldestailleur
739cbe063b Fix missing 2025-06-19 16:47:12 +02:00
ldestailleur
2cfa986ad5 Doc 2025-06-19 15:58:23 +02:00
ldestailleur
ec8a87a3cb Doc 2025-06-19 15:49:26 +02:00
ldestailleur
9c2da8b9b6 Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-06-19 11:31:44 +02:00
ldestailleur
a78e63dbf0 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0 2025-06-19 11:13:59 +02:00
ldestailleur
ec098b2632 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2025-06-19 10:59:07 +02:00
ldestailleur
0da1e6b464 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2025-06-19 10:48:18 +02:00
HENRY Florian
68a33a8759 fix: SubTotal module version for 22 is still experimental (even if actually it's working like a charm on the customer scope) (#34573) 2025-06-19 10:40:06 +02:00
ldestailleur
247847cd14 Fix warnings 2025-06-19 10:39:19 +02:00
Alexandre Janniaux
0770e79749 commonobject: updateLineUp: use early return on query failure (#34570)
Simplify the code by early returning on query failure, which removes
almost every indentation level of the function.

It also highlights some important flaws here, since there is a return
without value (void return type) between the two queries if an error
happened, which would indicate the first query failed and nothing was
registered, but also an error check leading to printing an error message
if the second query fails, without actually reverting the first one, and
since there is no error code, there's no way to trigger a db->rollback()
from the caller code for this reason.
2025-06-19 10:12:55 +02:00
Alexandre Janniaux
1da9aab8d4 commonobject: updateRangOfLine: de-indent happy path (#34569)
There's no need for the else{} block when the if block early returns,
and it helps highlighting the happy path. Note that this kind of change
only make sense when one of the block is an error, not a choice between
two possibilities.
2025-06-19 10:11:12 +02:00
Frédéric FRANCE
bf2d6f1f1e fix CI (#34553)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-06-19 10:10:42 +02:00
ldestailleur
0a0f96bda6 Fix CI 2025-06-18 19:13:53 +02:00
ldestailleur
9d89c206df Debug v22 2025-06-18 16:14:33 +02:00
ldestailleur
06a5b4947d Fix CI 2025-06-18 15:59:28 +02:00
ldestailleur
e036520cb0 Debug v22 2025-06-18 15:10:58 +02:00
Alexandre Janniaux
f04a390cb5 commonobject: getChildrenOfLine: early return on query error (#34547)
This makes the code more readable by deindenting two whole levels on the
happy path.
2025-06-18 14:19:37 +02:00