Wavyzz/dolibarr-fork
2
0
Fork 0
forked from Wavyzz/dolibarr
Code Pull Requests Activity
143,484 Commits 36 Branches 189 Tags
a90f0863de1a619a67ca19c20ed4484f94ece834
Commit Graph

544 Commits

Author SHA1 Message Date
Frédéric FRANCE
89918c58e5 fix 2025-02-19 18:12:17 +01:00
MDW
5035580e56 Qual: Fix phan notices (societe) 2025-02-17 09:44:12 +01:00
MDW
24fa28dfe2 Qual: Fix getKanban phpdoc 
# Qual: Fix getKanban phpdoc

Array phpdoc for getKanban corrections.
 2025-02-05 01:43:37 +01:00
Laurent Destailleur (aka Eldy)
732f97d73c Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into 
develop
 2025-02-05 00:40:06 +01:00
Maxime Kohlhaas
ba2dab2a44 NEW : auto-detect country from code in creation (follow-up⁾ 2025-01-10 16:56:14 +01:00
Laurent Destailleur (aka Eldy)
de321e8f01 Fix typo 2025-01-09 02:01:49 +01:00
Laurent Destailleur (aka Eldy)
c0250e4c91 FIX CVE-2024-55227 CSRF when MAIN_RESTRICTHTML_ONLY_VALID_HTML_TIDY is 
on (hidden option not on by default)
 2025-01-08 17:41:45 +01:00
MDW
ec2a1928ba Qual: Update fields phpdoc to include fields that are defined/used in some cases 
# Qual: Update fields phpdoc to include fields that are defined/used in some cases

comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
 2024-12-05 02:36:50 +01:00
MDW
0ac595364b Qual: Fix phan/phpstan notices in class files (part 1) (#31501) 
* Ignore phpstan configuration for spelling

* Qual: Fix phan notices in class files
 2024-10-25 21:00:02 +02:00
Laurent Destailleur
3bc1d35236 QUAL The property ->domiciliation and ->propio on bank accounts has been 
deprecated and replaced with property ->address and ->owner_name
 2024-10-24 12:38:41 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176) 
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-09-29 21:52:31 +02:00
MDW
5e02bec9df Qual: Fix getTooltipContentArray typing hints (#31081) 
* Qual: Fix getTooltipContentArray typing hints

# Qual: Fix getTooltipContentArray typing hints

This defines the aray type for all getTooltipContentArray occurences

* Ignore undeclared property ref_supplier (does not exist on OrderLine)
 2024-09-23 03:24:19 +02:00
Laurent Destailleur
84e5f5e7b4 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-20 02:51:59 +02:00
Laurent Destailleur
401c9898bb Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-20 02:46:03 +02:00
William Mead
7d92e4daef Fix bank account domiciliation address (#31019) 
* Fixed bank account domicilation update

* Fixed bank address on create
 2024-09-20 01:47:23 +02:00
atm-thomasb
fdca7b691a FIX: BIC requirement is now checked separately from IBAN (#30994) 2024-09-18 01:30:56 +02:00
thibdrev
3dbd79dad8 qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. (#30712) 
* Update adherent.class.php

* Update adherent_type.class.php

* Update availabilities.class.php

* Update propal.class.php

* Update account.class.php

* Update paymentvarious.class.php

* Update cashcontrol.class.php

* Update localtax.class.php

* Update remisecheque.class.php

* Update bonprelevement.class.php

* Update chargesociales.class.php

* Update contact.class.php

* Update contrat.class.php

* Update commonorder.class.php

* Update timespent.class.php

* Update don.class.php

* Update conferenceorbooth.class.php

* Update expedition.class.php

* Update expensereport.class.php

* Update paymentexpensereport.class.php

* Update fichinter.class.php

* Update fournisseur.commande.class.php

* Update holiday.class.php

* Update evaluation.class.php

* Update job.class.php

* Update position.class.php

* Update skill.class.php

* Update intracommreport.class.php

* Update knowledgerecord.class.php

* Update loan.class.php

* Update mo.class.php

* Update partnership.class.php

* Update inventory.class.php

* Update entrepot.class.php

* Update project.class.php

* Update holiday.class.php - fix phan error

* Update task.class.php

* Update reception.class.php

* Update recruitmentcandidature.class.php

* Update recruitmentjobposition.class.php

* Update paymentsalary.class.php

* Update salary.class.php

* Update supplier_proposal.class.php

* Update ticket.class.php

* Update user.class.php

* Update usergroup.class.php

* Update webportalinvoice.class.php

* Update webportalorder.class.php

* Update webportalpropal.class.php

* Update workstation.class.php

* Update facture.class.php
 2024-08-22 03:31:04 +02:00
MDW
ca414de526 Qual: Fix $fields related notices with Phan (#30704) 
* Qual: Typing hints/ignore directives for phan notices

* Update field typing
 2024-08-21 13:23:35 +02:00
MDW
54880f92cd Qual: Fix PhanTypeMismatchProperty and some other phan notices (#30542) 
* Qual: Fix PhanTypeMismatchProperty and some other phan notices

* Qual: Phan fixes for BOM

* Phan - fix fields

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Fix $fields phpdoc

* Fix phan typing issues with intermediate var and ??

* Fix phan typing issue with ?? operator

* Ignore htdocs/install/install.forced.php for git

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Update baseline

* Qual: Phan fixes for BOM

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration

* Fix typing hints (phpstan)

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-15 17:05:00 +02:00
Laurent Destailleur
ed73dc6471 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-13 11:59:53 +02:00
Laurent Destailleur
e19b573ba0 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-08-13 11:53:47 +02:00
Laurent Destailleur
a3ae470fce FIX #30610 - Disable the deprecation mecanism. Too many regressions. 2024-08-13 11:53:21 +02:00
Frédéric FRANCE
3510247892 fix unknown variable (fix phan) (#30617) 2024-08-13 11:09:37 +02:00
Laurent Destailleur
813bd1706f Merge 2024-08-12 22:11:26 +02:00
Laurent Destailleur
4f6643fe1e Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 
Conflicts:
	htdocs/commande/card.php
	htdocs/core/multicompany_page.php
 2024-08-12 21:51:31 +02:00
Laurent Destailleur
7023061cd8 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-08-12 21:42:42 +02:00
Laurent Destailleur
892d9cc865 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-08-12 21:35:51 +02:00
HENRY Florian
163e623964 FIX: on change ref for bank account attachement are lost (#30529) 
* FIX: on change ref for bank account attachement are lost

* FIX: on change ref for bank account attachement are lost

* FIX: on change ref for bank account attachement are lost

* Update card.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-07 03:08:04 +02:00
MDW
d6948077b2 Qual: Fix spelling/update .pre-commit configuration (versions) (#30546) 
* Qual: Update pre-commit configuration

* Qual: Update spelling

* Ignore use of deprecated constant
 2024-08-07 01:20:43 +02:00
Lucas Marcouiller
a671c91d3e QUAL bankline category table name (#30419) 
* FIX bankline category table name

* remove bad space

---------

Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-07-28 17:43:46 +02:00
Laurent Destailleur
50190db5c7 Fix option WITHDRAWAL_WITHOUT_BIC 2024-07-25 22:02:20 +02:00
Joachim Kueter
b1b6c91f22 FIX #30397: for direct debit payments, BIC is optional (#30398) 
* Fix missing loading trans file

* allow withdrawals without SEPA/BIC code (just IBAN)

* fix pre-commit formatting check

* fix Travis

* fix and, or

* fix formatting

---------

Co-authored-by: Laurent Destailleur <eldy@users.sourceforge.net>
 2024-07-17 19:45:56 +02:00
jyhere
2bf38d09ed FIX: $rappro property should match the updated value (Account::updateconciliation()) (#30311) 2024-07-08 23:50:43 +02:00
jyhere
2a18909e9d FIX: $rappro property should match the updated value (Account::updateconciliation()) (#30311) 2024-07-08 23:44:58 +02:00
Laurent Destailleur
21f1383816 Clean code 2024-06-21 03:46:45 +02:00
Frédéric FRANCE
7690fd7191 phpstan ignore level 4 (#30047) 2024-06-17 13:17:38 +02:00
Laurent Destailleur
6bc0fd784e Debug v20 2024-05-20 18:16:55 +02:00
Frédéric FRANCE
d0830b3159 fix phpstan (#29602) 
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

fix phpstan

fix phpstan

fix phpstan

fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-05-05 00:34:19 +02:00
Frédéric FRANCE
dbd8657de1 Cleanaccount (#29271) 
* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* wip

* wip

* wip
 2024-04-20 21:53:40 +01:00
Frédéric FRANCE
95eb1abf2e clean code (#29268) 2024-04-07 15:01:29 +02:00
Frédéric FRANCE
97240a05b0 fix phpdoc (#29266) 2024-04-07 14:17:50 +02:00
Laurent Destailleur
fd9475be03 Use same doc comment eveywhere. 2024-04-07 12:26:27 +02:00
Laurent Destailleur
38fb00489d PHPDoc 2024-04-05 13:44:59 +02:00
MDW
fd9d48faac Fix phpstan CommonObject->fields - notnull is optional field 2024-03-19 00:32:00 +01:00
Laurent Destailleur
29d6c2b76e Fix for #28821 ->status is int ->labelStatus is array of label. 2024-03-15 15:07:05 +01:00
MDW
23785393a3 Add csslist to json keys 2024-03-15 03:55:52 +01:00
MDW
c27a93401c Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:44:45 +01:00
MDW
88d59896ec Qual: 'enabled' in fields can be string ('isModEnabled(...)') 
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')

Update PHPdoc to allow that enabled is a string
 2024-03-12 13:38:08 +01:00
MDW
ec18ec0605 Fix: Repeat fields typing in CommonClass children 
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
 2024-03-11 17:38:59 +01:00
Frédéric FRANCE
fba15178eb all initAsSpecimen return int (#28577) 
* all initAsSpecimen return int

* all initAsSpecimen return int

* all initAsSpecimen return int
 2024-03-02 16:38:35 +01:00