Laurent Destailleur
054df65f66
Merge branch 'develop' into develop_FichInterClone_Contacts_Not
2025-02-05 03:02:30 +01:00
MDW
24fa28dfe2
Qual: Fix getKanban phpdoc
...
# Qual: Fix getKanban phpdoc
Array phpdoc for getKanban corrections.
2025-02-05 01:43:37 +01:00
Noé
1d1eafb19f
FIX: Add documentation for hte new two params
2025-01-30 17:33:57 +01:00
Noé
ac8557e129
NEW: Add options on intervention clone popup to clone or not contact and notes
2025-01-30 17:24:42 +01:00
Laurent Destailleur (aka Eldy)
f6115ec70b
Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop
2025-01-13 00:07:00 +01:00
Laurent Destailleur (aka Eldy)
3ab49cf061
Debug v21 - Standardize code and translation of RefExt
2025-01-12 18:08:25 +01:00
Laurent Destailleur (aka Eldy)
b024b95948
Fix typo
2025-01-09 19:35:01 +01:00
Laurent Destailleur (aka Eldy)
56710ce9b7
FIX CVE-2024-55227 and CVE-2024-55228 CSRF when
...
MAIN_RESTRICTHTML_ONLY_VALID_HTML_TIDY is
on (hidden option not on by default)
2025-01-09 19:35:01 +01:00
Laurent Destailleur (aka Eldy)
de321e8f01
Fix typo
2025-01-09 02:01:49 +01:00
Laurent Destailleur (aka Eldy)
79ae59ee2a
Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop
2025-01-08 17:54:13 +01:00
Laurent Destailleur (aka Eldy)
c0250e4c91
FIX CVE-2024-55227 CSRF when MAIN_RESTRICTHTML_ONLY_VALID_HTML_TIDY is
...
on (hidden option not on by default)
2025-01-08 17:41:45 +01:00
Laurent Destailleur (aka Eldy)
25a033c64e
Rename field to avoid conflict.
2025-01-05 13:53:16 +01:00
Frédéric FRANCE
57d121664f
set object entity at create ( #32019 )
...
* set object entity at create
* set object entity at create
* set object entity at create
* set object entity at create
* set object entity at create
* set object entity at create
* do not break multicompany thing
* do not break multicompany thing
* missing translation
* fix phpstan
* doc
* fix entity
* fix set entity
2024-11-21 19:11:32 +01:00
Frédéric FRANCE
273386f52f
display fichinter rec link ( #31767 )
...
* display fichinter rec link
* display fichinter rec link
* display fichinter rec link
* display fichinter rec link
* display fichinter rec link
* display fichinter rec link
2024-11-11 18:26:57 +01:00
Laurent Destailleur
e6f1d4835f
Clean sql code
2024-10-29 02:58:20 +01:00
Laurent Destailleur
109321cc6b
Merge commit
2024-10-24 01:40:45 +02:00
MDW
f3dc9a9e45
Qual: fix phan notices in interface_50_modAgenda_ActionsAuto.class ( #31478 )
...
# Qual: fix phan notices in interface_50_modAgenda_ActionsAuto.class
Fix several notices in interface_50_modAgenda_ActionsAuto.class with typing hints.
2024-10-24 01:32:10 +02:00
Laurent Destailleur
b45811b356
Removed not used property
2024-10-24 01:26:53 +02:00
MDW
1834c37c16
Qual: Fix phan notices ( #31212 )
...
* Qual: Fix phan notices
# Qual: Fix phan notices
Fix several phan notices related to classes with UnknownObject
classes.
* Qual: Fix phan notices
* Qual: Fix phan notices
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-10-03 19:40:34 +02:00
MDW
5e02bec9df
Qual: Fix getTooltipContentArray typing hints ( #31081 )
...
* Qual: Fix getTooltipContentArray typing hints
# Qual: Fix getTooltipContentArray typing hints
This defines the aray type for all getTooltipContentArray occurences
* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
Laurent Destailleur
a0fe8e4884
Add constant for the moment
2024-09-18 15:55:20 +02:00
William Mead
e644f05f98
Qual clean use of CommonSignedObject trait ( #30927 )
...
* Cleaned & refactored code to make full use of CommonSignedObject trait
* Fixed Phan warning
* Revert "Fixed Phan warning"
This reverts commit b79b362733 .
* Try @static tag
* Cleaned code
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-13 17:45:05 +02:00
Frédéric FRANCE
2a6bbf88df
fix phpstan ( #30944 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-13 17:40:03 +02:00
William Mead
93b93e8c3f
Qual intervention deprecated warnings ( #30935 )
...
* Fixed passing null
* Fixed deprecated $date
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-13 02:52:27 +02:00
MDW
76eaf8bd8d
Qual: Fix phan notices in classes related to class using getNextValue. ( #30925 )
...
* FIX 🛟 phan
* getToolTip() can take null for $coc
* Fix uninitialized vars & arg types
* PHPDoc typing, argument fixes
* PHPDoc typing, argument fixes for AdherentType
* PHPDoc typing, argument fixes for AdherentStats
* Update baseline to enable adherent notices
* Fix PHPDoc typing in api_members
* Minor bug fixes, typing
* PHPDoc api_subscriptions
* PHPDoc Societe
* Ignore empty foreach notice
* Add initialiser
* Categorie is string, old int mode is deprecated
* Fix missing initialisations
* Fix missing initialisations adherents/note
* Fix typing (cast), initialisation of var
* Fix initialisations
* Fix argument types
* Improve array PHPDoc type
* PHPDoc array type
* PHPDoc: Improve typing
* Correct argument type to getNomUrl
* Improve typing for timespent
* Fix typing for getNextValue args
* Improve typing
* Fix typing hints contrat/card
* Update baseline
* Fix typing
* Fix extraparams property typing
* Fix argument typing
* Qual: Correct covariant type
* Impove typing for timespent
* Remove exclusion no longer matched (level 6)
---------
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com >
2024-09-12 21:16:42 +02:00
William Mead
d0c96c99e0
Qual common signed object trait ( #30913 )
...
* Moved signed status properties & methods to reusable class trait
* Cleaned code
* Updated EN localization
* Fixed Phan warnings
* Fixed Phan warnings
* Added type check. Updated PHPDoc.
* Refactored class properties
* Cleaned PHPDoc
* Revert "Refactored class properties"
This reverts commit 1beb40a7
* Reapply "Refactored class properties"
This reverts commit 9e3d9d554c .
* Fixed PHPDoc
* Fixed class file name
2024-09-10 16:22:25 +02:00
William Mead
5f7f0b2e3c
Qual isolate FichinterLigne class to separate file ( #30784 )
...
* Moved FichinterLigne class to separate file
* Fixed class properties PHPDoc
* Updated PHPDoc
* Fixed author id usage
* Fixed user author id
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-29 17:39:17 +02:00
MDW
a8367a6cd8
Qual: Fix getNextValue related phan notices (part2) ( #30752 )
...
* Qual: 🛟 Fix reference to $db with $this->db
# Qual: reference to $db with $this->db
$db was undeclared, use $this->db.
* Fix suspected issue with environment max size and md5sum working on limited files
* Qual: Fix LDAP typing
* Qual: Fix getNextValue related phan notices (part2)
* Update baseline
* Qual: Fix phan notice
2024-08-29 13:34:24 +02:00
William Mead
129bc02b82
Fix intervention list null/empty sign status ( #30783 )
...
* Fixed null sign status
* Updated sign status field label
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-29 09:16:15 +02:00
William Mead
30805c68da
NEW intervention signed status update ( #30629 )
...
* Added confirm_sign, confirm_unsign, sign & unsign actions. Added sign-unsign button.
* Updated create & fetch methods with signed_status
* Added EN localization
* Added intervention signed notification
* Added intervention signed auto event. Updated EN localization. Fixed trigger.
* Cleaned code
* Added signed label to status badge
* Cleaned code
* Added signed statues dictionary. Added method to get signed status label badge.
* Added signed status to intervention list
* Added sign localizations
* Added sign confirm select. Refactored signed statuses dictionary.
* Added method to get localized signed statuses arrray. Refactored code. Added EN localization.
* Fixed signed status update
* Cleaned code
* Updated EN localization
* Cleaned code
* Changed sign workflow to exclude only drafts
* Added signed status change with online sign
* Improved signed status workflow
* Removed db structure changes
* Updated action trigger to FICHINTER_MODIFY
* Updated EN localizations
* Refactored to use FICHINTER_MODIFY trigger with localized context message. Added STATUS_SIGNED_RECEIVER_ONLINE signed status. Updated EN localizations.
* Added STATUS_SIGNED_RECEIVER_ONLINE signed status. Cleaned Ecode.
* Fixed undeclared constant
* Added contributor details
* Updated notification logic to use object context to pass signature status
* Refactored to make use of object context for event notification. Cleaned code.
* Fixed deprecated method
* Cleaned code
2024-08-27 07:01:03 +02:00
thibdrev
3dbd79dad8
qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. ( #30712 )
...
* Update adherent.class.php
* Update adherent_type.class.php
* Update availabilities.class.php
* Update propal.class.php
* Update account.class.php
* Update paymentvarious.class.php
* Update cashcontrol.class.php
* Update localtax.class.php
* Update remisecheque.class.php
* Update bonprelevement.class.php
* Update chargesociales.class.php
* Update contact.class.php
* Update contrat.class.php
* Update commonorder.class.php
* Update timespent.class.php
* Update don.class.php
* Update conferenceorbooth.class.php
* Update expedition.class.php
* Update expensereport.class.php
* Update paymentexpensereport.class.php
* Update fichinter.class.php
* Update fournisseur.commande.class.php
* Update holiday.class.php
* Update evaluation.class.php
* Update job.class.php
* Update position.class.php
* Update skill.class.php
* Update intracommreport.class.php
* Update knowledgerecord.class.php
* Update loan.class.php
* Update mo.class.php
* Update partnership.class.php
* Update inventory.class.php
* Update entrepot.class.php
* Update project.class.php
* Update holiday.class.php - fix phan error
* Update task.class.php
* Update reception.class.php
* Update recruitmentcandidature.class.php
* Update recruitmentjobposition.class.php
* Update paymentsalary.class.php
* Update salary.class.php
* Update supplier_proposal.class.php
* Update ticket.class.php
* Update user.class.php
* Update usergroup.class.php
* Update webportalinvoice.class.php
* Update webportalorder.class.php
* Update webportalpropal.class.php
* Update workstation.class.php
* Update facture.class.php
2024-08-22 03:31:04 +02:00
Frédéric FRANCE
17c887a433
fix typos ( #30630 )
...
* fix typos
* fix typos
2024-08-13 20:29:40 +02:00
MDW
45ed4caeb2
Qual: Enable Phan Simplify rule and fix notices ( #30537 )
...
* Qual: Phan - Enable Simplyfy expression
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Update functions2.lib.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-07 03:05:02 +02:00
MDW
d6948077b2
Qual: Fix spelling/update .pre-commit configuration (versions) ( #30546 )
...
* Qual: Update pre-commit configuration
* Qual: Update spelling
* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
Frédéric FRANCE
f8f2a83323
Clean date ( #30228 )
...
* clean date phpdoc
* add phpdoc
2024-07-01 19:06:24 +02:00
Frédéric FRANCE
741e75ee47
add phpdoc ( #29832 )
...
* add phpdoc
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* add phpdoc
* fix phan
* fix phan
2024-06-04 14:46:54 +02:00
Laurent Destailleur
2a1fd6bc05
Typo
2024-05-05 01:33:48 +02:00
Laurent Destailleur
796440459d
Debug v20
2024-04-22 18:57:21 +02:00
MDW
eb01d15e78
Fix PhanTypeInvalid{Left,Right}OperandOfNumericOp mostly by typing, casting, idate
2024-03-23 02:06:49 +01:00
MDW
d3a58e2e48
Fix $mybool |=... which is binary op, not boolean op
...
# Fix $mybool |=... which is binary op, not boolean op
This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:18 +01:00
evarisk-micka
d43c3227db
Add signed status CRUD to contract and fichinter
2024-03-15 12:12:21 +01:00
MDW
77c10d653e
Qual: set default value to match PHPdoc type
2024-03-11 23:46:52 +01:00
Frédéric FRANCE
fba15178eb
all initAsSpecimen return int ( #28577 )
...
* all initAsSpecimen return int
* all initAsSpecimen return int
* all initAsSpecimen return int
2024-03-02 16:38:35 +01:00
Laurent Destailleur
2807c9410f
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-02-22 00:19:19 +01:00
Laurent Destailleur
32d35d5443
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-02-22 00:18:42 +01:00
Laurent Destailleur
9874d008aa
Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0
2024-02-22 00:16:59 +01:00
Laurent Destailleur
88da45d9dd
Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 17.0
2024-02-22 00:16:14 +01:00
Laurent Destailleur
a76eafa0d4
Merge branch '15.0' of git@github.com:Dolibarr/dolibarr.git into 16.0
2024-02-22 00:15:35 +01:00
Laurent Destailleur
8c2a910a94
Merge branch '14.0' of git@github.com:Dolibarr/dolibarr.git into 15.0
2024-02-22 00:13:59 +01:00
Eric
6defdcd018
better fix with this->entity thanks to regis ( #28331 )
...
* better fix with this->entity thanks to regis
* Update fichinter.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-02-21 17:06:05 +01:00