Frédéric France
17358bb6e4
fix phan
2025-03-01 16:35:22 +01:00
MDW
e1b94b2552
Qual: Fix phan notices in webportal
2025-02-25 17:54:34 +01:00
Laurent Destailleur (aka Eldy)
382394575d
Fix warning
2025-02-12 22:58:51 +01:00
MDW
24fa28dfe2
Qual: Fix getKanban phpdoc
...
# Qual: Fix getKanban phpdoc
Array phpdoc for getKanban corrections.
2025-02-05 01:43:37 +01:00
Laurent Destailleur (aka Eldy)
732f97d73c
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2025-02-05 00:40:06 +01:00
Frédéric FRANCE
f6d49d7acf
Update webportalinvoice.class.php
2025-01-02 10:11:11 +01:00
Frédéric FRANCE
a6e1174f09
Update webportalinvoice.class.php
2025-01-02 10:06:38 +01:00
Frédéric FRANCE
e470d98833
Merge branch 'develop' into fix_phpstan_2024_end_of_year
2025-01-02 09:17:21 +01:00
Frédéric France
e680f93948
fix phpstan
2025-01-01 09:56:46 +01:00
Frédéric France
7bc9057536
fix phpstan
2025-01-01 09:33:57 +01:00
MDW
afc9b928af
Match LibStatut function signature
2024-12-31 15:26:23 +01:00
MDW
ec2a1928ba
Qual: Update fields phpdoc to include fields that are defined/used in some cases
...
# Qual: Update fields phpdoc to include fields that are defined/used in some cases
comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
2024-12-05 02:36:50 +01:00
Laurent Destailleur
a2dce69dbe
Fix a login is not a case sensitive data #31864
2024-11-16 00:33:54 +01:00
MDW
278d301f32
Qual: Fix phan/phpstan notices in class files (part 6) ( #31634 )
...
* Qual: Fix notices for paymentdonation...workstationusergroup.class
* Qual: Fix PhanPluginRedundantReturnComment, update baseline
* Qual: Complete array phpdoc for properties
2024-11-06 23:57:45 +01:00
MDW
178d748cad
Qual: Fix phan/phpstan notices in class files (part 5) ( #31617 )
...
* Qual: fix commonstickergen..don.class
* Fix notifications for pdf_paiement...cronjob.class
* Qual: Fix notifications for emailcollector..price_parser.class
* Ensure that NULL is used in the database when fk's are 0/empty
* Fix notifications for pdf_paiement...cronjob.class
* Cope with updated phpstan, and make fk_origin_stock int in multiple locations
2024-11-06 20:15:15 +01:00
MDW
b91c99b18a
Qual: Fix phan/phpstan notices in class files (part 3) ( #31578 )
...
* fix phpstan in conf class (#31630 )
* fix phpstan
* fix phan
* Fix merge
* Qual: Avoid notification with typing hint
* Qual: Fix notices link.class
* Qual: Fix notices link..socialneetworkmanager.class and DoliDb->DoliDB
* Qual: Fix notices for link..utils.class
* Qual: Fix notices for db classes
* Update translate.class.php
* Update translate.class.php
---------
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com >
Co-authored-by: Laurent Destailleur <eldy@users.sourceforge.net >
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-10-29 22:44:47 +01:00
Frédéric FRANCE
7dfa9b7d33
remove unused code ( #31610 )
...
* remove unused code
* remove unused code
* fix typo
* fix
* fix
* fix
2024-10-28 19:49:01 +01:00
Frédéric FRANCE
a2d4f3a039
fix phpstan ( #31583 )
2024-10-27 00:56:22 +02:00
Frédéric FRANCE
c0a5e58a41
fix phpstan add exclude for level 6 ( #31482 )
...
* fix phpstan add exclude for level 6
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-10-24 02:51:38 +02:00
MDW
53cfbc35be
Qual: Fix several phan & stan notices ( #31308 )
...
* Qual: Fix several phan & stan notices
# Qual: Fix several phan & stan notices
Several fixes in files while fixing UnknownClass notices
* Qual: Update prepare_head PHPDoc return types
# Qual: Update prepare_head PHPDoc return types
Provide detailed array return types for prepare_head functions.
* Fix new phan notice
* Better loadLangs typing and fix call to loadLangs
* Fix new issues (stats)
* Other fixes of new issues
* Qual: update phan baseline
2024-10-14 01:59:44 +02:00
MDW
1834c37c16
Qual: Fix phan notices ( #31212 )
...
* Qual: Fix phan notices
# Qual: Fix phan notices
Fix several phan notices related to classes with UnknownObject
classes.
* Qual: Fix phan notices
* Qual: Fix phan notices
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-10-03 19:40:34 +02:00
Frédéric FRANCE
c757f684f3
fix phpdoc ( #31195 )
...
* fix phpdoc
* Update context.class.php
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
2024-09-30 10:07:20 +02:00
MDW
42bb4fbf3e
Qual: Enable & fix or ignore Invalid DimOffset ( #31176 )
...
* Qual: Enable & fix or ignore Invalid DimOffset
# Qual: Enable & fix or ignore Invalid DimOffset
The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.
This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later
* Nullable object typing in function signature not ok for 7.0/8.4
Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-29 21:52:31 +02:00
MDW
5e02bec9df
Qual: Fix getTooltipContentArray typing hints ( #31081 )
...
* Qual: Fix getTooltipContentArray typing hints
# Qual: Fix getTooltipContentArray typing hints
This defines the aray type for all getTooltipContentArray occurences
* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
Frédéric FRANCE
000173c7b9
fix phpstan ( #31075 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-23 01:59:14 +02:00
Frédéric FRANCE
5fd996821b
fix phpstan ( #30962 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* Update html.formadmin.class.php
2024-09-17 02:54:44 +02:00
lvessiller-opendsi
37256a47a4
FIX move tr position for signature link in proposals list of WebPortal ( #30978 )
2024-09-17 02:31:02 +02:00
Laurent Destailleur
c617ab7c0e
Debug webportal module Fix #30981
2024-09-17 02:25:45 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) ( #30649 )
...
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-05 16:05:37 +02:00
thibdrev
3dbd79dad8
qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. ( #30712 )
...
* Update adherent.class.php
* Update adherent_type.class.php
* Update availabilities.class.php
* Update propal.class.php
* Update account.class.php
* Update paymentvarious.class.php
* Update cashcontrol.class.php
* Update localtax.class.php
* Update remisecheque.class.php
* Update bonprelevement.class.php
* Update chargesociales.class.php
* Update contact.class.php
* Update contrat.class.php
* Update commonorder.class.php
* Update timespent.class.php
* Update don.class.php
* Update conferenceorbooth.class.php
* Update expedition.class.php
* Update expensereport.class.php
* Update paymentexpensereport.class.php
* Update fichinter.class.php
* Update fournisseur.commande.class.php
* Update holiday.class.php
* Update evaluation.class.php
* Update job.class.php
* Update position.class.php
* Update skill.class.php
* Update intracommreport.class.php
* Update knowledgerecord.class.php
* Update loan.class.php
* Update mo.class.php
* Update partnership.class.php
* Update inventory.class.php
* Update entrepot.class.php
* Update project.class.php
* Update holiday.class.php - fix phan error
* Update task.class.php
* Update reception.class.php
* Update recruitmentcandidature.class.php
* Update recruitmentjobposition.class.php
* Update paymentsalary.class.php
* Update salary.class.php
* Update supplier_proposal.class.php
* Update ticket.class.php
* Update user.class.php
* Update usergroup.class.php
* Update webportalinvoice.class.php
* Update webportalorder.class.php
* Update webportalpropal.class.php
* Update workstation.class.php
* Update facture.class.php
2024-08-22 03:31:04 +02:00
MDW
ca414de526
Qual: Fix $fields related notices with Phan ( #30704 )
...
* Qual: Typing hints/ignore directives for phan notices
* Update field typing
2024-08-21 13:23:35 +02:00
MDW
54880f92cd
Qual: Fix PhanTypeMismatchProperty and some other phan notices ( #30542 )
...
* Qual: Fix PhanTypeMismatchProperty and some other phan notices
* Qual: Phan fixes for BOM
* Phan - fix fields
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Fix $fields phpdoc
* Fix phan typing issues with intermediate var and ??
* Fix phan typing issue with ?? operator
* Ignore htdocs/install/install.forced.php for git
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Update baseline
* Qual: Phan fixes for BOM
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration
* Fix typing hints (phpstan)
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-15 17:05:00 +02:00
MDW
e570f59e2d
Qual: Phan fixes (mainly Initial type cannot be inferred) in popular changed classes ( #30604 )
...
* Update setValueFrom $id type to include null
* Only 2 arguments for ModeleNumRefMembers::getToolTip
* Fix PhanTypeConversionFromArray
* Only 6 args for PaymentSalary::addPaymentToBank
* Fix typing hints (array -> string)
* Fix uninitialized variables
* Add cssview to attributes phpdoc
* Avoid double typing specification (Phan notice)
* Qual: Ensure variable is defined (phan)
* Ensure phpdoc typing for verif method
* Ensure phpdoc typing for getNextValue method
* Add status as data key in cols array
* Ensure preg_replace operates on string (phan)
* Correct type for desiredstock
* Fix typing with casts (phan)
* Fix check that notification already exists
* Initialise fk_parent_id to fix typing issue
* Qual: Fix phan notices for Societe & related
* Qual: Fix typing for Facture and related
* Qual: Fix typing for Product & related
* Update baseline
* Fix new phpstan notices
2024-08-14 01:24:55 +02:00
MDW
45ed4caeb2
Qual: Enable Phan Simplify rule and fix notices ( #30537 )
...
* Qual: Phan - Enable Simplyfy expression
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Update functions2.lib.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-07 03:05:02 +02:00
MDW
d6948077b2
Qual: Fix spelling/update .pre-commit configuration (versions) ( #30546 )
...
* Qual: Update pre-commit configuration
* Qual: Update spelling
* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
Laurent Destailleur
147a8bfaee
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
...
Conflicts:
htdocs/adherents/subscription/list.php
htdocs/categories/viewcat.php
htdocs/contrat/card.php
htdocs/contrat/list.php
htdocs/eventorganization/conferenceorbooth_list.php
htdocs/expedition/list.php
htdocs/societe/card.php
2024-07-11 10:44:39 +02:00
Laurent Destailleur
8a4f550d64
Debug v20
2024-07-09 17:33:27 +02:00
Laurent Destailleur
9af159cdd8
Replace "! empty($conf->global->$" with "getDolGlobalString($"
2024-07-03 20:05:29 +02:00
Frédéric FRANCE
2f5647e4e3
fix checkFunctionArgumentTypes ( #30234 )
...
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* add ignore
* add ignore
add ignore
add ignore
add ignore
add ignore
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
2024-07-03 02:30:53 +02:00
Alexandre SPANGARO
96afcaa476
Better comments ( #30200 )
...
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* CI Missing language key
* Update eventorganization.lang
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-06-30 21:02:50 +02:00
Frédéric FRANCE
4b275dc148
add phpdoc ( #30208 )
...
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* clean phpdoc
2024-06-30 19:39:01 +02:00
Zephyriony
9c30f1d30d
NEW : Sign propal from the web portal ( #30062 )
...
* NEW : Sign propal from the web portal
* Update html.formlistwebportal.class.php
* Update html.formlistwebportal.class.php
* Update html.formwebportal.class.php
* Update html.formwebportal.class.php
* Update html.formlistwebportal.class.php
* Update html.formwebportal.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-06-19 20:08:20 +02:00
Frédéric FRANCE
efdc7f92b9
fix phpstan empty oldcopy is not falsy ( #30049 )
...
* fix phpstan empty olcopy is not falsy
* fix phpstan empty olcopy is not falsy
* remove code not used
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-06-17 13:22:20 +02:00
Laurent Destailleur
0a4735fdaa
Fix phpunit
2024-06-17 13:13:05 +02:00
Laurent Destailleur
239b4bcc6e
Debug v20
2024-06-16 12:23:12 +02:00
Frédéric FRANCE
f9264de0dc
fix cti ( #29837 )
2024-06-04 19:23:04 +02:00
Laurent Destailleur
82908a30eb
Clean phan warnings
2024-05-30 13:37:17 +02:00
Laurent Destailleur
a05c03ff4e
Debug v20
2024-05-07 10:47:23 +02:00
Laurent Destailleur
642f70e152
Debug v20
2024-05-07 10:27:17 +02:00
Frédéric FRANCE
d0830b3159
fix phpstan ( #29602 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
fix phpstan
fix phpstan
fix phpstan
fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-05-05 00:34:19 +02:00
