2
0
forked from Wavyzz/dolibarr
Commit Graph

13514 Commits

Author SHA1 Message Date
MDW
be23366e51 Fix: Check that certain properties exists before trying isset.
# Fix: Check that certain properties exists before trying isset.

Avoids triggering an undefined property notice from the DolDeprecationHandler
2024-03-24 17:39:03 +01:00
MDW
a6d4a99cca NEW: DolDeprecationHandler for deprecations
# NEW: DolDeprecationHandler for deprecations

This reusable class avoids needed to implement double assignments while enabling
the detection of the use of deprecated variables and methods.

There is no efficiency overhead when the proper variables and methods are
used.
2024-03-24 17:39:02 +01:00
Laurent Destailleur
841427601f Merge pull request #29037 from mdeweerd/fix/PhanTypeInvalidPropertyName
Fix & Enable PhanTypeInvalidPropertyName
2024-03-24 14:56:42 +01:00
Laurent Destailleur
2fc1e4ba60 Merge pull request #29044 from mdeweerd/fix/phan20240324
Fix Phan notices
2024-03-24 14:56:17 +01:00
Laurent Destailleur
35e353cf0a Clean global variable non required 2024-03-24 14:54:36 +01:00
MDW
8b960280d9 PHPdoc Allow empty array for + PHPdoc improvements 2024-03-24 14:09:32 +01:00
MDW
43addc08cb Add PHPdoc typing 2024-03-24 11:03:04 +01:00
Laurent Destailleur
072c3070b3 Add phpunit for Expedition 2024-03-24 06:23:56 +01:00
Laurent Destailleur
59c87c7cb6 Clean usage of ->origin_object instead of ->origin that was a string. 2024-03-24 06:12:18 +01:00
Laurent Destailleur
150845cd02 Debug v20 2024-03-24 05:23:06 +01:00
Laurent Destailleur
66c01b8e85 Merge branch 'develop' into addLayoutForWebsite 2024-03-24 02:28:07 +01:00
Laurent Destailleur
6a0678e717 Merge branch 'develop' into PhanTypeInvalidRightOperandOfNumericOp 2024-03-23 17:36:29 +01:00
Laurent Destailleur
8906df343a NEW Add option THIRDPARTY_MIN_NB_PROF_ID and THIRDPARTY_MAX_NB_PROF_ID 2024-03-23 16:01:41 +01:00
MDW
886b4c8cc1 Fix PhanTypeInvalid{Left,Right}OperandOfNumericOp mostly by typing, casting, idate 2024-03-23 02:06:39 +01:00
MDW
d9d09ce7e9 Fix PhanTypeInvalid{Left,Right}OperandOfNumericOp mostly by typing, casting, idate 2024-03-23 02:06:38 +01:00
MDW
f5e2444a2c Add typing for cols, phpmin 2024-03-23 01:49:52 +01:00
Laurent Destailleur
84b7eaa65f Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-22 18:15:37 +01:00
Laurent Destailleur
0bf2f3b70d Fix warning 2024-03-22 18:15:24 +01:00
MDW
7a42dab6d2 Fix PHPdoc typing 2024-03-22 09:52:37 +01:00
MDW
4d56da4e8c Fix typing with casts 2024-03-22 09:51:52 +01:00
MDW
4b438b4204 Fix typing with idate 2024-03-22 09:51:51 +01:00
MDW
91a7f3b721 Fix typing with casting and idate 2024-03-22 09:51:50 +01:00
Laurent Destailleur
51a3641105 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	htdocs/bom/tpl/objectline_create.tpl.php
	htdocs/compta/bank/releve.php
	htdocs/core/class/html.formsetup.class.php
	htdocs/takepos/freezone.php
2024-03-22 02:35:37 +01:00
Laurent Destailleur
b658bde88a Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
Conflicts:
	htdocs/core/class/html.formsetup.class.php
	htdocs/takepos/index.php
2024-03-22 02:11:58 +01:00
Laurent Destailleur
7b0177a84d Move to getDolGlobalString 2024-03-22 00:37:56 +01:00
Lamrani Abdel
880b5f2623 remove var_dump 2024-03-21 17:46:12 +01:00
Lamrani Abdel
f96f4fd3e9 Merge branch 'develop' of https://github.com/Dolibarr/dolibarr into addLayoutForWebsite 2024-03-21 17:36:17 +01:00
Lamrani Abdel
469735c74c remove var_dump 2024-03-21 17:35:31 +01:00
MDW
2ec5504dcb Fix $mybool |=... which is binary op, not boolean op
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:12 +01:00
Regis Houssin
5ffdc44952 FIX missing entity parameter for ajax_constantonoff 2024-03-21 13:35:51 +01:00
Lamrani Abdel
b5903da492 NEW preview exemple page in website when create page 2024-03-21 03:47:16 +01:00
MDW
53c628f219 Cast DolEditor::Create to string to avoid mistyping as void 2024-03-20 23:54:33 +01:00
MDW
44ef0de1ef Fix null return by initialising return value, forcing type 2024-03-20 23:54:31 +01:00
MDW
6bfdc4655f Disable ignores phan's baseline.txt (fixed) 2024-03-20 21:58:43 +01:00
MDW
9f7b0fb326 Fix PhanTypeMismatchReturnNullable by adding die() in final else condition as well 2024-03-20 21:58:38 +01:00
MDW
7e1bf61c0d Fix PhanTypeMismatchReturnNullable with init 2024-03-20 21:58:37 +01:00
Laurent Destailleur
e3c76ca86a Clean translation files 2024-03-20 15:25:47 +01:00
MDW
826a349177 Merge branch 'develop' into fix/PhanTypeMismatchInternal3 2024-03-20 11:45:15 +01:00
iouston
73436bc625 update filter example
((s.client IN (1,3) AND s.status=1)) give an sql error bad syntax on filter use ((s.client:IN:1,2,3) AND (s.status:=:1)) is ok
2024-03-20 10:15:10 +01:00
MDW
c6cfba4ff0 Fix arg type to strlen/strlen by casting + minor layout fix 2024-03-20 04:08:25 +01:00
MDW
045810e219 Fix $pdf typing on methods 2024-03-19 22:52:25 +01:00
MDW
f03e0f4cc9 Fix arg type for strcmp() with casts 2024-03-19 20:38:53 +01:00
MDW
26ccab2fc3 Fix arg type for strlen() with algorithm, cast for preg_match() 2024-03-19 20:38:52 +01:00
MDW
2215fc748b Fix arg type for str_replace() with casts 2024-03-19 20:38:51 +01:00
MDW
dacf116d07 Fix arg type for abs(), str_replace() with casts 2024-03-19 20:38:50 +01:00
MDW
0975a31b05 Fix arg type for trim() by casting to string 2024-03-19 20:38:49 +01:00
MDW
8ea06e9455 Fix arg type for preg_replace() by casting to string 2024-03-19 20:38:49 +01:00
MDW
267961d33b fixup! Correct typing for tva_tx 2024-03-19 20:38:46 +01:00
MDW
adf4805ff4 Correct typing for tva_tx 2024-03-19 20:38:45 +01:00
Laurent Destailleur
10e3627c59 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-19 18:14:07 +01:00