Oliver Lippert
0a41d5eb2c
tell about delivery objecttype tabs ( #30662 )
2024-08-18 16:18:49 +02:00
Laurent Destailleur
72b37a2369
Fix phan
2024-08-18 00:01:45 +02:00
Laurent Destailleur
7ea04ab0af
Clean code
2024-08-17 23:59:08 +02:00
Laurent Destailleur
3114d1d13e
Clean code
2024-08-17 23:46:16 +02:00
MDW
75ed925f06
Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") ( #30563 )
...
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint in phan config to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjects
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Fix: MemberNumRefNumbers getExample does not take any arguments
Found thanks to adding the typing for phan!
* Qual: Correct forced type for $module
* Qual: Ignore phan false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Ignore false positive
* Qual: phan/Ignore false positive, replace depr.prop with method
* Qual: Fix typing for count by adding is_array check
* Qual: replace depr.prop `nom` with method
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Fix depr.prop with getter and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: Improve typing for mymodule template
* Make info method arguments match calls
* Make PrintingDriver abstract class because we added abstract methods
* Add phpdoc typing for phan
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update header wit correct information
* Update getExample method signature
* Update getExample method signature
* Correct reference to class in comment
* Force php phan typing for numbering modules
* Correct $_GLOBALS to $GLOBALS
* Add phpdoc to indicat type of properties
* Correct default to null
* Improve getNextValue typehint
* Improve getNextValue typehint
* Qual: Improve ModeleNumRefTakepos typing
* Qual: Improve ModeleNumRefRecruitmentJobPosition typing
* Fix default for $langs
* Do not use non-existing ModeleNumRefTakepos::nom
* Allow getNextValue argument to be null
* Correct $_GLOBAL into $GLOBALS
* Improve typing for ldap functions
* Allow null for outputlangs argument
* Improve typing for printOriginLine
* Improve typing for linkedObject access
* Fix PhanTypeMismatchArgumentNullableInternal and optimize
* Fix PhanPossiblyUndeclaredVariable by setting default value
* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4
* getToolTip does not accept null, changed to ''
* Improve getNextValue typing
* Change PrintingDriver back to normal class (instantiated)
And add errors for functions that should be overloaded
* Adjust pringOriginLine typing to match parent
* Fix phpdoc for getNextValue
* Fix phan typing
* Add/Improve phpdoc typing hints
* Qual: Adjustments to match typing
* Update typing for unit, use GETPOSTINT
* ModeleNumRefTask needs Project
* Fix several notices appearing after update from develop
* Index for choices is int, use GETPOSTINT
* Qual: Ignore empty foreach
* Force BOMLine on object line
* phan typing to indicate that linked objects are BOM
* Type the correct variable name (phan)
* Add typing for $langs
* Type to CommonNumRefGenerator (no class for availabilities)
* Resolve several phan notices after update from dev branch
* Extra typing fixes
* Move common attributes to parent class (phan)
* Add typing to Calendar class
* Improve typing hints
* Add typing to pdf_eagle_proforma
* Qual: Add typing for token in generic_oauthcallback.php
* Add typing for objMod
* Correct getNextValue function signature (phpstan)
* Fix typing (phpstan)
* Update version declarations (fix phpstan)
* Fix phpstan typing issues
* Adjust typing (phpstan)
* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
Laurent Destailleur
13d61527c9
Debug module intracommreport
2024-08-17 19:18:00 +02:00
Laurent Destailleur
31112fa467
Debug module intracommreport
2024-08-17 18:55:29 +02:00
MDW
e570f59e2d
Qual: Phan fixes (mainly Initial type cannot be inferred) in popular changed classes ( #30604 )
...
* Update setValueFrom $id type to include null
* Only 2 arguments for ModeleNumRefMembers::getToolTip
* Fix PhanTypeConversionFromArray
* Only 6 args for PaymentSalary::addPaymentToBank
* Fix typing hints (array -> string)
* Fix uninitialized variables
* Add cssview to attributes phpdoc
* Avoid double typing specification (Phan notice)
* Qual: Ensure variable is defined (phan)
* Ensure phpdoc typing for verif method
* Ensure phpdoc typing for getNextValue method
* Add status as data key in cols array
* Ensure preg_replace operates on string (phan)
* Correct type for desiredstock
* Fix typing with casts (phan)
* Fix check that notification already exists
* Initialise fk_parent_id to fix typing issue
* Qual: Fix phan notices for Societe & related
* Qual: Fix typing for Facture and related
* Qual: Fix typing for Product & related
* Update baseline
* Fix new phpstan notices
2024-08-14 01:24:55 +02:00
Frédéric FRANCE
32839b138b
fix phpstan level 5 ( #30565 )
...
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phpstan level 5
* fix phan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
fix phpstan
fix phpstan
fix phpstan
* increase level for apstat
2024-08-13 23:16:09 +02:00
MDW
d6948077b2
Qual: Fix spelling/update .pre-commit configuration (versions) ( #30546 )
...
* Qual: Update pre-commit configuration
* Qual: Update spelling
* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
Laurent Destailleur
d1f1c0aa57
Clean code - Fix phpstan warning
2024-08-03 13:44:38 +02:00
Laurent Destailleur
f002fb4ed1
Use the non deprecated function loadRights instead of getrights
2024-08-02 10:36:43 +02:00
Laurent Destailleur
cbc28b0afd
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2024-08-01 14:02:36 +02:00
Laurent Destailleur
269a8a2fa1
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2024-08-01 13:36:59 +02:00
Laurent Destailleur
faac9602f8
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-08-01 13:31:51 +02:00
MDW
46eb5f83c2
Qual: Updates for phpstan notices ( #30509 )
...
* Fix int<0> typing to int<0,0> for phpstan
* Fix phpdoc for phpstan
* Fix phpdoc for phpstan
* Qual: Several phpstan notice fixes
* Fix phpdoc
* Qual: totalpaid is never null, remove null test
* improve phpdoc typing
* Also return null to statisfy phpstan
* Allow null value for $var
* object->Object to make it meaningful
* Type EvalMathStack properties
* Comment out unused private methods (phpstan)
* Changes for phpstan (return values, phpdoc, code)
* Change order of tests for phpstan
* phpdoc object to Object for correct typing
* Typing hing for phpstan
* UPdate test for phpstan
* Change phpdoc position for phpstan
* Update phpdoc for phpstan
This needs further improvement
* Change $op to $ope to fix phpstan
* Update sqlite3.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-01 12:59:45 +02:00
Francis Appels
dc58a90a48
Fix modulebuilder MAIN_ODT_AS_PDF ( #30496 )
2024-07-31 15:35:15 +02:00
Laurent Destailleur
871e01d955
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-31 14:32:55 +02:00
Laurent Destailleur
09eaf38bd1
Fix phpstan
2024-07-31 14:31:29 +02:00
Laurent Destailleur
d2bd6a03ec
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-31 13:21:02 +02:00
Laurent Destailleur
2f7a252244
Fix warnings
2024-07-31 13:09:10 +02:00
Laurent Destailleur
038ce032e0
Fix tooltip on numbering modules
2024-07-31 12:40:24 +02:00
Laurent Destailleur
a701f84543
Fix tooltip on numbering modules
2024-07-31 12:14:39 +02:00
Lucas Marcouiller
a4908abc8a
New Main checkbox left column to manage this conf for each users ( #30439 )
...
Co-authored-by: Hystepik <lmarcouiller@nltechno.com >
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-07-26 05:01:26 +02:00
Laurent Destailleur
c9b92bb32d
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-25 18:21:47 +02:00
Laurent Destailleur
6b076821e3
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2024-07-25 18:20:01 +02:00
Laurent Destailleur
f4611fcec9
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-07-25 18:06:37 +02:00
Thibault Fiacre
7c9e6b1fb9
FIX lang output for sales representative on PDF ( #30469 )
2024-07-25 17:56:13 +02:00
Laurent Destailleur
74cbae2579
Code comment
2024-07-25 14:28:18 +02:00
Laurent Destailleur
5513b573b0
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-24 04:06:06 +02:00
Laurent Destailleur
8a257ac93f
Fix permission to edit email template - Debug v20
2024-07-23 02:12:46 +02:00
Laurent Destailleur
147a8bfaee
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
...
Conflicts:
htdocs/adherents/subscription/list.php
htdocs/categories/viewcat.php
htdocs/contrat/card.php
htdocs/contrat/list.php
htdocs/eventorganization/conferenceorbooth_list.php
htdocs/expedition/list.php
htdocs/societe/card.php
2024-07-11 10:44:39 +02:00
Laurent Destailleur
8a4f550d64
Debug v20
2024-07-09 17:33:27 +02:00
Frédéric FRANCE
2707475a12
fix phpstan ( #30319 )
...
* fix phpstan
* fix phpstan expects int, false given ...
* fix phpstan expects int, true given ...
2024-07-08 21:45:35 +02:00
Frédéric FRANCE
29f223fd3c
fix checkFunctionArgumentTypes ( #30249 )
...
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
2024-07-04 17:47:31 +02:00
Laurent Destailleur
253fdba882
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-02 23:11:21 +02:00
Laurent Destailleur
a75d6e6ffe
Finished the groupby experimental into project list
2024-07-02 18:46:20 +02:00
Alexandre SPANGARO
96afcaa476
Better comments ( #30200 )
...
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* CI Missing language key
* Update eventorganization.lang
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-06-30 21:02:50 +02:00
Frédéric FRANCE
4b275dc148
add phpdoc ( #30208 )
...
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* clean phpdoc
2024-06-30 19:39:01 +02:00
Frédéric FRANCE
3e750c2f0b
ignore more phan lines with phpstan ( #30135 )
...
* ignore more phan lines with phpstan
* fix
2024-06-23 17:46:34 +02:00
Laurent Destailleur
6a12de58ed
Introduce length of field in fields array
2024-06-23 13:24:26 +02:00
Laurent Destailleur
c936c4b4b4
Look and feel v20
2024-06-19 02:58:06 +02:00
Laurent Destailleur
a618bf2ae6
Debug v20
2024-06-18 09:54:11 +02:00
Laurent Destailleur
83f9854423
Doc
2024-06-10 16:12:22 +02:00
Mathieu Moulin
abcb1dad4b
Define CommonObject relation in CommonObjectLine classes ( #29956 )
2024-06-10 16:08:39 +02:00
Frédéric FRANCE
74806473ab
fix cti ( #29842 )
...
* fix cti odt asset
* comment unused code in template
* phpdoc
* fix unreachable code
* fix unreachable code
* fix not falsy
2024-06-05 14:55:07 +02:00
Frédéric FRANCE
d7a88a40a2
fix cti in odt template ( #29840 )
...
* fix cti in odt template
* fix cti in odt recruitment
2024-06-04 19:29:25 +02:00
Kusco
8e8fdccec7
#29103 Fix error in export part of the builder module ( #29835 )
...
In the builder module, suggestions are offered by default.
Just remove the comments for this to work.
Except for this line:
//$this->export_sql_end[$r] =' LEFT JOIN '.MAIN_DB_PREFIX.'competence_line as tl ON tl.fk_competence = t.rowid';
A "point" is missing before the "equal":
//$this->export_sql_end[$r] .=' LEFT JOIN '.MAIN_DB_PREFIX.'competence_line as tl ON tl.fk_competence = t.rowid';
The problem is the overwriting of part of the query, if we want to couple other tables.
2024-06-04 14:49:25 +02:00
Laurent Destailleur
dc024a1f18
Debug v20
2024-05-30 14:43:16 +02:00
Laurent Destailleur
48c5d9b0bc
Debug v20
2024-05-29 12:26:04 +02:00
