Wavyzz/dolibarr-fork
2
0
Fork 0
forked from Wavyzz/dolibarr
Code Pull Requests Activity
138,397 Commits 36 Branches 189 Tags
d97ff764ab91f0df49f58489a79c971b03f23d8d
Commit Graph

1914 Commits

Author SHA1 Message Date
MDW
53cfbc35be Qual: Fix several phan & stan notices (#31308) 
* Qual: Fix several phan & stan notices

# Qual: Fix several phan & stan notices

Several fixes in files while fixing UnknownClass notices

* Qual: Update prepare_head PHPDoc return types

# Qual: Update prepare_head PHPDoc return types

Provide detailed array return types for prepare_head functions.

* Fix new phan notice

* Better loadLangs typing and fix call to loadLangs

* Fix new issues (stats)

* Other fixes of new issues

* Qual: update phan baseline
 2024-10-14 01:59:44 +02:00
Laurent Destailleur
70484d99a4 Setup help 2024-10-04 17:49:05 +02:00
MDW
1834c37c16 Qual: Fix phan notices (#31212) 
* Qual: Fix phan notices

# Qual: Fix phan notices

Fix several phan notices related to classes with UnknownObject
classes.

* Qual: Fix phan notices

* Qual: Fix phan notices

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-10-03 19:40:34 +02:00
Frédéric FRANCE
f3d3573bfb fix phpstan (#31194) 
* fix phpstan

* fix phpstan

* fix phpstan
 2024-09-30 10:07:04 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176) 
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-09-29 21:52:31 +02:00
MDW
c62e015410 Qual: Fix (propal|facture|contrat|fichinter)/card, commonobject, files.lib/card_presend.tpl (#31087) 
# Qual: Fix (propal|facture|contrat|fichinter)/card, commonobject, files.lib/card_presend.tpl

Fix phan notices in these files

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-09-26 23:01:02 +02:00
Lucas Marcouiller
e736235a30 Qual create button to factorize services buttons in ficheinter/card.php (#31065) 
* Qual create button to factorize services buttons in ficheinter/card.php

* Fix Ci

---------

Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-09-26 21:36:49 +02:00
Laurent Destailleur
b32225283d Merge branch '20.0' of github.com:Dolibarr/dolibarr into develop 2024-09-25 22:32:36 +02:00
Laurent Destailleur
e0e0b669a9 FIX edit contract of intervention broken by CSRF protection 2024-09-25 19:37:32 +02:00
Laurent Destailleur
336b723ab8 FIX edit contract of intervention broken by CSRF protection 2024-09-25 19:37:01 +02:00
Laurent Destailleur
59dadd88a3 FIX Duplicate trigger printFieldPreListTitle 2024-09-25 13:43:11 +02:00
MDW
5e02bec9df Qual: Fix getTooltipContentArray typing hints (#31081) 
* Qual: Fix getTooltipContentArray typing hints

# Qual: Fix getTooltipContentArray typing hints

This defines the aray type for all getTooltipContentArray occurences

* Ignore undeclared property ref_supplier (does not exist on OrderLine)
 2024-09-23 03:24:19 +02:00
MDW
7b4c4d772c Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related (#31086) 
* Qual: Fix Array of tabs typing hints

# Qual: Fix Array of tabs typing hints

Fixed same typing hints accross several files

* Qual: Fix pdf.lib.php, project.lib.php and related files

# Qual: Fix pdf.lib.php, project.lib.php and related files

Fix most phan notices for pdf.lib.php and project.lib.php.
And fixed some items in other files in the process

* Qual: Fix notifications commande/card advtarget.tpl fichinter/card societe/card supplier_proposal/card

* Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related

# Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related

Fix notices in the files for the classes above and other files to accomodate
these changes/fixes
 2024-09-23 00:37:30 +02:00
Laurent Destailleur
a0fe8e4884 Add constant for the moment 2024-09-18 15:55:20 +02:00
Frédéric FRANCE
d5fe4f998a fix phpstan (#30989) 
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
 2024-09-18 02:45:54 +02:00
MDW
115627a054 Qual: Fix PhanPluginUnknownObjectMethodCall where is the only phan notice (#30957) 
* Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

# Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

Fix PhanPluginUnknownObjectMethodCall in files where it is the only phan notice

* Update phan baseline

* Fix $website global type in some contexts
 2024-09-16 01:49:38 +02:00
William Mead
e644f05f98 Qual clean use of CommonSignedObject trait (#30927) 
* Cleaned & refactored code to make full use of CommonSignedObject trait

* Fixed Phan warning

* Revert "Fixed Phan warning"

This reverts commit b79b362733.

* Try @static tag

* Cleaned code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-09-13 17:45:05 +02:00
Frédéric FRANCE
2a6bbf88df fix phpstan (#30944) 
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
 2024-09-13 17:40:03 +02:00
William Mead
80ce987ac8 NEW fichinter list disable details option (#30884) 
* Added FICHINTER_DISABLE_DETAILS_ON_LIST option

* Updated changelog

* Refactored option
 2024-09-13 04:09:18 +02:00
William Mead
93b93e8c3f Qual intervention deprecated warnings (#30935) 
* Fixed passing null

* Fixed deprecated $date

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-09-13 02:52:27 +02:00
MDW
76eaf8bd8d Qual: Fix phan notices in classes related to class using getNextValue. (#30925) 
* FIX 🛟 phan

* getToolTip() can take null for $coc

* Fix uninitialized vars & arg types

* PHPDoc typing, argument fixes

* PHPDoc typing, argument fixes for AdherentType

* PHPDoc typing, argument fixes for AdherentStats

* Update baseline to enable adherent notices

* Fix PHPDoc typing in api_members

* Minor bug fixes, typing

* PHPDoc api_subscriptions

* PHPDoc Societe

* Ignore empty foreach notice

* Add initialiser

* Categorie is string, old int mode is deprecated

* Fix missing initialisations

* Fix missing initialisations adherents/note

* Fix typing (cast), initialisation of var

* Fix initialisations

* Fix argument types

* Improve array PHPDoc type

* PHPDoc array type

* PHPDoc: Improve typing

* Correct argument type to getNomUrl

* Improve typing for timespent

* Fix typing for getNextValue args

* Improve typing

* Fix typing hints contrat/card

* Update baseline

* Fix typing

* Fix extraparams property typing

* Fix argument typing

* Qual: Correct covariant type

* Impove typing for timespent

* Remove exclusion no longer matched (level 6)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
 2024-09-12 21:16:42 +02:00
William Mead
d0c96c99e0 Qual common signed object trait (#30913) 
* Moved signed status properties & methods to reusable class trait

* Cleaned code

* Updated EN localization

* Fixed Phan warnings

* Fixed Phan warnings

* Added type check. Updated PHPDoc.

* Refactored class properties

* Cleaned PHPDoc

* Revert "Refactored class properties"

This reverts commit 1beb40a7

* Reapply "Refactored class properties"

This reverts commit 9e3d9d554c.

* Fixed PHPDoc

* Fixed class file name
 2024-09-10 16:22:25 +02:00
William Mead
47b70c2829 Removed unused properties. Updated PHPDoc. (#30897) 2024-09-10 01:02:26 +02:00
Frédéric FRANCE
80d1f47d4d fix ignored phpstan (most of expects string, int given) (#30649) 
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
 2024-09-05 16:05:37 +02:00
Laurent Destailleur
8cdef1d713 NEW Activate PHPUnit with tests on permission on $action ==... 2024-09-03 16:33:02 +02:00
Laurent Destailleur
e7c0913b1f Fix missing tests on permissions 2024-09-03 15:10:13 +02:00
William Mead
5f7f0b2e3c Qual isolate FichinterLigne class to separate file (#30784) 
* Moved FichinterLigne class to separate file

* Fixed class properties PHPDoc

* Updated PHPDoc

* Fixed author id usage

* Fixed user author id

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-29 17:39:17 +02:00
MDW
a8367a6cd8 Qual: Fix getNextValue related phan notices (part2) (#30752) 
* Qual: 🛟 Fix reference to $db with $this->db

# Qual: reference to $db with $this->db

$db was undeclared, use $this->db.

* Fix suspected issue with environment max size and md5sum working on limited files

* Qual: Fix LDAP typing

* Qual: Fix getNextValue related phan notices (part2)

* Update baseline

* Qual: Fix phan notice
 2024-08-29 13:34:24 +02:00
William Mead
129bc02b82 Fix intervention list null/empty sign status (#30783) 
* Fixed null sign status

* Updated sign status field label

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-29 09:16:15 +02:00
William Mead
30805c68da NEW intervention signed status update (#30629) 
* Added confirm_sign, confirm_unsign, sign & unsign actions. Added sign-unsign button.

* Updated create & fetch methods with signed_status

* Added EN localization

* Added intervention signed notification

* Added intervention signed auto event. Updated EN localization. Fixed trigger.

* Cleaned code

* Added signed label to status badge

* Cleaned code

* Added signed statues dictionary. Added method to get signed status label badge.

* Added signed status to intervention list

* Added sign localizations

* Added sign confirm select. Refactored signed statuses dictionary.

* Added method to get localized signed statuses arrray. Refactored code. Added EN localization.

* Fixed signed status update

* Cleaned code

* Updated EN localization

* Cleaned code

* Changed sign workflow to exclude only drafts

* Added signed status change with online sign

* Improved signed status workflow

* Removed db structure changes

* Updated action trigger to FICHINTER_MODIFY

* Updated EN localizations

* Refactored to use FICHINTER_MODIFY trigger with localized context message. Added STATUS_SIGNED_RECEIVER_ONLINE signed status. Updated EN localizations.

* Added STATUS_SIGNED_RECEIVER_ONLINE signed status. Cleaned Ecode.

* Fixed undeclared constant

* Added contributor details

* Updated notification logic to use object context to pass signature status

* Refactored to make use of object context for event notification. Cleaned code.

* Fixed deprecated method

* Cleaned code
 2024-08-27 07:01:03 +02:00
Laurent Destailleur
03ffbd3099 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-27 04:47:33 +02:00
Laurent Destailleur
a48cee090a Better fix for #30756 2024-08-27 04:28:35 +02:00
Laurent Destailleur
ba25c49333 Fix permiss 2024-08-22 14:10:59 +02:00
Laurent Destailleur
d7d1e73ac9 Fix test on permissions 2024-08-22 14:06:29 +02:00
thibdrev
3dbd79dad8 qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. (#30712) 
* Update adherent.class.php

* Update adherent_type.class.php

* Update availabilities.class.php

* Update propal.class.php

* Update account.class.php

* Update paymentvarious.class.php

* Update cashcontrol.class.php

* Update localtax.class.php

* Update remisecheque.class.php

* Update bonprelevement.class.php

* Update chargesociales.class.php

* Update contact.class.php

* Update contrat.class.php

* Update commonorder.class.php

* Update timespent.class.php

* Update don.class.php

* Update conferenceorbooth.class.php

* Update expedition.class.php

* Update expensereport.class.php

* Update paymentexpensereport.class.php

* Update fichinter.class.php

* Update fournisseur.commande.class.php

* Update holiday.class.php

* Update evaluation.class.php

* Update job.class.php

* Update position.class.php

* Update skill.class.php

* Update intracommreport.class.php

* Update knowledgerecord.class.php

* Update loan.class.php

* Update mo.class.php

* Update partnership.class.php

* Update inventory.class.php

* Update entrepot.class.php

* Update project.class.php

* Update holiday.class.php - fix phan error

* Update task.class.php

* Update reception.class.php

* Update recruitmentcandidature.class.php

* Update recruitmentjobposition.class.php

* Update paymentsalary.class.php

* Update salary.class.php

* Update supplier_proposal.class.php

* Update ticket.class.php

* Update user.class.php

* Update usergroup.class.php

* Update webportalinvoice.class.php

* Update webportalorder.class.php

* Update webportalpropal.class.php

* Update workstation.class.php

* Update facture.class.php
 2024-08-22 03:31:04 +02:00
MDW
d71cd352d5 Qual: Fix PhanUndeclaredMethod (#30661) 
* Qual: Fix PhanUndeclaredMethod cases

* Fix PhanUndeclaredMethod cases

* Qual: Remove PhanUndeclaredMethod exceptions

* Fix spelling "disacard"

* Improve phpdoc, add abstract method to trait for typing

* Improve phpdoc typing for PHanUndeclaredMethod

* Suppress phan notices for guarded AliasNbPages calls

* Fix return value for printFile stub

* Fix getting message from Exception

* Define dummy getAllByProducts(), typing for it.

* Fix typo in comment

* Qual: Better typing for apiService (phan)

* Test that the Generic OAuth Service is provided

* Qual: Fix getSqlArrayForStats typing

* Force modTcpdfbarcode

* Correct typing hint

* Set ModelePDFAsset typehint

* Fix ModelePDFUserGroup typing hint

* Fix phan typing hints htdocs/core/modules/printing/printgcp.modules.php

* Fix write_file in ModelePDFStock*

* Update printsheet.php

* Adjust typing hint for barcode generator

* Update printsheet.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-19 02:05:27 +02:00
MDW
203cbb7023 Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp (#30557) 
* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Update phan baseline (remove PhanTypeInvalidLeftOperandOfNumericOp)

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Fix: Change argument '' to null as by getAvailableDiscounts signature

* Qual: Cast '' to float for Phan notice

* Fix: Convert $number with price2num before using this parameter

* Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

# Qual: Fix PhanTypeInvalidLeftOperandOfNumericOp

These changes ensure that the left operand is a numeric value

* Add cast to ensure fmod is presented with floats
 2024-08-15 16:57:02 +02:00
Frédéric FRANCE
17c887a433 fix typos (#30630) 
* fix typos

* fix typos
 2024-08-13 20:29:40 +02:00
MDW
45ed4caeb2 Qual: Enable Phan Simplify rule and fix notices (#30537) 
* Qual: Phan - Enable Simplyfy expression

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Update functions2.lib.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-07 03:05:02 +02:00
Laurent Destailleur
688a5e0eb3 Merge remote-tracking branch 'origin/20.0' into develop 2024-08-07 02:15:03 +02:00
Laurent Destailleur
a70eece027 Fix setting nb_max_gen 2024-08-07 02:14:00 +02:00
MDW
d6948077b2 Qual: Fix spelling/update .pre-commit configuration (versions) (#30546) 
* Qual: Update pre-commit configuration

* Qual: Update spelling

* Ignore use of deprecated constant
 2024-08-07 01:20:43 +02:00
atm-lena
061f221bc0 NEW llxHeader CSS body (#30380) 
Co-authored-by: atm-lena <lena.papazian@atm-consulting.fr>
 2024-07-15 20:55:13 +02:00
Laurent Destailleur
147a8bfaee Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 
Conflicts:
	htdocs/adherents/subscription/list.php
	htdocs/categories/viewcat.php
	htdocs/contrat/card.php
	htdocs/contrat/list.php
	htdocs/eventorganization/conferenceorbooth_list.php
	htdocs/expedition/list.php
	htdocs/societe/card.php
 2024-07-11 10:44:39 +02:00
Alexandre SPANGARO
013835e547 Use HasRight() (#30333) 2024-07-10 18:59:04 +02:00
Frédéric FRANCE
b91858863b add missing token (#30232) 
* add missing token

* Update card.php
 2024-07-02 01:51:31 +02:00
Frédéric FRANCE
f8f2a83323 Clean date (#30228) 
* clean date phpdoc

* add phpdoc
 2024-07-01 19:06:24 +02:00
Alexandre SPANGARO
96afcaa476 Better comments (#30200) 
* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* CI Missing language key

* Update eventorganization.lang

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-06-30 21:02:50 +02:00
Christian Humpel
ada3ed0a7c Fix: different behavior on extrafield updates. (#30150) 2024-06-25 10:44:36 +02:00
Frédéric FRANCE
d65b370236 fix fichinter card rec (#30130) 
* fix fichinter card rec

* fix fichinter card rec

* Update interventions.lang

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-06-22 15:49:31 +02:00