2
0
forked from Wavyzz/dolibarr
Commit Graph

34393 Commits

Author SHA1 Message Date
Frédéric FRANCE
e00a9816f8 fix phpstan (#28727)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-03-09 14:48:06 +01:00
thibdrev
2cb4d40e5e qual: phan for functions.lib.php (#28655)
* Update card.php

* Update functions.lib.php

* Update card.php

* Update releve.php

* Update card-rec.php

* Update card.php

* Update prelevement.php

* Update card.php

* Update index.php

* Update index.php

* Update html.form.class.php

* Update card.php

* Update conferenceorbooth_card.php

* Update conferenceorbooth_contact.php

* Update conferenceorbooth_document.php

* Update conferenceorbooth_list.php

* Update conferenceorboothattendee_card.php

* Update conferenceorboothattendee_list.php

* Update shipment.php

* Update card.php

* Update card-rec.php

* Update card.php

* Update card.php

* Update document.php

* Update card.php

* Update comment.php

* Update element.php

* Update ganttview.php

* Update tasks.php

* Update comment.php

* Update contact.php

* Update document.php

* Update note.php

* Update task.php

* Update time.php

* Update card.php

* Update card.php

* Update bank.php

* Update card.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-09 01:49:07 +01:00
Laurent Destailleur
a8444e72cd Use user->hasRight 2024-03-09 01:45:31 +01:00
Laurent Destailleur
dccb730e66 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-09 01:28:01 +01:00
MDW
746ca01423 Fix: Correctly close active output buffer. (#28723)
# Fix: Correctly close active output buffer.

Use ob_get_clean(), not ob_get_contents() and ob_clean().

Tests were failing with:
FunctionsLibTest::testVerifCond with data set "Test that verifConf("0") returns false" ('0', false)
Test code or tested code did not (only) close its own output buffers

OK, but incomplete, skipped, or risky tests\!

Also refactored a test case to use a data provider which helped identify that it was related
to dol_eval.
2024-03-09 01:27:01 +01:00
Laurent Destailleur
78786a0b53 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-09 01:15:59 +01:00
MDW
6d857757e9 Qual: Improve typing hint for (ext)Object, and allow null (#28719)
* Qual: Improve typing hint for (ext)Object, and allow null

# Qual: Improve typing hint for object, and allow null

As the key "->element" is expected, the object type should be derived from CommonObject.
Also extObject can be nullable

* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()

* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()

* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()

* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()

* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()

* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()

* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()
2024-03-09 01:12:03 +01:00
Laurent Destailleur
1a7bfbc15a Clean code 2024-03-09 01:11:52 +01:00
MDW
4de7c67010 Qual: PhanCompatibleNegativeStringOffset must be suppressed (#28720)
# Qual: PhanCompatibleNegativeStringOffset must be suppressed

Apparently the PhanCompatibleNegativeStringOffset notice can not be avoided
through the '>=1' condition hint, so suppress it explicitly
2024-03-09 01:06:37 +01:00
JeromeBARBOTIN
5371db3c0b FIX: Verification of variables (#28623)
* Verifcation of variables

Modification of the variable setting before its use.

* To check if the property exists

* Modification as per @frederic34 suggestion

* Update propal.class.php

* Application of coding rules

Modification of the called function.

* Verification of variables

* Verification of variable

* Typo error

* Update actions_sendmails.inc.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-08 22:50:15 +01:00
MDW
3d0a85608b Qual: Fix and enable alias deprecation detection (#28716)
* Qual: Ignore some false positives for deprecated functions

# Qual: Ignore some false positives for deprecated functions

The Phan Deprecation Plugin for internal functions has mixed up some
mail functions and lists them as deprecated, this ignores that

* Qual: Enable detection and fixing of internal deprecations

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Update codespell lines ignore list after format

# Qual: Update codespell lines ignore list after forma

Done using latest library, so also adds some exceptions that are needed
in the future;

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-08 21:34:18 +01:00
MDW
f309d1634c Qual: Better hint for index value for phan (#28712)
# Qual: Better hint for index value for phan.

($i - 1) must be >= 0, so update test from $i>0 to $i>=1 .
This helps static analysis.
2024-03-08 21:30:46 +01:00
MDW
d846044e38 Fix: $form argument to price() must be int (#28699)
* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0

* Fix: $form argument to price() must be int

# Fix: $form argument to price() must be int

Changed '' for $form into 0
2024-03-08 21:30:04 +01:00
MDW
9cc3476765 Fix: PHPDoc annotations in unappropriate comment (#28713)
* Fix: PHPDoc annotations in unappropriate comment

# Fix: PHPDoc annotations in unappropriate comment

PHPDoc annotations need to be in /** */ or // comments.
Fixed that (change type, move comment, add suppress directive)

* Fix: PHPDoc annotations in unappropriate comment

# Fix: PHPDoc annotations in unappropriate comment

PHPDoc annotations need to be in /** */ or // comments.
Fixed that (change type, move comment, add suppress directive)

* Fix: PHPDoc annotations in unappropriate comment

# Fix: PHPDoc annotations in unappropriate comment

PHPDoc annotations need to be in /** */ or // comments.
Fixed that (change type, move comment, add suppress directive)

* Fix: PHPDoc annotations in unappropriate comment

# Fix: PHPDoc annotations in unappropriate comment

PHPDoc annotations need to be in /** */ or // comments.
Fixed that (change type, move comment, add suppress directive)

* Update dolreceiptprinter.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-08 21:27:09 +01:00
Laurent Destailleur
7ab339e97f Fix regression 2024-03-08 17:54:32 +01:00
Laurent Destailleur
6df4a5eded Use a better name for thirdparties site account 2024-03-08 16:42:49 +01:00
MDW
7fd606b336 Qual: Ignore/workaround SuspiciousParamOrder detection (#28688)
* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)
2024-03-08 12:34:25 +01:00
thibdrev
cc5366249a qual: phpdoc for htdocs/core/db/mysqli.class.php (#28703)
PHPDoc update to reflect what the code does today.

This update however doesn't solve this PHPStan warning:
htdocs/core/db/mysqli.class.php	243	Return type (mysqli|null) of method DoliDBMysqli::connect() should be compatible with return type (resource) of method Database::connect()
2024-03-08 12:10:09 +01:00
MDW
79adb60cf5 Qual: Add instanceof tests to help static typing analysis (#28696)
# Qual: Add instanceof tests to help static typing analysis

Added instanceof tests to help identify that properties exist.
2024-03-07 23:09:25 +01:00
Anthony Berton
ff03f86a50 NEW - See the documents of my subordinates (#28318)
* NEW - See the documents of my subordinates

* cop

* Rewriting

* up

* ok

* FIX - Restriction on sale representative

---------

Co-authored-by: Anthony Berton <anthony.berton@bb2a.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 22:47:29 +01:00
Frédéric FRANCE
3035a7bc7f fix phpstan (#28695)
* fix phpstan

* fix typo

* fix phpstan

* fix phpstan

* fix phpstan
2024-03-07 22:13:09 +01:00
Frédéric FRANCE
c2379bfdf5 fix phpstan (#28694)
* fix phpstan

* fix typo

* fix phpstan
2024-03-07 21:39:29 +01:00
John BOTELLA
7b5982de5b NEW : Factoring and Fix external module elementType limit - Part 02 (#28666)
* Fix element type size

* Factoring getElementType

* Update commonobject.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 20:32:41 +01:00
Rikard Bosnjakovic
901fd65ad9 Fix #20209 (#28692)
When using multiple languages Dolibarr sometimes switches languages depending on settings. By not loading the "main" file, the proper date formats will not be used and this leads to inconsistency.
2024-03-07 20:24:37 +01:00
thibdrev
e2026a1c14 qual: phan for functions.lib.php (#28654)
6 entries for:

TypeError PhanTypeMismatchArgumentProbablyReal Argument 5 ($objcon) is null of type null but \show_actions_messaging() takes \Contact|string (no real type) defined at htdocs/core/lib/functions.lib.php:13081
2024-03-07 20:23:45 +01:00
thibdrev
07b2850c27 qual: phpstan for htdocs/compta/paiement/class/paiement.class.php (#28689)
htdocs/compta/paiement/class/paiement.class.php	115	PHPDoc type array of property Paiement::$multicurrency_tx is not covariant with PHPDoc type array|float of overridden property CommonObject::$multicurrency_tx.

htdocs/compta/paiement/class/paiement.class.php	120	PHPDoc type array of property Paiement::$multicurrency_code is not covariant with PHPDoc type array|string of overridden property CommonObject::$multicurrency_code.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-07 20:22:51 +01:00
MDW
63b2fff4a7 Qual: Ignore false positive for suspicious param positions (#28693)
* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored

* Qual: Ignore suspicious param positions

# Qual: Ignore suspicious param positions

Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
2024-03-07 20:16:48 +01:00
Laurent Destailleur
e6b2756c19 QUAL The signature for all ->delete() method has been modified to match
the modulebuilder template (so first param is now always $user), except
  the delete for thirdparty (still accept the id of thirdparty to delete
as first parameter). Will probably be modified into another version.
2024-03-07 17:58:02 +01:00
William Mead
f1c7b5729f Fix resource list (#28661)
* Move sql SELECT request to list

* Refactored list. Added mass actions. Added contributor details.

* Added dolresource delete

* Cleaned code
2024-03-07 17:01:36 +01:00
Sylvain Legrand
27f88b3ad5 Fix error using MAIN_FILL_SERVICE_DATES_FROM_LAST_SERVICE_LINE (#28662)
With PHP 8.1 an error occurs when editing the first line of a document
2024-03-07 16:57:53 +01:00
Frédéric FRANCE
14ffa142aa fix precommit and clean code (#28651)
* fix precommit

* fix precommit

* fix missing include

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* clean code

* clean code
2024-03-07 16:57:29 +01:00
thibdrev
b9c843c086 qual: phan for functions.lib.php (#28653)
* qual: phan for functions.lib.php

54 entries for:

TypeError PhanTypeMismatchArgumentProbablyReal Argument 3 ($exclude) is null of type null but \getCommonSubstitutionArray() takes array (no real type) defined at htdocs/core/lib/functions.lib.php:8285

* phpcs
2024-03-07 16:55:12 +01:00
thibdrev
af9704acdc qual: phpdoc for htdocs/core/lib/pdf.lib.php (#28671) 2024-03-07 16:41:39 +01:00
MDW
38e69184d1 Fix typing hints (#28676) 2024-03-07 16:04:39 +01:00
thibdrev
18cc09fae6 qual: phan for htdocs/core/lib/ajax.lib.php (#28672)
29 entries for:

Argument 3 ($entity) is null of type null but \ajax_constantonoff() takes int (no real type) defined at htdocs/core/lib/ajax.lib.php:645
2024-03-07 16:02:14 +01:00
Laurent Destailleur
21ef877772 Remove not used email layout 2024-03-07 11:07:28 +01:00
Laurent Destailleur
c0ee90aa7d Exclude require, include into dol_eval 2024-03-06 17:13:05 +01:00
Laurent Destailleur
7866ee472b QUAL Clean code around dol_eval use 2024-03-06 17:07:24 +01:00
Laurent Destailleur
f9a2c8ec5d Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-06 15:08:21 +01:00
Laurent Destailleur
f1aa29507a Fix sec more complete list of forbidden function 2024-03-06 15:01:25 +01:00
Laurent Destailleur
5c4c39da2a Debug module AI 2024-03-06 00:46:04 +01:00
John BOTELLA
26c307c0a4 Fix extrafield ajax search default on edit (#28631) 2024-03-05 17:16:11 +01:00
Frédéric FRANCE
a2c92f183c Phpstan fix (#28637)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-03-05 17:12:36 +01:00
thibdrev
2664661afc qual: phan for htdocs/core/lib/functions.lib.php (#28640)
68 entries for "Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299"

Examples (first 10):

htdocs/accountancy/admin/categories.php	155	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/accountancy/admin/categories.php	189	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/accountancy/bookkeeping/card.php	778	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/eventorganization.php	341	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/hrm.php	596	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/hrm.php	603	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/hrm.php	627	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/knowledgemanagement.php	293	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/knowledgemanagement.php	300	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)

htdocs/admin/multicurrency.php	115	TypeError PhanTypeMismatchArgumentProbablyReal Argument 1 ($mesg) is null of type null but \setEventMessages() takes string (no real type) defined at htdocs/core/lib/functions.lib.php:9299 (the inferred real argument type has nothing in common with the parameter's phpdoc type)
2024-03-05 16:32:40 +01:00
Sébastien NASSIET
cb77ff0a16 Set import_key in import when update record (#28644)
* fix can't delete pdf if ref is not encoded (#28630)

* fix typo in ChangeLog (#28613)

* fix typo in ChangeLog

* Update ChangeLog

* FIX: Count of virtual stock at Services and MoLine with disabled stock change (#28580)

* fix the count of virtual stock

* - fix "Found non sanitized string" ?

---------

Co-authored-by: christian.humpel <christian.humpel@gmail.com>

* Set import_key in import when update record

* Set import_key in import when update record

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: Christian Humpel <78662388+Humml87@users.noreply.github.com>
Co-authored-by: christian.humpel <christian.humpel@gmail.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-05 16:11:32 +01:00
PsyCrow
13f3dcf39c FIX #28641 (#28642)
* FIX #28641

FIX #28641 Annoying autocomplete on datepicker

* Update html.form.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-05 15:56:38 +01:00
Laurent Destailleur
bf6c662d25 Fix phpunit 2024-03-05 04:06:21 +01:00
Laurent Destailleur
d7f3feba74 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-05 04:00:09 +01:00
Laurent Destailleur
cda8a7d241 css 2024-03-05 03:57:56 +01:00
Laurent Destailleur
c544efec7f QUAL: Remove use of customurl filter. Must use the USF syntax. 2024-03-05 03:51:36 +01:00