Wavyzz/dolibarr-fork
2
0
Fork 0
forked from Wavyzz/dolibarr
Code Pull Requests Activity
136,931 Commits 36 Branches 189 Tags
f613752bd3ac0e043d004461d94e9c13c66a9752
Commit Graph

1219 Commits

Author SHA1 Message Date
MDW
54880f92cd Qual: Fix PhanTypeMismatchProperty and some other phan notices (#30542) 
* Qual: Fix PhanTypeMismatchProperty and some other phan notices

* Qual: Phan fixes for BOM

* Phan - fix fields

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Fix $fields phpdoc

* Fix phan typing issues with intermediate var and ??

* Fix phan typing issue with ?? operator

* Ignore htdocs/install/install.forced.php for git

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Update baseline

* Qual: Phan fixes for BOM

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration

* Fix typing hints (phpstan)

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-15 17:05:00 +02:00
MDW
45ed4caeb2 Qual: Enable Phan Simplify rule and fix notices (#30537) 
* Qual: Phan - Enable Simplyfy expression

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Update functions2.lib.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-08-07 03:05:02 +02:00
Laurent Destailleur
e1117a9a67 Merge remote-tracking branch 'origin/20.0' into develop 2024-08-07 02:14:27 +02:00
Laurent Destailleur
af4763d259 Merge remote-tracking branch 'origin/19.0' into 20.0 2024-08-07 01:30:57 +02:00
Laurent Destailleur
a11a477b90 Merge remote-tracking branch 'origin/18.0' into 19.0 2024-08-07 01:29:44 +02:00
MDW
d6948077b2 Qual: Fix spelling/update .pre-commit configuration (versions) (#30546) 
* Qual: Update pre-commit configuration

* Qual: Update spelling

* Ignore use of deprecated constant
 2024-08-07 01:20:43 +02:00
HENRY Florian
650fa5ef1d fix: add missing fetch_optionals() call on OrderLine fetch method (#30560) 2024-08-07 00:09:27 +02:00
Laurent Destailleur
38d8d30c85 Code comment 2024-07-25 13:59:12 +02:00
Christophe Battarel
97b4093d22 FIX : allow setDraft on cancelled orders if ORDER_REOPEN_TO_DRAFT is set (#30396) 
* Fix missing loading trans file

* FIX : allow setDraft on cancelled orders if ORDER_REOPEN_TO_DRAFT is set

---------

Co-authored-by: Laurent Destailleur <eldy@users.sourceforge.net>
Co-authored-by: Christophe Battarel <christophe@altairis.fr>
 2024-07-16 21:54:04 +02:00
Shanty
8c4f3534cc NEW #28871 signed_status to commande (#30359) 
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-07-16 15:22:54 +02:00
Frédéric FRANCE
2f5647e4e3 fix checkFunctionArgumentTypes (#30234) 
* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* add ignore

* add ignore

add ignore

add ignore

add ignore

add ignore

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes
 2024-07-03 02:30:53 +02:00
Frédéric FRANCE
f8a34e7489 phpdoc (#30209) 
* phpdoc

* phpdoc

* phpdoc

* phpdoc
 2024-06-30 21:04:19 +02:00
Frédéric FRANCE
93e111a615 fix phpstan is falsy (#30016) 2024-06-15 16:03:53 +02:00
Zephyriony
c329e4446c Update commande.class.php (#29823) 
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-06-04 10:52:47 +02:00
Frédéric FRANCE
652c8526fa fix cti (#29813) 
* fix cti

* fix cti

* no photo in asset lines

* no photo in asset lines

* no photo in asset lines

* no photo in asset lines

* no photo in recruitment lines

* no photo in recruitment lines

* fix

* fix dead catch
 2024-06-03 13:44:14 +02:00
dono
1ba32d6767 v0.1 (#29772) 2024-06-01 01:22:06 +02:00
Laurent Destailleur
16336a66ad Rename french module name into english 2024-05-13 10:45:20 +02:00
Frédéric FRANCE
d0830b3159 fix phpstan (#29602) 
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

fix phpstan

fix phpstan

fix phpstan

fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
 2024-05-05 00:34:19 +02:00
Zephyriony
6f524405af QUAL Rename column fk_origin_line on shipment lines into fk_elementdet to match a generic use. (#28989) 
* Update expedition.class.php 

Adapting the query and code to the new table format

* Update llx_expeditiondet.sql

* Update expedition.class.php

* Update expedition.class.php

* Update expedition.class.php

* Update expedition.class.php

* Update expedition.class.php

* Update expedition.class.php

* Update expedition.class.php

* Update expedition.class.php

* Update expedition.class.php

* Update llx_expeditiondet.sql

* Update expedition.class.php

* rename fk_origin_line to fk_elementdet

* rename fk_origin_line to fk_elementdet

* rename fk_origin_line to fk_elementdet

* rename fk_origin_line to fk_elementdet

* rename fk_origin_line to fk_elementdet

* rename fk_origin_line to fk_elementdet

* rename fk_origin_line to fk_elementdet

* rename fk_origin_line to fk_elementdet

* rename fk_origin_line to fk_elementdet

* rename fk_origin_line to fk_elementdet

* Update expedition.class.php

* Update expedition.class.php

* rename fk_origin_line to fk_elementdet

* rename fk_origin_line to fk_elementdet

* Update 19.0.0-20.0.0.sql

---------

Co-authored-by: sonikf <93765174+sonikf@users.noreply.github.com>
 2024-04-08 12:44:49 +02:00
Laurent Destailleur
fd9475be03 Use same doc comment eveywhere. 2024-04-07 12:26:27 +02:00
Laurent Destailleur
38fb00489d PHPDoc 2024-04-05 13:44:59 +02:00
Zephyriony
b9c50507ad Fix Order bug 
Fixed the bug that caused the update() function to delete the contents of the fk_user_author field and leave the fk_user_modif field empty.
 2024-03-28 13:00:59 +01:00
Zephyriony
339f9604f6 Fix Order bug 
Fixed the bug that caused the update() function to delete the contents of the fk_user_author field and leave the fk_user_modif field empty.
 2024-03-27 14:59:42 +01:00
Laurent Destailleur
0465aeb412 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into 
develop
 2024-03-27 11:39:26 +01:00
Laurent Destailleur
dc43a7e87b Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-27 11:22:38 +01:00
MDW
6f0b454779 Fix PhanNonClassMethodCall with extra test 2024-03-24 15:40:22 +01:00
MDW
c822795cc1 Fix PhanTypeInvalid{Left,Right}OperandOfNumericOp mostly by typing, casting, idate 2024-03-23 02:06:24 +01:00
Delthair
5f1796b39a FIX #29029 Impossible to delete an order line 
Impossible to delete a line because the code lead to add an error if the request is valid therefore leading to a rollback of the request
 2024-03-22 18:49:12 +01:00
MDW
170a929656 Fix $mybool |=... which is binary op, not boolean op 
# Fix $mybool |=... which is binary op, not boolean op

This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
 2024-03-21 13:45:04 +01:00
MDW
ff3c33206c Fix arg type to preg_match() and trim with cast 2024-03-20 04:08:30 +01:00
Laurent Destailleur
e9e2105508 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 
Conflicts:
	htdocs/accountancy/class/bookkeeping.class.php
	htdocs/core/class/CMailFile.class.php
	htdocs/core/lib/functions.lib.php
	htdocs/ticket/class/ticket.class.php
 2024-03-19 18:12:13 +01:00
Laurent Destailleur
43a3f449c4 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-19 17:07:51 +01:00
Kamel Khelifa
426e18ea33 Correction syntax 2024-03-19 14:31:15 +01:00
Kamel Khelifa
07c84df3dc FIX: Move the trigger for delete order line before the SQL request 2024-03-19 14:23:02 +01:00
MDW
fd9d48faac Fix phpstan CommonObject->fields - notnull is optional field 2024-03-19 00:32:00 +01:00
MDW
13ab939691 Fix deprecated function calls 2024-03-16 13:27:51 +01:00
Laurent Destailleur
e15f243e95 Clean code - Remove a deprecated tag that should not exists. 2024-03-16 11:51:32 +01:00
MDW
23785393a3 Add csslist to json keys 2024-03-15 03:55:52 +01:00
MDW
5263bc81dc Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:44:44 +01:00
Frédéric FRANCE
23b0faeb44 Merge branch 'develop' into skiljob 2024-03-14 11:04:11 +01:00
Laurent Destailleur
c867bc2706 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-13 22:36:45 +01:00
Laurent Destailleur
8bfc0779c4 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-13 22:20:08 +01:00
Laurent Destailleur
a0b26ae7cd FIX Amount of localtaxes in foreign currency was wrong on screen and PDF 2024-03-13 22:04:44 +01:00
Frédéric France
26fe76733c fix warnings 2024-03-13 18:20:41 +01:00
Laurent Destailleur
a6926c29c0 Merge pull request #28778 from fappels/develop_fix_delivery_note 
Fix shipping is not a delivery_note (is sub module of shipping)
 2024-03-12 14:53:51 +01:00
MDW
88d59896ec Qual: 'enabled' in fields can be string ('isModEnabled(...)') 
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')

Update PHPdoc to allow that enabled is a string
 2024-03-12 13:38:08 +01:00
Francis Appels
7ff68a5819 Fix shipping is not a delivery_note (sub module of shipping) 2024-03-12 11:07:18 +01:00
MDW
3f5a3b03ee Fix: Repeat fields typing in CommonClass children 
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
 2024-03-11 17:38:57 +01:00
Frédéric FRANCE
fba15178eb all initAsSpecimen return int (#28577) 
* all initAsSpecimen return int

* all initAsSpecimen return int

* all initAsSpecimen return int
 2024-03-02 16:38:35 +01:00
MDW
c332251816 Fix: Replace deprecated module names in code strings (#28462) 
* Fix: Replace deprecated module names in code strings

# Fix: Replace deprecated module names in code strings

A few cases that slipped through the manual replacements

* Qual: Enable deprecation notices in CodingPhpTest for isModEnabled

# Qual: Enable deprecation notices in CodingPhpTest for isModEnabled

As all detections are now fixed, we can enable the deprecation notice
trigger in the CodingPhpTest.
 2024-02-28 23:01:01 +01:00