MDW 2496d20d4f Fix nullable return with if($ok == 1) in stead of if($ok) ...

# Fix nullable return with if($ok == 1) in stead of if($ok)

This seems to be a bug in Phan where if($ok) changes the type of $ok.
Testing with '$ok == 1' instead fixes the issue.

This has been reported to the phan team.

2024-03-21 00:28:14 +01:00

..

action

QUAL Use phan to help detect new issues (#27706)

2024-02-21 18:14:29 +01:00

asset

Merge pull request #28809 from mdeweerd/PhanPluginPrintfIncompatibleArgumentTypeWeak

2024-03-15 16:32:40 +01:00

bank

Qual: Ignore/workaround SuspiciousParamOrder detection (#28688)

2024-03-08 12:34:25 +01:00

barcode

Fix bad typing in thirdparty lib (TCPDF) with cast

2024-03-19 02:59:20 +01:00

bom

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

cheque

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

commande

Fix arg type to str_replace() and preg_match() with casts

2024-03-19 22:52:27 +01:00

contract

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

delivery

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

dons

Fix arg type to str_replace() with casts

2024-03-19 22:52:29 +01:00

expedition

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

expensereport

Fix arg type to strlen() with cast, improve conversion to int

2024-03-19 22:52:30 +01:00

export

Fix warnings

2024-03-11 14:28:55 +01:00

facture

Fix arg type to preg_match(),str_replace() with casts

2024-03-19 22:52:32 +01:00

fichinter

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

holiday

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

hrm

Merge pull request #28809 from mdeweerd/PhanPluginPrintfIncompatibleArgumentTypeWeak

2024-03-15 16:32:40 +01:00

import

Fix PhanPluginSuspiciousParamPosition

2024-03-14 19:39:35 +01:00

mailings

Fix: Replace deprecated modulename with new in isModEnabled (#28452)

2024-02-27 15:30:37 +01:00

member

Merge pull request #28809 from mdeweerd/PhanPluginPrintfIncompatibleArgumentTypeWeak

2024-03-15 16:32:40 +01:00

movement

Clean translations

2024-03-20 15:15:28 +01:00

mrp

Fix arg type to abs() with casts

2024-03-19 22:52:33 +01:00

oauth

Fix: GETPOST(...,'int') to GETPOSTINT(...) (#28448)

2024-02-27 14:05:53 +01:00

payment

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

printing

Qual: Apply automatic phan fixes (deprecations, unneeded imports) (#28154)

2024-02-13 21:46:12 +01:00

printsheet

Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname

2024-03-12 18:40:06 +01:00

product

Fix deprecated function calls

2024-03-16 13:27:51 +01:00

product_batch

Fix arg type to preg_match() with cast

2024-03-19 22:52:34 +01:00

project

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

propale

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

rapport

Qual: Ignore/workaround SuspiciousParamOrder detection (#28688)

2024-03-08 12:34:25 +01:00

reception

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

security/generate

fix phpstan (#28568)

2024-03-02 12:40:25 +01:00

societe

Fix PhanTypeMismatchReturn by changing return and logging error

2024-03-20 21:58:39 +01:00

stock

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:51 +01:00

stocktransfer

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

supplier_invoice

Fix arg type to preg_match(),str_replace() with casts

2024-03-19 22:52:35 +01:00

supplier_order

Fix arg type to preg_match(),str_replace() with casts

2024-03-19 22:52:37 +01:00

supplier_payment

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

supplier_proposal

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

syslog

Fix PhanParamSuspiciousOrder by suppressing notification

2024-03-17 20:12:53 +01:00

takepos

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

ticket

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

user

Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop

2024-03-11 18:30:27 +01:00

usergroup

Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop

2024-03-11 18:30:27 +01:00

workstation

Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

2024-03-14 23:00:47 +01:00

DolibarrModules.class.php

Fix nullable return with if($ok == 1) in stead of if($ok)

2024-03-21 00:28:14 +01:00

modAccounting.class.php

Fix add a type to allow sanitization of import rule='compute'.

2024-03-07 21:38:40 +01:00

modAdherent.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modAgenda.class.php

Fix hasRights into hasRight

2024-03-19 22:02:42 +01:00

modAi.class.php

Debug v20

2024-03-14 16:40:06 +01:00

modApi.class.php

Use user->hasRight

2024-03-09 01:45:31 +01:00

modAsset.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modBanque.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modBarcode.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modBlockedLog.class.php

Use user->hasRight

2024-03-09 01:45:31 +01:00

modBom.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:08 +01:00

modBookCal.class.php

Debug v20

2024-03-14 16:40:06 +01:00

modBookmark.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modCategorie.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:10 +01:00

modClickToDial.class.php

…

modCollab.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:11 +01:00

modCommande.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:12 +01:00

modComptabilite.class.php

…

modContrat.class.php

…

modCron.class.php

Use user->hasRight

2024-03-09 01:45:31 +01:00

modDataPolicy.class.php

Clean code: Remove code not working (was using hard coded values)

2024-02-02 21:41:40 +01:00

modDav.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modDebugBar.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modDeplacement.class.php

Qual: Apply automatic phan fixes (deprecations, unneeded imports) (#28154)

2024-02-13 21:46:12 +01:00

modDocumentGeneration.class.php

…

modDon.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modDynamicPrices.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modECM.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:13 +01:00

modEmailCollector.class.php

Use user->hasRight

2024-03-09 01:45:31 +01:00

modEventOrganization.class.php

Fix hasRights into hasRight

2024-03-19 22:02:42 +01:00

modExpedition.class.php

Qual: Apply automatic phan fixes (deprecations, unneeded imports) (#28154)

2024-02-13 21:46:12 +01:00

modExpenseReport.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:15 +01:00

modExport.class.php

…

modExternalRss.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modExternalSite.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:16 +01:00

modFacture.class.php

Rename files to use an english name

2024-03-10 15:52:29 +01:00

modFckeditor.class.php

…

modFicheinter.class.php

…

modFournisseur.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:17 +01:00

modFTP.class.php

…

modGeoIPMaxmind.class.php

…

modGravatar.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:18 +01:00

modHoliday.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:20 +01:00

modHRM.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:19 +01:00

modImport.class.php

…

modIncoterm.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:21 +01:00

modIntracommreport.class.php

…

modKnowledgeManagement.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:22 +01:00

modLabel.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modLdap.class.php

…

modLoan.class.php

…

modMailing.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modMailmanSpip.class.php

…

modMargin.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:23 +01:00

modModuleBuilder.class.php

Debug AI module

2024-01-27 02:04:43 +01:00

modMrp.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modMultiCurrency.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modNotification.class.php

…

modOauth.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:24 +01:00

modOpenSurvey.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:25 +01:00

modPartnership.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:26 +01:00

modPaybox.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:26 +01:00

modPaymentByBankTransfer.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:27 +01:00

modPaypal.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:28 +01:00

modPrelevement.class.php

…

modPrinting.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modProduct.class.php

Merge pull request #28814 from atm-jonathan/NEW_import_kit

2024-03-13 18:14:33 +01:00

modProductBatch.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:30 +01:00

modProjet.class.php

New functionality for add cronjob (#28282)

2024-02-20 00:44:09 +01:00

modPropale.class.php

Added customer code export (#28309)

2024-02-20 18:45:03 +01:00

modReceiptPrinter.class.php

FIX Debug setup of module TakePOS

2024-01-24 03:34:42 +01:00

modReception.class.php

Merge pull request #27528 from altairisfr/rdb

2024-03-17 21:31:27 +01:00

modRecruitment.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:31 +01:00

modResource.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:32 +01:00

modSalaries.class.php

…

modService.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:33 +01:00

modSocialNetworks.class.php

qual: phpstan - various "$hidden (bool) does not accept string." (#28350)

2024-02-22 13:27:04 +01:00

modSociete.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:34 +01:00

modStock.class.php

Fix picto

2024-03-17 00:35:06 +01:00

modStockTransfer.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:36 +01:00

modStripe.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:37 +01:00

modSupplierProposal.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modSyslog.class.php

…

modTakePos.class.php

qual: phpstan - various fixes (#28351)

2024-02-22 13:22:06 +01:00

modTax.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00

modTicket.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:38 +01:00

modUser.class.php

Fix: Replace deprecated modulename with new in isModEnabled (#28452)

2024-02-27 15:30:37 +01:00

modVariants.class.php

…

modWebhook.class.php

Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop

2024-02-29 15:48:50 +01:00

modWebPortal.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:39 +01:00

modWebServices.class.php

…

modWebServicesClient.class.php

Clean code

2024-02-29 20:05:37 +01:00

modWebsite.class.php

Use user->hasRight

2024-03-09 01:45:31 +01:00

modWorkflow.class.php

Fix PhanPluginRedundantAssignment

2024-03-13 01:04:40 +01:00

modWorkstation.class.php

Fix hasRights into hasRight

2024-03-19 22:02:42 +01:00

modZapier.class.php

Qual: Spelling htdocs/core (#27491)

2024-01-13 19:48:20 +01:00