From 0680d4e9108df0e4b4fd8a8fa3615c0a6dcaa2ef Mon Sep 17 00:00:00 2001 From: Laurent Destailleur Date: Mon, 4 Nov 2024 12:37:28 +0100 Subject: [PATCH] Clean code --- htdocs/compta/localtax/clients.php | 2 -- htdocs/compta/localtax/index.php | 2 -- htdocs/compta/localtax/quadri_detail.php | 2 -- htdocs/webhook/target_card.php | 2 -- 4 files changed, 8 deletions(-) diff --git a/htdocs/compta/localtax/clients.php b/htdocs/compta/localtax/clients.php index ba4641fac79..8636237f6dd 100644 --- a/htdocs/compta/localtax/clients.php +++ b/htdocs/compta/localtax/clients.php @@ -113,8 +113,6 @@ $result = restrictedArea($user, 'tax', '', '', 'charges'); if (empty($local)) { accessforbidden('Parameter localTaxType is missing'); - // @phan-suppress-next-line PhanPluginUnreachableCode - exit; // accessforbidden already exits @phpstan-ignore-line } $calc = 0; diff --git a/htdocs/compta/localtax/index.php b/htdocs/compta/localtax/index.php index 362f554d4ce..64b88cab23e 100644 --- a/htdocs/compta/localtax/index.php +++ b/htdocs/compta/localtax/index.php @@ -199,8 +199,6 @@ function pt($db, $sql, $date) if (empty($localTaxType)) { accessforbidden('Parameter localTaxType is missing'); - // @phan-suppress-next-line PhanPluginUnreachableCode - exit; // accessforbidden already exits @phpstan-ignore-line } diff --git a/htdocs/compta/localtax/quadri_detail.php b/htdocs/compta/localtax/quadri_detail.php index 6746bfe336e..96556196a0d 100644 --- a/htdocs/compta/localtax/quadri_detail.php +++ b/htdocs/compta/localtax/quadri_detail.php @@ -121,8 +121,6 @@ $result = restrictedArea($user, 'tax', '', '', 'charges'); if (empty($local)) { accessforbidden('Parameter localTaxType is missing'); - // @phan-suppress-next-line PhanPluginUnreachableCode - exit; // accessforbidden already exits @phpstan-ignore-line } diff --git a/htdocs/webhook/target_card.php b/htdocs/webhook/target_card.php index 9c6f33b50b2..19f131cdc60 100644 --- a/htdocs/webhook/target_card.php +++ b/htdocs/webhook/target_card.php @@ -228,8 +228,6 @@ llxHeader('', $title, $help_url, '', 0, 0, $arrayofjs, $arrayofcss, '', 'mod-web if ($action == 'create') { if (empty($permissiontoadd)) { accessforbidden('NotEnoughPermissions', 0, 1); - // @phan-suppress-next-line PhanPluginUnreachableCode - exit; // accessforbidden already exits @phpstan-ignore-line } print load_fiche_titre($langs->trans("NewObject", $langs->transnoentitiesnoconv("Target")), '', 'object_'.$object->picto);